There shouldn't be any imports of material ui

https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1600881430

@MayaSatishRao any updates on this?

https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1600284244

Oh damn, didn't notice that when merged develop into this 😅

https://github.com/coronasafe/care_fe/pull/5666#issuecomment-1600283492

See how searches work in other places. You might need to make backend changes too for this.

https://github.com/coronasafe/care_fe/issues/5695#issuecomment-1596595032

Do create the PR though, we can take that issue seperatley

https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595745835

Yes, if that issue is present in existing staging, yes create the issue!

https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595745660

@print-Sathvik any updates on this? Avoid taking up multiple issues.

https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595696208

@print-Sathvik any updates on this?

https://github.com/coronasafe/care_fe/issues/4977#issuecomment-1595696092

You won't need to make any modifications to the components. You can use `SelectFormField` instead of `SelectMenuV2`. Read the doc comments of each component or other usages to get a better understanding of how it is to be used.

https://github.com/coronasafe/care_fe/issues/5407#issuecomment-1595679645

Reopening as this commit was reverted as it was buggy.

https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1595600935

Sign up is not allowed. Superusers can create accounts for state admins and/or district admins. These users can create other type of accounts under the same state or district which that user belongs to.

https://github.com/coronasafe/care_fe/issues/5710#issuecomment-1595044712

@abhishekchauhan15 closing this as of no activity. I'm taking up the issue and I will make a PR for the same to speed up removal of MUI.

https://github.com/coronasafe/care_fe/pull/5607#issuecomment-1594986843

You can set min. qty for stocks if u go to set min. quantity page. that data should be reflected in a new column here.

https://github.com/coronasafe/care_fe/issues/2549#issuecomment-1594950122

@akshatvermavi I think you can clearly see that there's a PR already for this right?

https://github.com/coronasafe/care_fe/issues/5005#issuecomment-1594941718

@akshatvermavi ask for assigning if its not assigned to anyone, or if its assigned to someone but no progress in PR for more than a week

https://github.com/coronasafe/care_fe/issues/4972#issuecomment-1594941063

Yes! Without it being functional there's no way the PR would get merged 😄

https://github.com/coronasafe/care_fe/issues/5695#issuecomment-1594095616

Nope 😅 we don't have such workflows. I voluntarily took it up to prevent conflicts with the tailwinding prs

https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593494912

https://github.com/coronasafe/care_fe/issues?q=is%3Aissue+is%3Aopen+no%3Aassignee

https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593436317

np 😄 feel free to take up other issues

https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593435650

@kunal00000 @Mustafa-Azad025 nope, avoid asking for assigning if it's already assigned to someone. (Unless it doesn't have a PR for more than a week) This issue is closely related to an existing PR, so I will be pushing directly to that branch to prevent conflicts.

https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593433723

Also, this is related with a PR that I've already made so will be pushing a fix to that branch directly.

https://github.com/coronasafe/care_fe/issues/5693#issuecomment-1593424567

@Mustafa-Azad025 I think its visible that it's already assigned right? Also, refrain from taking up multiple issues at once when you haven't made PRs for others yet.

https://github.com/coronasafe/care_fe/issues/5693#issuecomment-1593423591

Updated the cypress tests for Patient CRUD and is passing locally with local backend. Would fail in CI as backend is not merged yet. 

https://github.com/coronasafe/care_fe/pull/5599#issuecomment-1593047184

probable conflict with https://github.com/coronasafe/care_fe/pull/5623 cc: @Ashesh3

https://github.com/coronasafe/care_fe/issues/5690#issuecomment-1593003922

Also update the PR title to something meaningful. "Other browser" doesn't make any sense

https://github.com/coronasafe/care_fe/pull/5682#issuecomment-1592557205

Kindly link the issue in the PR with closing tags

https://github.com/coronasafe/care_fe/pull/5682#issuecomment-1592554006

You could've pushed the changes in this PR itself on the same branch right?

https://github.com/coronasafe/care_fe/pull/5612#issuecomment-1592550009

.bs files are generated files. You need to update the rescript files

https://github.com/coronasafe/care_fe/issues/5088#issuecomment-1592357276

Hey @Mustafa-Azad025 @patelaryan7751 As part of replacing Material UI to custom components, the Sample Preview page will almost be fully rewritten very soon this week and your PR may be rendered obsolete. Feel free to take up other issues! cc: @khavinshankar

https://github.com/coronasafe/care_fe/issues/5646#issuecomment-1591732401

Looks like you've made a new PR

https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590825059

You've not made any commits to this branch i guess

https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590822983

With `whitespace-pre-wrap` 

https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590424517

@Mustafa-Azad025 any updates on this?

https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590404113

@SahilSingh177 can you refrain from force pushing?

https://github.com/coronasafe/care_fe/pull/5620#issuecomment-1589867595

@rithviknishad to fix cypress

https://github.com/coronasafe/care_fe/pull/5655#issuecomment-1589826117

https://github.com/orgs/community/discussions/25937#discussioncomment-3249747

https://github.com/coronasafe/care_fe/pull/5623#issuecomment-1589157276

Its a small conflict so you can just use github's editor itself if you want

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1589052616

I do it without rebase. ``` git merge develop git checkout <pr-branch> git merge develop # Resolve conflicts in editor continue merge ```

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1589050514

Also update your PR title to something meaningful.

https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1587766443

Yes!

https://github.com/coronasafe/care_fe/issues/5468#issuecomment-1584537993

Also, update the PRs title to be something meaningful like what your PR does. And it's nice to have screenshots too!

https://github.com/coronasafe/care_fe/pull/5640#issuecomment-1584535816

@kunal00000 are you working on this or free for others to take it up?

https://github.com/coronasafe/care_fe/issues/5633#issuecomment-1584399159

Other than that everything LGTM, have a look at how `SelectFormField` is used in other places.

https://github.com/coronasafe/care_fe/pull/5623#issuecomment-1584395255

I think we can just wrap the `PatientConsultation.objects.get(...)` whichever is causing the issue with `get_object_or_404` right?

https://github.com/coronasafe/care/issues/1348#issuecomment-1581172893

@Yash12Bansal kindly fill in the issue comment clearly so that someone would understand when they test or look back into this at a later point in time.

https://github.com/coronasafe/care_fe/issues/5611#issuecomment-1580773848

@nihal467 this is not failing because of his PR

https://github.com/coronasafe/care_fe/pull/5582#issuecomment-1576805181

@MayaSatishRao any updates on this?

https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1576611976

@sainak it's already in the OHC domain right? I do see that I've changed it from the diff.

https://github.com/coronasafe/care_fe/pull/5587#issuecomment-1575807325

@perminder-17 a PR is already present that fixes this issue as you can clearly see above.

https://github.com/coronasafe/care_fe/issues/5595#issuecomment-1575458653

@yaswanthsaivendra also could you prefix the issue numbers with "Fixes" or other linking keywords?

https://github.com/coronasafe/care/pull/1344#issuecomment-1574629425

@satyam0601 you can take up other issues that are not assigned.

https://github.com/coronasafe/care/issues/1334#issuecomment-1573936461

Github is wiered. My local commits are not here

https://github.com/coronasafe/care_fe/pull/5583#issuecomment-1573766146

@JahnabDutta you are expected to update the cypress tests themselves if you think cypress is made for old components.

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573728462

Consider refactoring '--' away. '--' as of now means 'Filter not applied' You may make the filters behaviour / value consistent with other filters like Patient Filters / Asset Filter / Facility Filter.

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573608812

Consider refactoring '--' to be considered as "Filter Not Applied"

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573606384

@gitone912 have u referred to the first comment's link? We already have the front-end changes. You just need to add backend support for the same to function.

https://github.com/coronasafe/care/issues/1327#issuecomment-1573205527

@gitone912 This is a backend issue. Currently our backend does not support CSV export for Assets. JSON export is handled in front-end. However, CSV exports are handled in backend. Do not remove JSON support. JSON support is important, CSV support is just a good to have.

https://github.com/coronasafe/care/issues/1327#issuecomment-1573165910

Yes! Have a look at patient csv export/import. It should be similar, just that this is in addition to JSON for assets.

https://github.com/coronasafe/care/issues/1327#issuecomment-1573144502

@Deepanshu039 any updates?

https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1573111782

Just adding the stats here of our staging file uploads. 

https://github.com/coronasafe/care/issues/1326#issuecomment-1572183682

@meeddhhaa some buttons are allowed only for certain user types/role. So we have `RoleButton` component that serves the purpose. However, its a legacy component since it was built in early days to work along with material ui and all. Nowadays we have `ButtonV2` tailwind based component which is widely used. This custom component also supports disabling based on user type, which can be specified with the `authorizedFor` prop. This way we won't need to use seperate components to restrict access, just use the same ButtonV2 component and add authorizedFor=___. This helps in keeping designs consistent and maintaining the codebase in long run.

https://github.com/coronasafe/care_fe/issues/4370#issuecomment-1571608243

See how its implemented in popups like discharge popup

https://github.com/coronasafe/care_fe/pull/5560#issuecomment-1571584945

All Legacy components should also be replaced with it's equivalent FormField components

https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570706315

You won't have exact word to word component replacement. Checkout how `RadioFormField` is used in other places. You don't need RadioGroup when using that. Same for box and card content, just use divs.

https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570705873

@satyam0601 I'd suggest you to revert the changes in the generic component and instead use classNames to adjust only for the bed select dialog

https://github.com/coronasafe/care_fe/pull/5560#issuecomment-1570680649

read the EPIC #5006 all components are already built.

https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570670717

u r expected to do all that are applicable.

https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570607524

As you can see, it's already having a PR that fixes this issue.

https://github.com/coronasafe/care/issues/1243#issuecomment-1570246773

Open the filters in the shifting page.

https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1570107112

@vigneshhari

https://github.com/coronasafe/care/issues/1321#issuecomment-1569934650

All the queries to the DB have to be profiled to better understand how much time it takes.

https://github.com/coronasafe/care/issues/1321#issuecomment-1569748437

@siddnikh is the PR completed? Title say's you are removing `static_coronasafe_logo` but file changes are only adding the new logos.

https://github.com/coronasafe/care_deploy_configs/pull/16#issuecomment-1568745410

@Yash12Bansal All the instructions are specified above ☝🏼

https://github.com/coronasafe/care_fe/issues/5494#issuecomment-1568320752

Have you pushed your changes?

https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568217153

Why do u think this happens?

https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568216657

Have you removed `force:true` from all fields? Keep pushing changes to your draft PR so that we can have a look at it.

https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568203769

Optional: Have a look at #5563 on how the `Form` component is used to make handling things easier.

https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1567920107

Not sure how relevant or required this is. But what comes to my mind at first glance are the following: 1. We could archive it instead maybe? (set `is_archived=True`) 2. Do this only for records with `created_date` older than 1 day? (to avoid running this task over records that are being uploaded at the moment) 3. When we upload a file, is the front end aware that the file upload to S3 has failed? If not, should we support retrying the upload? @gigincg @vigneshhari what do you think about this?

https://github.com/coronasafe/care/issues/1326#issuecomment-1567755774

Hey @Basharat908 1. Feel free to take up good first issues linked above ☝🏼 and make PRs for the same to familiarise yourself with the codebase. 2. This itself is the front-end codebase/repo. For the backend, refer the links specified above ☝🏼

https://github.com/coronasafe/care_fe/issues/5492#issuecomment-1567745567

@nikhilagastya all unicons are present in care icons. you just need to prefix `care-l-<icon_name>`. Refer the #5006 to know more about care icons

https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1567218542

I've changed the labels to "changes required"

https://github.com/coronasafe/care_fe/issues/4944#issuecomment-1567045176

We can't have this validation for camera's as each bed preset creates new AssetBed record. We might also need to restrict editing asset_type once an asset is created so that a Camera asset with multiple beds should never be updated to be a monitor as it shouldn't be linked with multiple bed. cc: @gigincg @vigneshhari

https://github.com/coronasafe/care/issues/1319#issuecomment-1566690234

You could do: ```js # utils.ts function getTemperaturePreference() : "C" | "F" { return localStorage.getItem('temperature-preference') ?? "C"; } ``` and then in the component: ```jsx <SelectFormField ... value={getTemperaturePreference()} onChange={({value}) => setTemperaturePreference(value)} /> ```

https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1566449782

@somesh202 you can modify the handleSubmit to remove the `e.preventDefault` and make it a void function.

https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1566218395

Do make the new designs consistent with other designs. (Like make it left aligned too)

https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1566150460

Open a patient that has a consultation filed. 

https://github.com/coronasafe/care_fe/issues/4947#issuecomment-1566127889

```bash git checkout <old-branch-name> git merge <this-branch> git push ``` Also, make sure the files have been changed correctly and that there is no more material ui usage on the entire file. After that, you should update your main comment on that PR to link issues related to this PR too.

https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566113248

@bodhish there's a lot of usage of MUI, so we have decided to make an EPIC issue (#5006) to remove file by file. We have already got rid of MUI icons package a while back.

https://github.com/coronasafe/care_fe/issues/4945#issuecomment-1566093814

Or you could make these changes in the other PR itself since that already removes some of the mui componennts, and link 2 issues to that PR if you are facing difficulty.

https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566053074

The changes from other branch are still present. Feel free to create a new branch and re-open another PR. This can mess up when the other PR and this PR merges.

https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566052434

You could create a fresh new branch and re-open another PR and close this. (Or use revert commits)

https://github.com/coronasafe/care_fe/pull/5551#issuecomment-1566023360

You can get started by familiarising with the project with the help of good first issues present in the backend and front end repositories.

https://github.com/coronasafe/care_fe/issues/5493#issuecomment-1565871097

Yes you did mess up your branches ig. You've branched out from your previous PR's branch I assume. When working on a new PR, you can simply do the following: ```bash git checkout develop git pull upstream develop # if you've added upstream remote, you can do this to fetch latest develop so that you always branch from latest develop (or you can simply go to your github repo and fetch latesst changes and do a git pull) git checkout -b "your-new-branch-name" ```

https://github.com/coronasafe/care_fe/pull/5551#issuecomment-1565851360

Yes! This looks nice. You can make use of `SelectFormField` component (with `labelClass="hidden" errorClass="hidden") instead to keep designs consistent across the platform. `SelectFormField` also contains an `optionIcon` prop where you could maybe add degree symbol and C/F.

https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1565847654

@sachdevavaibhav could you replace the following legacy components used in AssetCreate? It indirectly uses MUI. 

https://github.com/coronasafe/care_fe/issues/4945#issuecomment-1565540045