GDC Intern
Creative thinking
1x
2 Issues Created
2x
16 Issues Created
3x
128 Issues Created
4x
1024 Issues Created
Problem Solving
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Practical/Professional Skills
Communication Skills
1x
100th Community Interaction
2x
1000th Community Interaction
3x
10000th Community Interaction
Collaboration
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Community Engagement
1x
100 Activity Points
2x
1000 Activity Points
3x
10000 Activity Points
Leadership
1x
Promoted to a team leader
Learn How to Learn
1x
Completed the course work
Skills to apply digital & technology solutions
1x
1 Project Completed Successfully
2x
2 Projects Completed Successfully
3x
3 Projects Completed Successfully
Critical Thinking
Autonomy And Responsibility
1x
2 issues identified and resolved
2x
16 issues identified and resolved
3x
128 issues identified and resolved
4x
1024 issues identified and resolved
Empathy
Value inculcation
Multicultural Competence
Individual Skills
Creative thinking
Problem Solving
Practical/Professional Skills
Team Skills
Communication Skills
Collaboration
Community Engagement
Leadership
Learn How to Learn
Skills to apply digital & technology solutions
Critical Thinking
Advanced Skills
Autonomy And Responsibility
Empathy
Value inculcation
Multicultural Competence
Cultural Skills
Web Development 101
Web Development 202
Web Development 301
Teaching Assistant & Internship
Industry Placement
Alumni & Teaching Fellow
⚡ An Electrical Engineer by degree and a Software Developer by passion.
Passionate about creating scalable and distributed systems for the power grid and interested in contributing to open source digital public goods.
Shared a comment on a pull request in coronasafe/care_fe on June 21, 2023 at 1:54:16 PM
There shouldn't be any imports of material ui
https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1600881430
Shared a comment on a pull request in coronasafe/care_fe on June 21, 2023 at 6:55:47 AM
@MayaSatishRao any updates on this?
https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1600284244
Shared a comment on a pull request in coronasafe/care_fe on June 21, 2023 at 6:54:58 AM
Oh damn, didn't notice that when merged develop into this 😅
https://github.com/coronasafe/care_fe/pull/5666#issuecomment-1600283492
Shared a comment on an issue in coronasafe/care_fe on June 19, 2023 at 6:38:23 AM
See how searches work in other places. You might need to make backend changes too for this.
https://github.com/coronasafe/care_fe/issues/5695#issuecomment-1596595032
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 1:03:36 PM
Do create the PR though, we can take that issue seperatley
https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595745835
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 1:03:24 PM
Yes, if that issue is present in existing staging, yes create the issue!
https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595745660
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 9:53:13 AM
@print-Sathvik any updates on this? Avoid taking up multiple issues.
https://github.com/coronasafe/care_fe/issues/4952#issuecomment-1595696208
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 9:52:28 AM
@print-Sathvik any updates on this?
https://github.com/coronasafe/care_fe/issues/4977#issuecomment-1595696092
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 9:02:30 AM
You won't need to make any modifications to the components. You can use `SelectFormField` instead of `SelectMenuV2`. Read the doc comments of each component or other usages to get a better understanding of how it is to be used.
https://github.com/coronasafe/care_fe/issues/5407#issuecomment-1595679645
Shared a comment on an issue in coronasafe/care_fe on June 17, 2023 at 3:31:35 AM
Reopening as this commit was reverted as it was buggy.
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1595600935
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 5:52:06 PM
Sign up is not allowed. Superusers can create accounts for state admins and/or district admins. These users can create other type of accounts under the same state or district which that user belongs to.
https://github.com/coronasafe/care_fe/issues/5710#issuecomment-1595044712
Shared a comment on a pull request in coronasafe/care_fe on June 16, 2023 at 5:00:59 PM
@abhishekchauhan15 closing this as of no activity. I'm taking up the issue and I will make a PR for the same to speed up removal of MUI.
https://github.com/coronasafe/care_fe/pull/5607#issuecomment-1594986843
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 4:28:07 PM
You can set min. qty for stocks if u go to set min. quantity page. that data should be reflected in a new column here.
https://github.com/coronasafe/care_fe/issues/2549#issuecomment-1594950122
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 4:21:49 PM
@akshatvermavi I think you can clearly see that there's a PR already for this right?
https://github.com/coronasafe/care_fe/issues/5005#issuecomment-1594941718
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 4:21:15 PM
@akshatvermavi ask for assigning if its not assigned to anyone, or if its assigned to someone but no progress in PR for more than a week
https://github.com/coronasafe/care_fe/issues/4972#issuecomment-1594941063
Shared a comment on an issue in coronasafe/care_fe on June 16, 2023 at 4:54:34 AM
Yes! Without it being functional there's no way the PR would get merged 😄
https://github.com/coronasafe/care_fe/issues/5695#issuecomment-1594095616
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 5:48:51 PM
Nope 😅 we don't have such workflows. I voluntarily took it up to prevent conflicts with the tailwinding prs
https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593494912
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 5:03:51 PM
https://github.com/coronasafe/care_fe/issues?q=is%3Aissue+is%3Aopen+no%3Aassignee
https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593436317
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 5:03:20 PM
np 😄 feel free to take up other issues
https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593435650
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 5:01:51 PM
@kunal00000 @Mustafa-Azad025 nope, avoid asking for assigning if it's already assigned to someone. (Unless it doesn't have a PR for more than a week) This issue is closely related to an existing PR, so I will be pushing directly to that branch to prevent conflicts.
https://github.com/coronasafe/care_fe/issues/5692#issuecomment-1593433723
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 4:58:02 PM
Also, this is related with a PR that I've already made so will be pushing a fix to that branch directly.
https://github.com/coronasafe/care_fe/issues/5693#issuecomment-1593424567
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 4:57:39 PM
@Mustafa-Azad025 I think its visible that it's already assigned right? Also, refrain from taking up multiple issues at once when you haven't made PRs for others yet.
https://github.com/coronasafe/care_fe/issues/5693#issuecomment-1593423591
Shared a comment on a pull request in coronasafe/care_fe on June 15, 2023 at 1:21:16 PM
Updated the cypress tests for Patient CRUD and is passing locally with local backend. Would fail in CI as backend is not merged yet. ![image](https://github.com/coronasafe/care_fe/assets/25143503/e380d6f8-5e9a-4568-99a1-5fd2b4bbafbf)
https://github.com/coronasafe/care_fe/pull/5599#issuecomment-1593047184
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 1:02:32 PM
probable conflict with https://github.com/coronasafe/care_fe/pull/5623 cc: @Ashesh3
https://github.com/coronasafe/care_fe/issues/5690#issuecomment-1593003922
Shared a comment on a pull request in coronasafe/care_fe on June 15, 2023 at 8:00:02 AM
Also update the PR title to something meaningful. "Other browser" doesn't make any sense
https://github.com/coronasafe/care_fe/pull/5682#issuecomment-1592557205
Shared a comment on a pull request in coronasafe/care_fe on June 15, 2023 at 7:58:17 AM
Kindly link the issue in the PR with closing tags
https://github.com/coronasafe/care_fe/pull/5682#issuecomment-1592554006
Shared a comment on a pull request in coronasafe/care_fe on June 15, 2023 at 7:55:21 AM
You could've pushed the changes in this PR itself on the same branch right?
https://github.com/coronasafe/care_fe/pull/5612#issuecomment-1592550009
Shared a comment on an issue in coronasafe/care_fe on June 15, 2023 at 4:57:00 AM
.bs files are generated files. You need to update the rescript files
https://github.com/coronasafe/care_fe/issues/5088#issuecomment-1592357276
Shared a comment on an issue in coronasafe/care_fe on June 14, 2023 at 5:48:33 PM
Hey @Mustafa-Azad025 @patelaryan7751 As part of replacing Material UI to custom components, the Sample Preview page will almost be fully rewritten very soon this week and your PR may be rendered obsolete. Feel free to take up other issues! cc: @khavinshankar
https://github.com/coronasafe/care_fe/issues/5646#issuecomment-1591732401
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2023 at 9:21:43 AM
Looks like you've made a new PR
https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590825059
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2023 at 9:20:39 AM
You've not made any commits to this branch i guess
https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590822983
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2023 at 3:56:12 AM
With `whitespace-pre-wrap` ![image](https://github.com/coronasafe/care_fe/assets/25143503/2d5e47a2-5d46-4d38-8482-a776ff39933c)
https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590424517
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2023 at 3:32:25 AM
@Mustafa-Azad025 any updates on this?
https://github.com/coronasafe/care_fe/pull/5645#issuecomment-1590404113
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 7:02:15 PM
@SahilSingh177 can you refrain from force pushing?
https://github.com/coronasafe/care_fe/pull/5620#issuecomment-1589867595
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 6:30:10 PM
@rithviknishad to fix cypress
https://github.com/coronasafe/care_fe/pull/5655#issuecomment-1589826117
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 11:57:03 AM
https://github.com/orgs/community/discussions/25937#discussioncomment-3249747
https://github.com/coronasafe/care_fe/pull/5623#issuecomment-1589157276
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 10:47:51 AM
Its a small conflict so you can just use github's editor itself if you want
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1589052616
Shared a comment on a pull request in coronasafe/care_fe on June 13, 2023 at 10:46:33 AM
I do it without rebase. ``` git merge develop git checkout <pr-branch> git merge develop # Resolve conflicts in editor continue merge ```
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1589050514
Shared a comment on a pull request in coronasafe/care_fe on June 12, 2023 at 5:32:50 PM
Also update your PR title to something meaningful.
https://github.com/coronasafe/care_fe/pull/5647#issuecomment-1587766443
Shared a comment on an issue in coronasafe/care_fe on June 9, 2023 at 12:59:16 PM
Yes!
https://github.com/coronasafe/care_fe/issues/5468#issuecomment-1584537993
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2023 at 12:57:44 PM
Also, update the PRs title to be something meaningful like what your PR does. And it's nice to have screenshots too!
https://github.com/coronasafe/care_fe/pull/5640#issuecomment-1584535816
Shared a comment on an issue in coronasafe/care_fe on June 9, 2023 at 11:06:41 AM
@kunal00000 are you working on this or free for others to take it up?
https://github.com/coronasafe/care_fe/issues/5633#issuecomment-1584399159
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2023 at 11:03:34 AM
Other than that everything LGTM, have a look at how `SelectFormField` is used in other places.
https://github.com/coronasafe/care_fe/pull/5623#issuecomment-1584395255
Shared a comment on an issue in coronasafe/care on June 7, 2023 at 4:35:25 PM
I think we can just wrap the `PatientConsultation.objects.get(...)` whichever is causing the issue with `get_object_or_404` right?
https://github.com/coronasafe/care/issues/1348#issuecomment-1581172893
Shared a comment on an issue in coronasafe/care_fe on June 7, 2023 at 1:03:21 PM
@Yash12Bansal kindly fill in the issue comment clearly so that someone would understand when they test or look back into this at a later point in time.
https://github.com/coronasafe/care_fe/issues/5611#issuecomment-1580773848
Shared a comment on a pull request in coronasafe/care_fe on June 5, 2023 at 1:25:45 PM
@nihal467 this is not failing because of his PR
https://github.com/coronasafe/care_fe/pull/5582#issuecomment-1576805181
Shared a comment on an issue in coronasafe/care_fe on June 5, 2023 at 11:25:40 AM
@MayaSatishRao any updates on this?
https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1576611976
Shared a comment on a pull request in coronasafe/care_fe on June 4, 2023 at 11:47:21 PM
@sainak it's already in the OHC domain right? I do see that I've changed it from the diff.
https://github.com/coronasafe/care_fe/pull/5587#issuecomment-1575807325
Shared a comment on an issue in coronasafe/care_fe on June 4, 2023 at 8:10:15 AM
@perminder-17 a PR is already present that fixes this issue as you can clearly see above.
https://github.com/coronasafe/care_fe/issues/5595#issuecomment-1575458653
Shared a comment on a pull request in coronasafe/care on June 3, 2023 at 4:18:36 AM
@yaswanthsaivendra also could you prefix the issue numbers with "Fixes" or other linking keywords?
https://github.com/coronasafe/care/pull/1344#issuecomment-1574629425
Shared a comment on an issue in coronasafe/care on June 2, 2023 at 3:34:53 PM
@satyam0601 you can take up other issues that are not assigned.
https://github.com/coronasafe/care/issues/1334#issuecomment-1573936461
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2023 at 1:45:37 PM
Github is wiered. My local commits are not here
https://github.com/coronasafe/care_fe/pull/5583#issuecomment-1573766146
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2023 at 1:22:50 PM
@JahnabDutta you are expected to update the cypress tests themselves if you think cypress is made for old components.
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573728462
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2023 at 11:50:12 AM
Consider refactoring '--' away. '--' as of now means 'Filter not applied' You may make the filters behaviour / value consistent with other filters like Patient Filters / Asset Filter / Facility Filter.
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573608812
Shared a comment on a pull request in coronasafe/care_fe on June 2, 2023 at 11:47:40 AM
Consider refactoring '--' to be considered as "Filter Not Applied"
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1573606384
Shared a comment on an issue in coronasafe/care on June 2, 2023 at 6:09:19 AM
@gitone912 have u referred to the first comment's link? We already have the front-end changes. You just need to add backend support for the same to function.
https://github.com/coronasafe/care/issues/1327#issuecomment-1573205527
Shared a comment on an issue in coronasafe/care on June 2, 2023 at 5:15:21 AM
@gitone912 This is a backend issue. Currently our backend does not support CSV export for Assets. JSON export is handled in front-end. However, CSV exports are handled in backend. Do not remove JSON support. JSON support is important, CSV support is just a good to have.
https://github.com/coronasafe/care/issues/1327#issuecomment-1573165910
Shared a comment on an issue in coronasafe/care on June 2, 2023 at 4:57:53 AM
Yes! Have a look at patient csv export/import. It should be similar, just that this is in addition to JSON for assets.
https://github.com/coronasafe/care/issues/1327#issuecomment-1573144502
Shared a comment on an issue in coronasafe/care_fe on June 2, 2023 at 4:01:47 AM
@Deepanshu039 any updates?
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1573111782
Shared a comment on an issue in coronasafe/care on June 1, 2023 at 2:40:23 PM
Just adding the stats here of our staging file uploads. ![image](https://github.com/coronasafe/care/assets/25143503/b18dcfd2-8caa-4ab5-a03d-7fcfa7279d8f)
https://github.com/coronasafe/care/issues/1326#issuecomment-1572183682
Shared a comment on an issue in coronasafe/care_fe on June 1, 2023 at 8:39:03 AM
@meeddhhaa some buttons are allowed only for certain user types/role. So we have `RoleButton` component that serves the purpose. However, its a legacy component since it was built in early days to work along with material ui and all. Nowadays we have `ButtonV2` tailwind based component which is widely used. This custom component also supports disabling based on user type, which can be specified with the `authorizedFor` prop. This way we won't need to use seperate components to restrict access, just use the same ButtonV2 component and add authorizedFor=___. This helps in keeping designs consistent and maintaining the codebase in long run.
https://github.com/coronasafe/care_fe/issues/4370#issuecomment-1571608243
Shared a comment on a pull request in coronasafe/care_fe on June 1, 2023 at 8:21:29 AM
See how its implemented in popups like discharge popup
https://github.com/coronasafe/care_fe/pull/5560#issuecomment-1571584945
Shared a comment on an issue in coronasafe/care_fe on May 31, 2023 at 6:23:15 PM
All Legacy components should also be replaced with it's equivalent FormField components
https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570706315
Shared a comment on an issue in coronasafe/care_fe on May 31, 2023 at 6:22:53 PM
You won't have exact word to word component replacement. Checkout how `RadioFormField` is used in other places. You don't need RadioGroup when using that. Same for box and card content, just use divs.
https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570705873
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2023 at 6:04:48 PM
@satyam0601 I'd suggest you to revert the changes in the generic component and instead use classNames to adjust only for the bed select dialog
https://github.com/coronasafe/care_fe/pull/5560#issuecomment-1570680649
Shared a comment on an issue in coronasafe/care_fe on May 31, 2023 at 5:58:30 PM
read the EPIC #5006 all components are already built.
https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570670717
Shared a comment on an issue in coronasafe/care_fe on May 31, 2023 at 5:11:48 PM
u r expected to do all that are applicable.
https://github.com/coronasafe/care_fe/issues/4994#issuecomment-1570607524
Shared a comment on an issue in coronasafe/care on May 31, 2023 at 1:33:05 PM
As you can see, it's already having a PR that fixes this issue.
https://github.com/coronasafe/care/issues/1243#issuecomment-1570246773
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2023 at 12:14:42 PM
Open the filters in the shifting page.
https://github.com/coronasafe/care_fe/pull/5572#issuecomment-1570107112
Shared a comment on an issue in coronasafe/care on May 31, 2023 at 10:31:25 AM
@vigneshhari
https://github.com/coronasafe/care/issues/1321#issuecomment-1569934650
Shared a comment on an issue in coronasafe/care on May 31, 2023 at 8:37:51 AM
All the queries to the DB have to be profiled to better understand how much time it takes.
https://github.com/coronasafe/care/issues/1321#issuecomment-1569748437
Shared a comment on a pull request in coronasafe/care_deploy_configs on May 30, 2023 at 4:38:43 PM
@siddnikh is the PR completed? Title say's you are removing `static_coronasafe_logo` but file changes are only adding the new logos.
https://github.com/coronasafe/care_deploy_configs/pull/16#issuecomment-1568745410
Shared a comment on an issue in coronasafe/care_fe on May 30, 2023 at 12:07:54 PM
@Yash12Bansal All the instructions are specified above ☝🏼
https://github.com/coronasafe/care_fe/issues/5494#issuecomment-1568320752
Shared a comment on an issue in coronasafe/care_fe on May 30, 2023 at 10:51:13 AM
Have you pushed your changes?
https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568217153
Shared a comment on an issue in coronasafe/care_fe on May 30, 2023 at 10:50:49 AM
Why do u think this happens?
https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568216657
Shared a comment on an issue in coronasafe/care_fe on May 30, 2023 at 10:40:09 AM
Have you removed `force:true` from all fields? Keep pushing changes to your draft PR so that we can have a look at it.
https://github.com/coronasafe/care_fe/issues/4233#issuecomment-1568203769
Shared a comment on a pull request in coronasafe/care_fe on May 30, 2023 at 7:36:51 AM
Optional: Have a look at #5563 on how the `Form` component is used to make handling things easier.
https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1567920107
Shared a comment on an issue in coronasafe/care on May 30, 2023 at 5:00:05 AM
Not sure how relevant or required this is. But what comes to my mind at first glance are the following: 1. We could archive it instead maybe? (set `is_archived=True`) 2. Do this only for records with `created_date` older than 1 day? (to avoid running this task over records that are being uploaded at the moment) 3. When we upload a file, is the front end aware that the file upload to S3 has failed? If not, should we support retrying the upload? @gigincg @vigneshhari what do you think about this?
https://github.com/coronasafe/care/issues/1326#issuecomment-1567755774
Shared a comment on an issue in coronasafe/care_fe on May 30, 2023 at 4:40:43 AM
Hey @Basharat908 1. Feel free to take up good first issues linked above ☝🏼 and make PRs for the same to familiarise yourself with the codebase. 2. This itself is the front-end codebase/repo. For the backend, refer the links specified above ☝🏼
https://github.com/coronasafe/care_fe/issues/5492#issuecomment-1567745567
Shared a comment on a pull request in coronasafe/care_fe on May 29, 2023 at 2:34:34 PM
@nikhilagastya all unicons are present in care icons. you just need to prefix `care-l-<icon_name>`. Refer the #5006 to know more about care icons
https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1567218542
Shared a comment on an issue in coronasafe/care_fe on May 29, 2023 at 12:00:09 PM
I've changed the labels to "changes required"
https://github.com/coronasafe/care_fe/issues/4944#issuecomment-1567045176
Shared a comment on an issue in coronasafe/care on May 29, 2023 at 7:32:36 AM
We can't have this validation for camera's as each bed preset creates new AssetBed record. We might also need to restrict editing asset_type once an asset is created so that a Camera asset with multiple beds should never be updated to be a monitor as it shouldn't be linked with multiple bed. cc: @gigincg @vigneshhari
https://github.com/coronasafe/care/issues/1319#issuecomment-1566690234
Shared a comment on an issue in coronasafe/care_fe on May 29, 2023 at 3:27:30 AM
You could do: ```js # utils.ts function getTemperaturePreference() : "C" | "F" { return localStorage.getItem('temperature-preference') ?? "C"; } ``` and then in the component: ```jsx <SelectFormField ... value={getTemperaturePreference()} onChange={({value}) => setTemperaturePreference(value)} /> ```
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1566449782
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 6:18:32 PM
@somesh202 you can modify the handleSubmit to remove the `e.preventDefault` and make it a void function.
https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1566218395
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 2:00:24 PM
Do make the new designs consistent with other designs. (Like make it left aligned too)
https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1566150460
Shared a comment on an issue in coronasafe/care_fe on May 28, 2023 at 12:49:21 PM
Open a patient that has a consultation filed. ![image](https://github.com/coronasafe/care_fe/assets/25143503/75cee634-2088-4748-a64c-ae2040c46672)
https://github.com/coronasafe/care_fe/issues/4947#issuecomment-1566127889
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 12:02:22 PM
```bash git checkout <old-branch-name> git merge <this-branch> git push ``` Also, make sure the files have been changed correctly and that there is no more material ui usage on the entire file. After that, you should update your main comment on that PR to link issues related to this PR too.
https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566113248
Shared a comment on an issue in coronasafe/care_fe on May 28, 2023 at 11:21:12 AM
@bodhish there's a lot of usage of MUI, so we have decided to make an EPIC issue (#5006) to remove file by file. We have already got rid of MUI icons package a while back.
https://github.com/coronasafe/care_fe/issues/4945#issuecomment-1566093814
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 9:52:06 AM
Or you could make these changes in the other PR itself since that already removes some of the mui componennts, and link 2 issues to that PR if you are facing difficulty.
https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566053074
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 9:50:39 AM
The changes from other branch are still present. Feel free to create a new branch and re-open another PR. This can mess up when the other PR and this PR merges.
https://github.com/coronasafe/care_fe/pull/5552#issuecomment-1566052434
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 9:09:06 AM
You could create a fresh new branch and re-open another PR and close this. (Or use revert commits)
https://github.com/coronasafe/care_fe/pull/5551#issuecomment-1566023360
Shared a comment on an issue in coronasafe/care_fe on May 28, 2023 at 4:31:30 AM
You can get started by familiarising with the project with the help of good first issues present in the backend and front end repositories.
https://github.com/coronasafe/care_fe/issues/5493#issuecomment-1565871097
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2023 at 3:52:59 AM
Yes you did mess up your branches ig. You've branched out from your previous PR's branch I assume. When working on a new PR, you can simply do the following: ```bash git checkout develop git pull upstream develop # if you've added upstream remote, you can do this to fetch latest develop so that you always branch from latest develop (or you can simply go to your github repo and fetch latesst changes and do a git pull) git checkout -b "your-new-branch-name" ```
https://github.com/coronasafe/care_fe/pull/5551#issuecomment-1565851360
Shared a comment on an issue in coronasafe/care_fe on May 28, 2023 at 3:48:27 AM
Yes! This looks nice. You can make use of `SelectFormField` component (with `labelClass="hidden" errorClass="hidden") instead to keep designs consistent across the platform. `SelectFormField` also contains an `optionIcon` prop where you could maybe add degree symbol and C/F.
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1565847654
Shared a comment on an issue in coronasafe/care_fe on May 27, 2023 at 3:51:46 PM
@sachdevavaibhav could you replace the following legacy components used in AssetCreate? It indirectly uses MUI. ![image](https://github.com/coronasafe/care_fe/assets/25143503/ca2ca71f-6d90-45ec-9695-682a5c28f95f)
https://github.com/coronasafe/care_fe/issues/4945#issuecomment-1565540045
Shared a comment on a pull request in coronasafe/care_fe on May 27, 2023 at 2:13:22 PM
@somesh202 there is still one more change that's pending. Check previous changes requested about page wrapping only dialog.
https://github.com/coronasafe/care_fe/pull/5545#issuecomment-1565443645
Shared a comment on a pull request in coronasafe/care_fe on May 27, 2023 at 1:37:14 PM
You can message any of us on the slack channel.
https://github.com/coronasafe/care_fe/pull/5544#issuecomment-1565423292
Shared a comment on an issue in coronasafe/care_fe on May 27, 2023 at 12:02:03 PM
@vissuresh this is a front-end issue, there might have been some confusions.
https://github.com/coronasafe/care_fe/issues/5407#issuecomment-1565372122
Shared a comment on an issue in coronasafe/care_fe on May 27, 2023 at 11:40:12 AM
@vissuresh you can find good first issues for backend here: https://github.com/coronasafe/care/issues?q=is%3Aissue+is%3Aopen+no%3Aassignee+label%3A%22good+first+issue%22
https://github.com/coronasafe/care_fe/issues/5492#issuecomment-1565365797
Shared a comment on an issue in coronasafe/care_fe on May 27, 2023 at 4:32:21 AM
Kindly link PRs with issues @nikhilagastya using closing keywords: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
https://github.com/coronasafe/care_fe/issues/3957#issuecomment-1565202696
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 5:15:50 PM
Nice!
https://github.com/coronasafe/care_fe/pull/5528#issuecomment-1564692259
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 12:09:32 PM
No worries @Deepanshu039 😄 Had to push this out since today is production release day.
https://github.com/coronasafe/care_fe/pull/5509#issuecomment-1564296882
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 11:41:30 AM
fixed properly in #5541
https://github.com/coronasafe/care_fe/pull/5509#issuecomment-1564263510
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 11:24:54 AM
@MayaSatishRao but even the expected behaviour is not working. Either one should work. Also, you don't need to setup the backend to run the front-end. By default, it'll use the staging backend.
https://github.com/coronasafe/care_fe/pull/5528#issuecomment-1564246022
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 9:37:01 AM
@Deepanshu039 any updates on this?
https://github.com/coronasafe/care_fe/pull/5509#issuecomment-1564107117
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 9:11:35 AM
A proper solution has already been implemented in https://github.com/coronasafe/care_fe/pull/5534 by making use of the close prop that headless ui provides.
https://github.com/coronasafe/care_fe/pull/5531#issuecomment-1564072426
Shared a comment on an issue in coronasafe/care on May 26, 2023 at 9:06:07 AM
Hey @JahnabDutta Yes, both the backend and front end needs to be updated to include the `None` filter option. About the backend, appending a new choice to `BedTypeChoices` may not be the right solution as `None` is not a valid bed type. Say you have a bed, its type will never be None. However, what we need to achieve is, to check whether a Patient's Last Consultation's Current Bed is None/null or not. cc: @vigneshhari
https://github.com/coronasafe/care/issues/1184#issuecomment-1564063981
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 8:58:44 AM
You can look into other good first issues meanwhile
https://github.com/coronasafe/care_fe/pull/5534#issuecomment-1564054120
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 8:57:57 AM
Hey @sachdevavaibhav @nihal467 is the QA and handles all of the testings of CARE. We just add the need testing label once a PR is ready to be tested to check for bugs/responsiveness issues and all. He'll test and either mark it as test failed with the reason or mark it as tested. Once tested it'll be reviewed and merged by @khavinshankar mostly.
https://github.com/coronasafe/care_fe/pull/5534#issuecomment-1564053120
Shared a comment on an issue in coronasafe/care_fe on May 26, 2023 at 8:36:39 AM
We tweaked and tried lots of designs during the calls. 😅 We could discuss this, can you share this in our Slack channel in care general so that we can get everyone's suggestions?
https://github.com/coronasafe/care_fe/issues/5533#issuecomment-1564018111
Shared a comment on an issue in coronasafe/care_fe on May 26, 2023 at 8:07:39 AM
Alright, feel free to let us know if you are facing difficulty figuring out something, or maybe you can use the care general slack channel.
https://github.com/coronasafe/care_fe/issues/5410#issuecomment-1563982988
Shared a comment on an issue in coronasafe/care_fe on May 26, 2023 at 8:06:27 AM
We could add a tooltip maybe saying: `Live Patients / Total beds`?
https://github.com/coronasafe/care_fe/issues/5533#issuecomment-1563981004
Shared a comment on an issue in coronasafe/care_fe on May 26, 2023 at 8:05:33 AM
Hey @Bhavik-ag this is not a bug and is expected behaviour. After discussions, it was decided to show live patients / total bed count. Not occupied beds / total beds. cc: @nihal467 @aparnacoronasafe
https://github.com/coronasafe/care_fe/issues/5533#issuecomment-1563978370
Shared a comment on a pull request in coronasafe/care_fe on May 26, 2023 at 5:45:14 AM
The issue is not about `DateRangeFormField`. The issue is about `DateFormField`. So start and the end has no context here. Try to select a date from date picker present in the issue screenshot. After selecting it closes correctly. However I'm unable to re-open it to change the date on first click.
https://github.com/coronasafe/care_fe/pull/5531#issuecomment-1563839816
Shared a comment on an issue in coronasafe/care_fe on May 26, 2023 at 5:39:55 AM
I've requested changes as it brings in additional problems.
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1563836728
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 7:55:26 PM
sure, you may create a PR and link this issue to it.
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1563431705
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 7:53:59 PM
@nikhilagastya sub issues for the same have been created. you may take up those.
https://github.com/coronasafe/care_fe/issues/5006#issuecomment-1563430204
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 7:47:03 PM
yes
https://github.com/coronasafe/care_fe/issues/3957#issuecomment-1563423456
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 1:11:42 PM
Sure!
https://github.com/coronasafe/care_fe/issues/5483#issuecomment-1562885258
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 12:57:34 PM
@MayaSatishRao I've reviewed it. All PRs will be tested by @nihal467
https://github.com/coronasafe/care_fe/issues/5524#issuecomment-1562862431
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 12:24:53 PM
Yes, i'll review it
https://github.com/coronasafe/care_fe/issues/5524#issuecomment-1562816671
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 12:19:43 PM
It's best if you could do it in WSL
https://github.com/coronasafe/care_fe/issues/5515#issuecomment-1562809993
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 12:14:22 PM
@Prajuwal feel free to pick up other good first issues as this is already picked up 😄 We have a mountain of good first issues available in the front-end https://github.com/coronasafe/care_fe/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee
https://github.com/coronasafe/care_fe/issues/5524#issuecomment-1562802361
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 11:56:44 AM
Did you run `npm install --legacy-peer-deps` before that?
https://github.com/coronasafe/care_fe/issues/5515#issuecomment-1562775516
Shared a comment on a pull request in coronasafe/care on May 25, 2023 at 11:51:33 AM
@nihal467 would be doing a full test on this post this weeks release
https://github.com/coronasafe/care/pull/1288#issuecomment-1562769490
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 11:45:25 AM
Refer: https://github.com/coronasafe/care_fe/issues/5515
https://github.com/coronasafe/care_fe/issues/5524#issuecomment-1562760818
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 9:34:14 AM
Hey @JahnabDutta Feel free to take up good first issues to get yourself familiarised with the project codebase
https://github.com/coronasafe/care_fe/issues/5494#issuecomment-1562591807
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 9:30:27 AM
@GokulramGHV any updates on this?
https://github.com/coronasafe/care_fe/issues/5441#issuecomment-1562586609
Shared a comment on an issue in coronasafe/care_fe on May 25, 2023 at 3:10:04 AM
I'm not sure if it's because your working directory path has spaces in it. I don't have a windows machine to test it. Could you retry in a working directory without spaces in the path? @skks1212 any idea?
https://github.com/coronasafe/care_fe/issues/5515#issuecomment-1562195713
Shared a comment on a pull request in coronasafe/care_fe on May 24, 2023 at 3:01:43 PM
Not all forms, only for `AutocompleteFormField` and it's multi select equivalent. Have a look at `FormField` components.
https://github.com/coronasafe/care_fe/pull/5509#issuecomment-1561326946
Shared a comment on an issue in coronasafe/care_fe on May 24, 2023 at 11:48:15 AM
Okay, I was thinking of having this as a starting point of something like Device Preferences, where we could store not just Temperature Unit, but things like applied filters of Central Nursing Station, and so on.
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1560971899
Shared a comment on an issue in coronasafe/care_fe on May 24, 2023 at 11:44:32 AM
Hey, it would be nice if you could link the issues in your PR using the closing keywords 😃 https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
https://github.com/coronasafe/care_fe/issues/5506#issuecomment-1560967014
Shared a comment on an issue in coronasafe/care on May 24, 2023 at 11:37:50 AM
An EPIC issue has been filed: https://github.com/coronasafe/care_fe/issues/5492
https://github.com/coronasafe/care/issues/489#issuecomment-1560958535
Shared a comment on an issue in coronasafe/care_fe on May 24, 2023 at 8:26:02 AM
Can you explain how you are going to achieve it?
https://github.com/coronasafe/care_fe/issues/5463#issuecomment-1560672521
Shared a comment on an issue in coronasafe/care_fe on May 24, 2023 at 6:54:01 AM
Awesome!
https://github.com/coronasafe/care_fe/issues/5478#issuecomment-1560550651
Shared a comment on a pull request in coronasafe/care_fe on May 23, 2023 at 5:31:53 AM
@Bhavik-ag have a look at the JSON files inside `src/Locale/en` directory
https://github.com/coronasafe/care_fe/pull/5499#issuecomment-1558552300
Shared a comment on an issue in coronasafe/care_fe on May 23, 2023 at 2:49:51 AM
@knight-95 this issue already has a PR linked to it. Kindly look into if it's already solved or not when picking up issues. Feel free to pick up other good first issues.
https://github.com/coronasafe/care_fe/issues/5485#issuecomment-1558423357
Shared a comment on an issue in coronasafe/care on May 21, 2023 at 12:01:21 PM
@skks1212 is this relevant anymore? Since we are no longer doing medicines in daily rounds. Can we close this?
https://github.com/coronasafe/care/issues/1032#issuecomment-1556161766
Shared a comment on a pull request in coronasafe/care_fe on May 21, 2023 at 4:46:08 AM
@dependabot rebase
https://github.com/coronasafe/care_fe/pull/5448#issuecomment-1556081920
Shared a comment on an issue in coronasafe/care_fe on May 21, 2023 at 4:42:23 AM
Hey @devanshkaushik So if you take a look at our backend, you can see that all the serializers are present at: `care/<module_name>/api/serializers/<model_name>.py` (for example, see `facility` module: https://github.com/coronasafe/care/tree/master/care/facility/api/serializers). I've updated the original issue comment to track all the sub-tasks. Each file specified in the task contains one or more serializers that inherit `ModelSerializer`, which has to be split to separate `<ModelName>ListSerializer` and `<ModelName>DetailSerializer` so as to minimize joins. Each of these specific serializers should serialize information that is required by/used in the front end. You may have a look at our front end and understand which all fields are required, and keep only those information in the List Serializer. DetailSerializer can inherit the list serializer and include all other information.
https://github.com/coronasafe/care_fe/issues/5492#issuecomment-1556081450
Shared a comment on an issue in coronasafe/care_fe on May 21, 2023 at 3:57:43 AM
If you are facing any difficulties figuring out, drop a comment
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1556076082
Shared a comment on an issue in coronasafe/care_fe on May 21, 2023 at 3:56:20 AM
@naksh2004 feel free to make a PR and link this issue to it. 🚀
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1556075932
Shared a comment on an issue in coronasafe/care_fe on May 20, 2023 at 8:27:33 AM
@patelaryan7751 any updates on this?
https://github.com/coronasafe/care_fe/issues/5332#issuecomment-1555861973
Shared a comment on a pull request in coronasafe/care_fe on May 20, 2023 at 8:21:06 AM
Re-worked in #5458
https://github.com/coronasafe/care_fe/pull/5317#issuecomment-1555860896
Shared a comment on an issue in coronasafe/care_fe on May 18, 2023 at 3:12:23 PM
@souravghosh01 are you facing blockers creating a PR?
https://github.com/coronasafe/care_fe/issues/5471#issuecomment-1553212816
Shared a comment on an issue in coronasafe/care_fe on May 18, 2023 at 5:39:53 AM
Closing as not reproducible. It was reproducible a while back. Strange.
https://github.com/coronasafe/care_fe/issues/5472#issuecomment-1552437045
Shared a comment on a pull request in coronasafe/care on May 13, 2023 at 11:39:04 AM
@sainak unable to download discharge summary. Am I missing some setup's to be done locally? ![image](https://github.com/coronasafe/care/assets/25143503/7cdc417f-4e8a-4f99-aca2-b43e1094a6d8) cc: @nihal467
https://github.com/coronasafe/care/pull/1252#issuecomment-1546628915
Shared a comment on an issue in coronasafe/care_fe on May 13, 2023 at 9:00:56 AM
https://github.com/coronasafe/care_fe/pull/5458
https://github.com/coronasafe/care_fe/issues/5380#issuecomment-1546601705
Shared a comment on a pull request in coronasafe/care_fe on May 12, 2023 at 6:03:02 AM
### Date Migration Test #### Before Migration: Last updated: `11:29 AM; 12/05/2023` ![image](https://github.com/coronasafe/care_fe/assets/25143503/3e4ae080-7711-4895-a481-edb0661c9b21) #### Migrations run on: `11:30 AM; 12/05/2023` ![image](https://github.com/coronasafe/care_fe/assets/25143503/f2dae1c1-1b5a-4afa-b3be-4c5289d6c285)
https://github.com/coronasafe/care_fe/pull/5458#issuecomment-1545216537
Shared a comment on a pull request in coronasafe/care_fe on May 12, 2023 at 4:24:37 AM
@siddnikh is this good for testing? mark with need testing label if so.
https://github.com/coronasafe/care_fe/pull/5413#issuecomment-1545090033
Shared a comment on a pull request in coronasafe/care_fe on May 11, 2023 at 4:13:00 PM
### Post migrations (after resolving all migration issues) #### Patient that's not discharged ![image](https://github.com/coronasafe/care_fe/assets/25143503/631db405-91b4-43ec-9ff7-296d3482cf2c) #### Patient that's discharged ![image](https://github.com/coronasafe/care_fe/assets/25143503/4465c552-fd6c-4c17-8fc1-fcc66ab48cb2) ### Observations - We loose the original last updated/created time data and the values would be the time at which migration was performed since `Prescription` records are created during the migration. -
https://github.com/coronasafe/care_fe/pull/5458#issuecomment-1544282462
Shared a comment on a pull request in coronasafe/care_fe on May 11, 2023 at 12:03:15 PM
(draft) ## Before Migrations (with `master` BE, `develop` FE; Added prescription, prn prescription, critical care medicine) ### Patient that's not discharged ![image](https://github.com/coronasafe/care_fe/assets/25143503/7ebae26e-8181-4f89-a974-e84e9dbfc15a) ### To be discharged patient ![image](https://github.com/coronasafe/care_fe/assets/25143503/cb6760e7-a259-40a8-a9f3-0304288e7b10) ![image](https://github.com/coronasafe/care_fe/assets/25143503/a09572c6-5a7c-4c9b-b802-5b78323eed16)
https://github.com/coronasafe/care_fe/pull/5458#issuecomment-1543872676
Shared a comment on a pull request in coronasafe/care on May 10, 2023 at 2:56:58 PM
@vigneshhari @sainak just a cautionary reminder/note: Upon merging #1247 the `dischare_prescriptions` and `discharge_prn_prescriptions` are no longer JSON fields but a separate Model.
https://github.com/coronasafe/care/pull/1252#issuecomment-1542355896
Shared a comment on an issue in coronasafe/care_fe on April 25, 2023 at 6:45:07 AM
So far (as per the latest develop), the field was not hidden based on any configurations.
https://github.com/coronasafe/care_fe/issues/5384#issuecomment-1521236448
Shared a comment on an issue in coronasafe/care_fe on April 25, 2023 at 6:42:36 AM
I'll also update it such that, the field is hidden when kasp is not enabled, instead of being dependent on wartime config.
https://github.com/coronasafe/care_fe/issues/5384#issuecomment-1521234165
Shared a comment on an issue in coronasafe/care_fe on April 24, 2023 at 7:01:48 PM
@aparnacoronasafe I've updated the PR to include the field only when wartime is set
https://github.com/coronasafe/care_fe/issues/5384#issuecomment-1520675170
Shared a comment on a pull request in coronasafe/care_fe on April 21, 2023 at 3:02:37 PM
Closing as you've continued in #5362
https://github.com/coronasafe/care_fe/pull/5328#issuecomment-1517968019
Shared a comment on a pull request in coronasafe/care_fe on April 19, 2023 at 4:26:22 PM
@patelaryan7751 I'm not sure if you understood it, let me rephrase. The current filter state is stored in the URL's query params right? Which is a `Record<key, value>` where value is a string or a ref. ID as string, right? The parent component (eg. `AssetsList`) is getting the query params `useFilters` and all ref. ID-based filters are being resolved to appropriate objects by the parent component itself right? So before even you reach the AssetsFilter (Slideover) component, you already have a Record<key: FilterName, value: string | ResolvedObject> right? Passing this to the slide-over should simply work right? Now for the clearFilter, the behaviour is pretty simple and straightforward across all filters. It just needs to navigate to the URL without query params. Updating the state need not be done since the qParams automatically will be updated since URL has changed, hence relevant parts will be re-rendered and states get updated. (I'm not sure if I'm missing something you are trying to convey, correct me if I'm wrong)
https://github.com/coronasafe/care_fe/pull/5328#issuecomment-1515031341
Shared a comment on a pull request in coronasafe/care on April 17, 2023 at 4:23:06 PM
@vigneshhari those are flake8 lints. it'll require manually modifying the code. There's like 150 such modifications required :) ![image](https://user-images.githubusercontent.com/25143503/232549241-bd3b0d25-c03d-4707-ac34-4e1ffdf39ee6.png)
https://github.com/coronasafe/care/pull/1258#issuecomment-1511697155
Shared a comment on an issue in coronasafe/care_fe on April 17, 2023 at 6:49:37 AM
Unassigning myself since I'll mostly not be available this week.
https://github.com/coronasafe/care_fe/issues/5342#issuecomment-1510795593
Shared a comment on an issue in coronasafe/care_fe on April 16, 2023 at 12:59:06 PM
@k-deepak04 sure!
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1510375050
Shared a comment on an issue in coronasafe/ayushma on April 15, 2023 at 6:19:04 AM
Even though the packages are present in `requirements/local.txt` it seems to not work unless `pip install <the-above-two-packages>` are done. However, doing that it logs `Requirements already satisfied`. @Ashesh3 also can confirm replicate behaviour
https://github.com/coronasafe/ayushma/issues/40#issuecomment-1509571899
Shared a comment on an issue in coronasafe/care_fe on April 13, 2023 at 2:34:35 PM
@aparnacoronasafe regd. first one, renaming "Date of consultation" could you confirm if it's "Date of first consultation" or "Date of last consultation"? All the other details currently are of last consultation's.
https://github.com/coronasafe/care_fe/issues/5309#issuecomment-1507080768
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 5:44:49 PM
@aparnacoronasafe this behaviour is conflicting with the recently created issue #5296 where it's behaviour is to open of create shift request form. Could you confirm which behaviour is expected?
https://github.com/coronasafe/care_fe/issues/5314#issuecomment-1502105627
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 3:11:01 PM
Issue seems to be different. All of the in-app usages of REACT_PUBLIC_URL is to access static assets of public dir. Replacing it with relative URL should do
https://github.com/coronasafe/care_fe/issues/5303#issuecomment-1501936737
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 2:46:34 PM
Currently, we do not store enough attributes/information about ICD11 Diagnoses in the ICD11 in-memory database. Possible solutions is to use [ICD API](https://icd.who.int/icdapi) (see [Swagger Docs](https://id.who.int/swagger/index.html)) It may break things since we are not aware if they might make changes in the ICD v11 API itself or not. A possible workaround for this issue could be to use ICD API to query, extract the entries out, match them with the ICD11 entries present in our backend, and give that response.
https://github.com/coronasafe/care_fe/issues/5293#issuecomment-1501905407
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 2:41:02 PM
Duplicate of #4876
https://github.com/coronasafe/care_fe/issues/5295#issuecomment-1501899761
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 12:57:51 PM
@Ashesh3 maybe we should have separate input fields for it so that user is clear about this feature. (Although we could make use of the same backend field)
https://github.com/coronasafe/care_fe/issues/5295#issuecomment-1501783213
Shared a comment on an issue in coronasafe/care_fe on April 10, 2023 at 9:33:21 AM
@pamnanaimanish169 this issue already has a PR (#5290) linked to it. Feel free to checkout other good first issues here: https://github.com/coronasafe/care_fe/contribute
https://github.com/coronasafe/care_fe/issues/5284#issuecomment-1501607262
Shared a comment on a pull request in coronasafe/care_fe on April 9, 2023 at 5:23:50 PM
Closing as continued in #5290
https://github.com/coronasafe/care_fe/pull/5289#issuecomment-1501175284
Shared a comment on an issue in coronasafe/care_fe on April 9, 2023 at 5:05:27 PM
sure @rahulnpadalkar 🚀
https://github.com/coronasafe/care_fe/issues/5280#issuecomment-1501171730
Shared a comment on an issue in coronasafe/care_fe on April 9, 2023 at 5:03:37 PM
@AbhishekPSingh07 link pull requests to issues using keywords. Learn more here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
https://github.com/coronasafe/care_fe/issues/5284#issuecomment-1501171284
Shared a comment on an issue in coronasafe/care_fe on April 9, 2023 at 9:30:27 AM
@jobayer12 feel free to take up other issues 😄 https://github.com/coronasafe/care_fe/contribute
https://github.com/coronasafe/care_fe/issues/5279#issuecomment-1501086172
Shared a comment on an issue in coronasafe/care_fe on April 9, 2023 at 7:07:12 AM
@jobayer12 no worries. it might have been difficult to figure out since it was in a rescript file. i've pushed the fix https://github.com/coronasafe/care_fe/blob/develop/src/Components/CriticalCareRecording/types/CriticalCare__VentilatorParameters.res#L116
https://github.com/coronasafe/care_fe/issues/5279#issuecomment-1501059089
Shared a comment on an issue in coronasafe/care_fe on April 9, 2023 at 6:30:55 AM
@jobayer12 Step 1: Create a log update ![image](https://user-images.githubusercontent.com/25143503/230758075-462e72bb-1a07-45e9-a863-1320c88eb721.png) Step 2: Create a critical care log update ![image](https://user-images.githubusercontent.com/25143503/230758093-b6c2900c-62eb-4fdf-bce4-e08c5f8cce91.png) Step 3: Open Respiratory Support Step 4: Select None and Update the details Step 5: Complete and select view details of the latest log update ![image](https://user-images.githubusercontent.com/25143503/230758147-36cf3620-f994-4b3a-89f7-a7732f1a11ff.png) Notice the respiratory support interface attribute is Unknown instead of None. https://care.coronasafe.in/facility/2bfdbbe6-0516-4269-9d17-860efd705ffb/patient/9db8dc7c-bd06-44fc-a6e0-7d7d148a1ac1/consultation/8eeb2ba4-41b2-4c20-8f4d-3f605b33d421/daily_rounds/c3fb70ce-92fa-4270-937d-4ca1f85b804c ![image](https://user-images.githubusercontent.com/25143503/230758179-5ee4422f-25dd-460f-b726-a1872cbf1d46.png)
https://github.com/coronasafe/care_fe/issues/5279#issuecomment-1501053690
Shared a comment on an issue in coronasafe/care_fe on April 6, 2023 at 3:57:16 PM
https://docs.github.com/en/get-started/quickstart/contributing-to-projects
https://github.com/coronasafe/care_fe/issues/5232#issuecomment-1499289953
Shared a comment on an issue in coronasafe/care_fe on April 6, 2023 at 3:55:46 PM
@pranit-yawalkar have you tried cloning and running `npm install` before `npm run dev`?
https://github.com/coronasafe/care_fe/issues/5236#issuecomment-1499288223
Shared a comment on an issue in coronasafe/care_fe on April 6, 2023 at 3:51:48 PM
@CouldBeFree you may create a branch in your fork, and raise a PR to this repo's develop branch.
https://github.com/coronasafe/care_fe/issues/5232#issuecomment-1499282610
Shared a comment on a pull request in coronasafe/care_fe on April 6, 2023 at 10:11:30 AM
@Ashesh3 no idea at present. A bit occupied till tomorrow to try to replicate this locally.
https://github.com/coronasafe/care_fe/pull/5249#issuecomment-1498815590
Shared a comment on an issue in coronasafe/care_fe on April 6, 2023 at 7:54:57 AM
Yes @CouldBeFree If the session is not expired and if user manually enters such a route, how about we redirect them back to the previous valid route if any is present in the history stack (checkout `useAppHistory` custom hook). If no history is present we may route them to `/` which will redirect them to `/facility` automatically.
https://github.com/coronasafe/care_fe/issues/5232#issuecomment-1498640996
Shared a comment on a pull request in coronasafe/care_fe on April 6, 2023 at 6:05:32 AM
@Ashesh3 https://github.com/coronasafe/care_fe/pull/5204
https://github.com/coronasafe/care_fe/pull/5249#issuecomment-1498538830
Shared a comment on an issue in coronasafe/care_fe on April 5, 2023 at 10:51:22 AM
![image](https://user-images.githubusercontent.com/25143503/230059554-e154b777-09d8-4dbf-8ea7-1c177b9b640b.png) https://github.com/coronasafe/care_fe/commit/9115f9066f5cc08b26f17e50fe00a56a6a6c6a1d cc: @Ashesh3
https://github.com/coronasafe/care_fe/issues/5241#issuecomment-1497289334
Shared a comment on a pull request in coronasafe/care_fe on April 5, 2023 at 4:28:36 AM
@khavinshankar done
https://github.com/coronasafe/care_fe/pull/5158#issuecomment-1496901506
Shared a comment on an issue in coronasafe/care_fe on April 4, 2023 at 6:20:16 AM
@ayushjnv1 if the work is not yet completed and you are willing to complete it, you may create a draft PR and link this issue to it. Unassigned to prevent this issue from being blocked. Feel free to ping if you are facing any blockers.
https://github.com/coronasafe/care_fe/issues/5000#issuecomment-1495412666
Shared a comment on an issue in coronasafe/care_fe on April 3, 2023 at 2:45:41 PM
ack
https://github.com/coronasafe/care_fe/issues/5226#issuecomment-1494461591
Shared a comment on an issue in coronasafe/care_fe on April 3, 2023 at 1:31:07 PM
@Ashesh3
https://github.com/coronasafe/care_fe/issues/5196#issuecomment-1494330916
Shared a comment on an issue in coronasafe/care_fe on April 1, 2023 at 9:38:58 AM
fixed via #5129
https://github.com/coronasafe/care_fe/issues/5119#issuecomment-1492894288
Shared a comment on a pull request in coronasafe/care_fe on March 27, 2023 at 10:12:33 AM
@ayushjnv1 if you could merge the latest develop branch now, you'll be able to see all the old components have been renamed to `Legacy<ComponentName>` so that it's easier to track which needs to be migrated.
https://github.com/coronasafe/care_fe/pull/5136#issuecomment-1484874202
Shared a comment on a pull request in coronasafe/care_fe on March 24, 2023 at 3:52:01 AM
@skks1212 yes, let's do it as separate PR. Didn't want to make it difficult to test and review. I've only migrated the labels momentarily to keep the gaps between each field consistent. #5006 tracks all migrations necessary for this
https://github.com/coronasafe/care_fe/pull/5158#issuecomment-1482210947
Shared a comment on an issue in coronasafe/care_fe on March 21, 2023 at 5:56:48 AM
Ack
https://github.com/coronasafe/care_fe/issues/5137#issuecomment-1477322045
Shared a comment on a pull request in coronasafe/care_fe on March 21, 2023 at 5:19:58 AM
@ayushjnv1 1. just a minor fix, in the issue it was mentioned to remove the current health and medication fields. Would be nice if extra care is taken next time. Other than everything LGTM :) 2. [Link PRs with issues using keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword). This helps in automatically closing the issue as completed when PR is merged. cc: @nihal467
https://github.com/coronasafe/care_fe/pull/5133#issuecomment-1477299219
Shared a comment on an issue in coronasafe/care_fe on March 21, 2023 at 3:23:56 AM
@ayushjnv1 are you sure? This will require changes in the backend to be made too.
https://github.com/coronasafe/care_fe/issues/3924#issuecomment-1477230114
Shared a comment on an issue in coronasafe/care_fe on March 20, 2023 at 3:16:21 PM
@ayushjnv1 you may skip the review after and action for now. @nihal467 this was discussed with Gigin.
https://github.com/coronasafe/care_fe/issues/5074#issuecomment-1476421934
Shared a comment on an issue in coronasafe/care_fe on March 20, 2023 at 12:21:41 PM
@ayushjnv1 checkout the API docs at https://careapi.coronasafe.in/swagger/ . action is present in GET response. ![image](https://user-images.githubusercontent.com/25143503/226337482-238e26ef-f106-47da-a765-2ef20a24ed29.png)
https://github.com/coronasafe/care_fe/issues/5074#issuecomment-1476129619
Shared a comment on an issue in coronasafe/care_fe on March 20, 2023 at 11:40:03 AM
UI: yes, fine for now as it's similar to adjacent attributes. Diastolic has only one `l`.
https://github.com/coronasafe/care_fe/issues/5074#issuecomment-1476072016
Shared a comment on an issue in coronasafe/care_fe on March 18, 2023 at 11:35:47 AM
@Pranshu1902 duplicate of #4959 make use of tasks in #5006 epic to migrate MUI components
https://github.com/coronasafe/care_fe/issues/5128#issuecomment-1474820231
Shared a comment on a pull request in coronasafe/care_fe on March 18, 2023 at 5:42:55 AM
@rjhaveri1991 yes! affirmative.
https://github.com/coronasafe/care_fe/pull/5125#issuecomment-1474730900
Shared a comment on a pull request in coronasafe/care_fe on March 13, 2023 at 11:08:41 AM
We could take this up as a separate issue ![image](https://user-images.githubusercontent.com/25143503/224684708-b45958f6-0204-456e-a23f-eb744bf55e89.png)
https://github.com/coronasafe/care_fe/pull/3799#issuecomment-1465939740
Shared a comment on a pull request in coronasafe/care_fe on March 13, 2023 at 8:48:59 AM
@khavinshankar
https://github.com/coronasafe/care_fe/pull/5062#issuecomment-1465731288
Shared a comment on an issue in coronasafe/care_fe on March 12, 2023 at 12:21:36 PM
I'd do direct since not all fields are related to vitals. @nihal467 what do you think about this?
https://github.com/coronasafe/care_fe/issues/5074#issuecomment-1465181992
Shared a comment on a pull request in coronasafe/care_fe on March 12, 2023 at 11:26:56 AM
@Pranshu1902 I agree. @GokulramGHV make use of Submit button with label=Reset for consistency
https://github.com/coronasafe/care_fe/pull/5063#issuecomment-1465167641
Shared a comment on an issue in coronasafe/care_fe on March 11, 2023 at 2:17:42 PM
Hey @ayushjnv1 feel free to make a PR :) However, since this is a P2 priority, **we expect a PR within 7 days**. Feel free to ask questions if you hit any blockers. We may unassign this issue from you if there is no activity for more than 7 days on this issue.
https://github.com/coronasafe/care_fe/issues/5074#issuecomment-1464921470
Shared a comment on a pull request in coronasafe/care_fe on March 11, 2023 at 11:38:43 AM
Why would you want to pass a requiredError separately when you can derive whether it's a required field and it has an error or not?
https://github.com/coronasafe/care_fe/pull/5089#issuecomment-1464892356
Shared a comment on an issue in coronasafe/care_fe on March 10, 2023 at 11:19:07 AM
Ack
https://github.com/coronasafe/care_fe/issues/5080#issuecomment-1463659069
Shared a comment on an issue in coronasafe/care_fe on March 8, 2023 at 12:52:12 PM
@ayushjnv1 have a look at [Linking a PR to an issue using keyword](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) :) This way when the PR is merged, the issue gets closed automatically and there are other benefits too.
https://github.com/coronasafe/care_fe/issues/5049#issuecomment-1460107599
Shared a comment on a pull request in coronasafe/care_fe on March 8, 2023 at 11:22:37 AM
@khavinshankar
https://github.com/coronasafe/care_fe/pull/5066#issuecomment-1460013995
Shared a comment on a pull request in coronasafe/care_fe on March 8, 2023 at 8:23:09 AM
@cp-Coder could you clear the merge conflicts?
https://github.com/coronasafe/care_fe/pull/3799#issuecomment-1459711927
Shared a comment on an issue in coronasafe/care_fe on March 8, 2023 at 6:55:08 AM
@ayushjnv1 `map-marker` is fine. As long as the alternative icon's intention/meaning conveyed to the user is the same, it should be fine.
https://github.com/coronasafe/care_fe/issues/5049#issuecomment-1459630390
Shared a comment on a pull request in coronasafe/care_fe on March 7, 2023 at 4:08:56 PM
@nihal467 fixed ![image](https://user-images.githubusercontent.com/25143503/223479590-6e7ebe7b-762b-458b-b746-a5ec50d40da1.png)
https://github.com/coronasafe/care_fe/pull/4726#issuecomment-1458432885
Shared a comment on a pull request in coronasafe/care_fe on March 7, 2023 at 11:39:52 AM
@nihal467 @khavinshankar ready
https://github.com/coronasafe/care_fe/pull/4726#issuecomment-1458018766
Shared a comment on an issue in coronasafe/care_fe on March 7, 2023 at 3:51:59 AM
@ayushjnv1 You may use [unicons library](https://iconscout.com/unicons/explore/line) to browse icons. Suppose you want to use an unicon line icon: `analysis`, you may achieve it with `CareIcons` like: `<CareIcon className="care-l-analysis text-lg" />` For more refer: https://github.com/coronasafe/care_fe/pull/4071
https://github.com/coronasafe/care_fe/issues/5049#issuecomment-1457478552
Shared a comment on a pull request in coronasafe/care_fe on March 6, 2023 at 6:33:30 AM
@jeromtom I agree with that. cc: @aparnacoronasafe
https://github.com/coronasafe/care_fe/pull/5034#issuecomment-1455533689
Shared a comment on an issue in coronasafe/care_fe on March 3, 2023 at 7:11:08 AM
@gigincg closing this in favour of #5033
https://github.com/coronasafe/care_fe/issues/4588#issuecomment-1453079675
Shared a comment on a pull request in coronasafe/care_fe on March 2, 2023 at 4:10:28 PM
@siva-balan the Material UI's `Card` component can be replaced with a `div` if `Card` is causing the clipping. You may remove these if so: ![image](https://user-images.githubusercontent.com/25143503/222484858-5d4fd20c-1e16-49c0-a590-264da59a4c3d.png)
https://github.com/coronasafe/care_fe/pull/4882#issuecomment-1452130272
Shared a comment on a pull request in coronasafe/care_fe on March 2, 2023 at 2:19:59 PM
@siva-balan this is probably because the parent container has `overflow-clip` class.
https://github.com/coronasafe/care_fe/pull/4882#issuecomment-1451942868
Shared a comment on a pull request in coronasafe/care_fe on March 2, 2023 at 12:44:41 PM
@siva-balan once there are no more legacy input fields that's using `handleChange`, you may remove that old `handleChange` altogether.
https://github.com/coronasafe/care_fe/pull/4882#issuecomment-1451811715
Shared a comment on a pull request in coronasafe/care_fe on March 2, 2023 at 12:43:47 PM
@siva-balan I'm guessing that you are using `handleChange` which is for old components and wouldn't work with `FormField` components. For `FormField` components you shall use `handleFormFieldChange`.
https://github.com/coronasafe/care_fe/pull/4882#issuecomment-1451810762
Shared a comment on a pull request in coronasafe/care_fe on March 2, 2023 at 12:26:53 PM
Hey @siva-balan 👋🏼 sure, happy to help you out. Have a look at [`src/Components/Users/UserAdd.tsx`](https://github.com/coronasafe/care_fe/blob/develop/src/Components/Users/UserAdd.tsx#L887-L921) where similar State and District select menus were implemented using `SelectFormField`. Let me know if you are still facing issues after looking at this. ![image](https://user-images.githubusercontent.com/25143503/222427990-b0f20dac-2d83-4ed1-af7a-b4ce037795c0.png)
https://github.com/coronasafe/care_fe/pull/4882#issuecomment-1451788292
Shared a comment on an issue in coronasafe/care_fe on March 2, 2023 at 4:18:07 AM
Started working on it from yesterday
https://github.com/coronasafe/care_fe/issues/4067#issuecomment-1451278023
Shared a comment on an issue in coronasafe/care_fe on March 1, 2023 at 12:11:36 PM
Snatching this issue away since it was already solved in an active PR #4726 before raising this issue
https://github.com/coronasafe/care_fe/issues/4963#issuecomment-1450041661
Shared a comment on an issue in coronasafe/care_fe on February 28, 2023 at 8:32:23 AM
@kaushikc44 It would be nice to have all the tasks completed **if applicable**. Feel free to comment if you are facing issues performing them.
https://github.com/coronasafe/care_fe/issues/4928#issuecomment-1447771529
Shared a comment on an issue in coronasafe/care_fe on February 28, 2023 at 7:48:56 AM
Hi @kaushikc44 👋🏼 Have you made a branch in your care_fe fork repo and attempted to make a pull request?
https://github.com/coronasafe/care_fe/issues/4929#issuecomment-1447722592
Shared a comment on an issue in coronasafe/care_fe on February 28, 2023 at 7:40:31 AM
Hi @kaushikc44, no worries. Issue was auto-generated, that's why it's mentioned "if any" for page title migration. 😄
https://github.com/coronasafe/care_fe/issues/4928#issuecomment-1447715177
Shared a comment on a pull request in coronasafe/care_fe on February 28, 2023 at 7:34:32 AM
@nihal467 cypress failed to start because of integrity errors in the fixtures. cc: @khavinshankar @GokulramGHV
https://github.com/coronasafe/care_fe/pull/4653#issuecomment-1447710159
Shared a comment on a pull request in coronasafe/care_fe on February 28, 2023 at 6:21:58 AM
@khavinshankar unable to use a single file locales yaml. Will open an issue regd. it. Let the warnings be merged for now.
https://github.com/coronasafe/care_fe/pull/4750#issuecomment-1447650707
Shared a comment on an issue in coronasafe/care_fe on February 27, 2023 at 7:13:01 PM
@aparnacoronasafe
https://github.com/coronasafe/care_fe/issues/4894#issuecomment-1446907976
Shared a comment on a pull request in coronasafe/care_fe on February 27, 2023 at 11:17:16 AM
@nihal467 only unused localizations were removed. Good to be merged since it's already been tested. cc: @khavinshankar
https://github.com/coronasafe/care_fe/pull/4495#issuecomment-1446150290
Shared a comment on an issue in coronasafe/care_fe on February 24, 2023 at 5:06:19 AM
@siva-balan you may make use of `FormField` components such as `TextFormField` and `TextAreaFormField` that would automatically apply the required designs and behaviors that is consistent with other places.
https://github.com/coronasafe/care_fe/issues/4867#issuecomment-1442817150
Shared a comment on a pull request in coronasafe/care_fe on February 23, 2023 at 4:18:56 AM
will be re-opening a fresh PR.
https://github.com/coronasafe/care_fe/pull/4750#issuecomment-1441197958
Shared a comment on an issue in coronasafe/care_fe on February 22, 2023 at 5:05:49 AM
@nihal467 ETA soon after HCX
https://github.com/coronasafe/care_fe/issues/3995#issuecomment-1439446095
Shared a comment on an issue in coronasafe/care_fe on February 20, 2023 at 1:41:55 PM
@nihal467 closing this as not reproducible.
https://github.com/coronasafe/care_fe/issues/4710#issuecomment-1437044802
Shared a comment on an issue in coronasafe/care_fe on February 15, 2023 at 8:07:34 AM
@Ashesh3 is not reproducible in staging. For some reason, it's happening in the HCX fork only. Feel free to re-open this if you find it in staging.
https://github.com/coronasafe/care_fe/issues/4824#issuecomment-1430911806
Shared a comment on an issue in coronasafe/care_fe on February 14, 2023 at 4:41:26 AM
Duplicate of #4802
https://github.com/coronasafe/care_fe/issues/4601#issuecomment-1429105336
Shared a comment on a pull request in coronasafe/care_fe on February 13, 2023 at 3:53:53 AM
@cp-Coder could you clear the merge conflicts too?
https://github.com/coronasafe/care_fe/pull/3799#issuecomment-1427299677
Shared a comment on a pull request in coronasafe/care_fe on February 13, 2023 at 3:53:53 AM
@cp-Coder could you clear the merge conflicts too?
https://github.com/coronasafe/care_fe/pull/3799#issuecomment-1427299677
Shared a comment on an issue in coronasafe/care_fe on February 11, 2023 at 2:25:02 PM
Duplicate of #4803 cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4768#issuecomment-1426782814
Shared a comment on an issue in coronasafe/care_fe on February 8, 2023 at 7:51:55 AM
@aparnacoronasafe shall I proceed with making it `DD/MM/YYY` or is there any specific format you want me to follow for the dates?
https://github.com/coronasafe/care_fe/issues/4709#issuecomment-1422175857
Shared a comment on a pull request in coronasafe/care_fe on February 7, 2023 at 2:50:06 PM
@mathew-alex could you connect a monitor for the automated daily rounds to patient Annie Philip?
https://github.com/coronasafe/care_fe/pull/4726#issuecomment-1420901078
Shared a comment on an issue in coronasafe/care_fe on February 7, 2023 at 1:06:13 PM
@nihal467 how about the design present in Figma? ![image](https://user-images.githubusercontent.com/25143503/217252807-1942e1c9-ffd3-4041-8402-94a407de344d.png)
https://github.com/coronasafe/care_fe/issues/4785#issuecomment-1420743180
Shared a comment on a pull request in coronasafe/care_fe on February 7, 2023 at 11:38:54 AM
@Ashesh3 could you try setting `accent-[color]` class?
https://github.com/coronasafe/care_fe/pull/4741#issuecomment-1420634135
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 1:58:00 PM
@skks1212 shall I proceed with wrapping with Slideover for Advanced Filters without waiting for the schema-based filters thing?
https://github.com/coronasafe/care_fe/issues/3995#issuecomment-1419123486
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 1:52:21 PM
@nihal467 the related PR had been broken down into smaller PRs. Few of them are complete, filters are pending.
https://github.com/coronasafe/care_fe/issues/3995#issuecomment-1419115807
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 11:25:35 AM
An issue because useLocationChange's fullPath didn't preserve query params
https://github.com/coronasafe/care_fe/issues/4773#issuecomment-1418929210
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 1:58:00 PM
@skks1212 shall I proceed with wrapping with Slideover for Advanced Filters without waiting for the schema-based filters thing?
https://github.com/coronasafe/care_fe/issues/3995#issuecomment-1419123486
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 1:52:21 PM
@nihal467 the related PR had been broken down into smaller PRs. Few of them are complete, filters are pending.
https://github.com/coronasafe/care_fe/issues/3995#issuecomment-1419115807
Shared a comment on an issue in coronasafe/care_fe on February 6, 2023 at 11:25:35 AM
An issue because useLocationChange's fullPath didn't preserve query params
https://github.com/coronasafe/care_fe/issues/4773#issuecomment-1418929210
Shared a comment on an issue in coronasafe/care_fe on February 5, 2023 at 2:22:44 AM
#### Reasons for not going with rule `eslint-plugin-react/jsx-no-literals` solution: - Does not allow control over which props should be included or excluded from linting Example: ```jsx // ignoreProps: true <TextFormField ... label="Full Name" // no warning /> ``` ```jsx // ignoreProps: false <TextFormField ... className="mt-2" // warns about props that doesn't make sense for i18 /> ``` #### [`edvardchen/eslint-plugin-i18next`](https://github.com/edvardchen/eslint-plugin-i18next) allows us to achieve this by setting with: ```json "i18next/no-literal-string": [ "warn", { "mode": "all", "jsx-attributes": { "include": ["label", "placeholder", "error", "title"], "exclude": [".*"] } } ] ```
https://github.com/coronasafe/care_fe/issues/4749#issuecomment-1416903715
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:36:11 PM
@cp-Coder feel free to close this issue if you want to handle localisations in related PRs.
https://github.com/coronasafe/care_fe/issues/4472#issuecomment-1415955374
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:35:54 PM
@Ashesh3 feel free to close this issue if you want to handle localisations in related PRs or continue working on it since it's less likely we'll have merge conflicts under the External Results sections.
https://github.com/coronasafe/care_fe/issues/4477#issuecomment-1415955060
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:34:34 PM
@cp-Coder feel free to close this issue if you want to handle localisations in related PRs.
https://github.com/coronasafe/care_fe/issues/4478#issuecomment-1415953584
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:33:38 PM
@cp-Coder feel free to close this issue if you want to handle localisations in related PRs.
https://github.com/coronasafe/care_fe/issues/4486#issuecomment-1415952468
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:32:45 PM
@Ashesh3 feel free to close this issue if you want to handle localisations in related PRs. It's very likely there'll be lots of conflicts under the Patients section.
https://github.com/coronasafe/care_fe/issues/4483#issuecomment-1415951400
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:31:53 PM
@Ashesh3 feel free to close this issue if you want to handle localisations in related PRs or, continue working on it since it's less likely to have PRs coming up related to the Resources section that could cause conflicts.
https://github.com/coronasafe/care_fe/issues/4484#issuecomment-1415950328
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:28:37 PM
Closing as localisations under this shall be done gradually in upcoming PRs to avoid too many merge conflicts.
https://github.com/coronasafe/care_fe/issues/4474#issuecomment-1415946478
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:28:17 PM
Closing as localisations under this shall be done gradually in upcoming PRs to avoid too many merge conflicts.
https://github.com/coronasafe/care_fe/issues/4475#issuecomment-1415946090
Shared a comment on an issue in coronasafe/care_fe on February 3, 2023 at 2:27:42 PM
Closing as localisations under this shall be done gradually in upcoming PRs to avoid too many merge conflicts.
https://github.com/coronasafe/care_fe/issues/4480#issuecomment-1415945365
Shared a comment on a pull request in coronasafe/care_fe on February 3, 2023 at 4:12:15 AM
@siva-balan https://github.com/coronasafe/care_fe#%EF%B8%8F-make-use-labels-to-update-the-prissue-status
https://github.com/coronasafe/care_fe/pull/4737#issuecomment-1414874688
Shared a comment on a pull request in coronasafe/care_fe on January 27, 2023 at 4:15:05 PM
@nihal467 i've fixed it, could you checck now
https://github.com/coronasafe/care_fe/pull/4551#issuecomment-1406716441
Shared a comment on an issue in coronasafe/care_fe on January 27, 2023 at 2:00:07 PM
fixed by 4908a8ba54605f200fbb2870d77a7fdf269bbc5b
https://github.com/coronasafe/care_fe/issues/4586#issuecomment-1406545105
Shared a comment on a pull request in coronasafe/care_fe on January 25, 2023 at 8:38:01 AM
yes color inversion was a solution proposed during EOD meet itself.
https://github.com/coronasafe/care_fe/pull/4627#issuecomment-1403261186
Shared a comment on a pull request in coronasafe/care_fe on January 24, 2023 at 2:27:42 PM
@nihal467 The first DPG logo is a placeholder for showing state logos in state-specific deployments. Will be removed once merged.
https://github.com/coronasafe/care_fe/pull/4627#issuecomment-1402039179
Shared a comment on a pull request in coronasafe/care_fe on January 22, 2023 at 8:02:00 AM
@nihal467 @khavinshankar cypress failing for things out of scope of this PR ![image](https://user-images.githubusercontent.com/25143503/213906306-5e916aec-20fe-4fb6-9bde-6f642060ff01.png)
https://github.com/coronasafe/care_fe/pull/4622#issuecomment-1399425444
Shared a comment on a pull request in coronasafe/care_fe on January 20, 2023 at 5:52:33 PM
@skks1212 There are two logos. 1. `state_logo` which for staging uses DPG logo as a placeholder. This one's beside CARE logo. 2. `static_dpg_white_logo` which as you suggested, added the DPG logo regardless of `state_logo` beside coronasafe
https://github.com/coronasafe/care_fe/pull/4627#issuecomment-1398741836
Shared a comment on a pull request in coronasafe/care_fe on January 20, 2023 at 2:02:00 PM
@skks1212 1/4 height for the div looks like this: ![image](https://user-images.githubusercontent.com/25143503/213715182-26afe323-c1ed-4487-a86b-b97d5b6c0a29.png)
https://github.com/coronasafe/care_fe/pull/4627#issuecomment-1398436796
Shared a comment on an issue in coronasafe/care_fe on January 20, 2023 at 5:51:53 AM
@nihal467 I'm not assigned to this issue. @Ashesh3 is :)
https://github.com/coronasafe/care_fe/issues/4485#issuecomment-1397951163
Shared a comment on a pull request in coronasafe/care_fe on January 16, 2023 at 3:08:57 PM
- Waiting for backend: https://github.com/coronasafe/care/pull/1151
https://github.com/coronasafe/care_fe/pull/4551#issuecomment-1384192615
Shared a comment on an issue in coronasafe/care_fe on January 13, 2023 at 1:56:15 PM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4580#issuecomment-1381891833
Shared a comment on an issue in coronasafe/care_fe on January 13, 2023 at 5:25:08 AM
@nihal467 I've built the form builder, will continue working on it and open a draft PR once other priority issues assigned to me are completed.
https://github.com/coronasafe/care_fe/issues/3872#issuecomment-1381331700
Shared a comment on a pull request in coronasafe/care_fe on January 12, 2023 at 6:15:26 AM
As mentioned in issue, we'll be fragmenting this PR (some fragments have been completed and merged already)
https://github.com/coronasafe/care_fe/pull/3996#issuecomment-1379864206
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2023 at 6:22:24 AM
@Pranshu1902 closing this as solved by #4557
https://github.com/coronasafe/care_fe/pull/4556#issuecomment-1378291601
Shared a comment on an issue in coronasafe/care on January 11, 2023 at 5:59:51 AM
@siddnikh No. Only file size restriction is required as of now, since we do not have clear limits on what all file extensions are allowed. Also, since doctors are uploading these files, it's very unlikely that they'll misuse this flaw.
https://github.com/coronasafe/care/issues/1141#issuecomment-1378275724
Shared a comment on an issue in coronasafe/care_fe on January 11, 2023 at 5:55:37 AM
Waiting for - #4514
https://github.com/coronasafe/care_fe/issues/4192#issuecomment-1378273365
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2023 at 5:53:07 AM
@mathew-alex I've reverted the eslint ignore patterns as #4521 solves the need for that by whitelisting instead of blacklisting.
https://github.com/coronasafe/care_fe/pull/4514#issuecomment-1378271978
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2023 at 5:36:08 AM
@Pranshu1902 fixed in #4557 (check the logic there) The issue was, when the button classes were moved to CAREUI.css from index.css, for weird reason bg-color was getting overridden by a class that resets bg-color. cc: @skks1212
https://github.com/coronasafe/care_fe/pull/4556#issuecomment-1378262864
Shared a comment on an issue in coronasafe/care_fe on January 10, 2023 at 3:13:22 AM
Now when the page loads with broken styling, the auto-update gets triggered and fetches the latest CSS files. So now, first the page visibly loads with broken styling, but immediately refreshes because of the auto-update, and then visibly loads properly.
https://github.com/coronasafe/care_fe/issues/4452#issuecomment-1376670351
Shared a comment on an issue in coronasafe/care_fe on January 9, 2023 at 3:53:26 PM
@aparnacoronasafe I'll be proceeding to make all other fields except specialisation for now. Specialisation will be made as an extension over UserSkills once @Pragati1610's PR #4455 is merged. Also, the Years of Experience will be a Month and Year of begin selector. cc: @gigincg
https://github.com/coronasafe/care_fe/issues/4501#issuecomment-1375845303
Shared a comment on an issue in coronasafe/care_fe on January 9, 2023 at 11:32:27 AM
Both front-end and back-end PRs would be ready by Tuesday 17th Jan, so very likely to be present by January Week 4 Release. I'm currently travelling this week, so if possible I'll try my best to push it earlier than above mentioned ETD.
https://github.com/coronasafe/care_fe/issues/4501#issuecomment-1375492551
Shared a comment on a pull request in coronasafe/care_fe on January 9, 2023 at 11:32:13 AM
@nihal467 @khavinshankar cypress if failing for things not related to this PR :/ Cypress is even failing for staging.
https://github.com/coronasafe/care_fe/pull/4530#issuecomment-1375492295
Shared a comment on an issue in coronasafe/care_fe on January 9, 2023 at 8:17:30 AM
https://github.com/coronasafe/care/issues/1146
https://github.com/coronasafe/care_fe/issues/4542#issuecomment-1375250390
Shared a comment on a pull request in coronasafe/care_fe on January 6, 2023 at 1:31:41 PM
@nihal467 should be fixed now
https://github.com/coronasafe/care_fe/pull/4527#issuecomment-1373628728
Shared a comment on an issue in coronasafe/care_fe on January 5, 2023 at 3:07:56 PM
@aparnacoronasafe yes :)
https://github.com/coronasafe/care_fe/issues/4501#issuecomment-1372337481
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 8:58:44 AM
@cp-Coder the pop-up dialogue is an unnecessary step present if we are viewing assets after landing from the facility home page. cc: @nihal467 https://user-images.githubusercontent.com/25143503/210740685-2c15a4e1-c833-469e-abe7-8b09bab3cd83.mp4
https://github.com/coronasafe/care_fe/pull/4495#issuecomment-1371944170
Shared a comment on a pull request in coronasafe/care_fe on January 5, 2023 at 4:26:31 AM
@patelaryan7751 wait for https://github.com/coronasafe/care_fe/pull/4470 for the `PhoneNumberFormField`
https://github.com/coronasafe/care_fe/pull/4428#issuecomment-1371768296
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 1:49:54 PM
Will be done along with tailwinding daily rounds form
https://github.com/coronasafe/care_fe/issues/4325#issuecomment-1370952719
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 1:19:18 PM
@aparnacoronasafe I'm re-opening this issue since it'll be auto-closed when the linked PR is merged.
https://github.com/coronasafe/care_fe/issues/4491#issuecomment-1370921115
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 12:54:13 PM
@aparnacoronasafe is this an optional or mandatory feature for all deployments? In other words, can a few deployments have a logo and a few may not have?
https://github.com/coronasafe/care_fe/issues/4442#issuecomment-1370895853
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 12:33:46 PM
@naman114 the video recording you have is #3996 which uses unicons, and it has been removed from care. This PR is #4487 and uses Care Icons.
https://github.com/coronasafe/care_fe/pull/4487#issuecomment-1370873232
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 8:30:00 AM
@aparnacoronasafe can you check this deploy preview: https://deploy-preview-4378--care-net.netlify.app/users/add A PR is already there that uses new components.
https://github.com/coronasafe/care_fe/issues/4491#issuecomment-1370615174
Shared a comment on an issue in coronasafe/care_fe on January 4, 2023 at 8:21:11 AM
@aparnacoronasafe we already have view password ![image](https://user-images.githubusercontent.com/25143503/210512749-55891b4e-9a44-4db5-82a3-0493411a3b53.png)
https://github.com/coronasafe/care_fe/issues/4491#issuecomment-1370608024
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 4:19:53 AM
My bad, this went unnoticed. Will fix now
https://github.com/coronasafe/care_fe/pull/4424#issuecomment-1370471979
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 4:02:43 AM
This PR will be broken down into multiple separate PRs to make it easier to review and develop
https://github.com/coronasafe/care_fe/pull/3996#issuecomment-1370462862
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 4:00:02 AM
@naman114 @khavinshankar fixed in #4487 by using the new `SlideOver` component instead.
https://github.com/coronasafe/care_fe/pull/4441#issuecomment-1370461476
Shared a comment on a pull request in coronasafe/care_fe on January 4, 2023 at 2:16:00 AM
@naman114 Yes I agree using redux is overkill 😅 Can you checkout this deploy preview? https://deploy-preview-3996--care-net.netlify.app I and shivank had solved this issue in an earlier PR. @khavinshankar can you put this on hold, I'll get the slideover implementation refactored out from that PR in a separate PR by today PR: https://github.com/coronasafe/care_fe/pull/3996
https://github.com/coronasafe/care_fe/pull/4441#issuecomment-1370413452
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 3:28:21 PM
A component: `NotificationItem` (the sidebar list item) could mimick the sidebar item, but could fetch the notification count from redux maybe? The open/close state may also be handled with redux.
https://github.com/coronasafe/care_fe/pull/4441#issuecomment-1369901430
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 3:25:22 PM
@naman114 I would ideally prefer using redux here.
https://github.com/coronasafe/care_fe/pull/4441#issuecomment-1369898052
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 2:35:56 PM
This issue is not getting solved when we trigger an update
https://github.com/coronasafe/care_fe/issues/4452#issuecomment-1369839466
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 1:18:25 PM
@nihal467 I'm not assigned to this PR, kept it free to take up. I'll take up once I cover up other issues that are assigned to me
https://github.com/coronasafe/care_fe/issues/4346#issuecomment-1369758125
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 9:45:04 AM
https://cdn.rithviknishad.dev/care.coronasafe.in_Archive.har
https://github.com/coronasafe/care_fe/issues/4452#issuecomment-1369564709
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 9:42:19 AM
![image](https://user-images.githubusercontent.com/25143503/210332469-90a875e6-8598-44fa-a4c1-ee491627cc42.png)
https://github.com/coronasafe/care_fe/issues/4452#issuecomment-1369562371
Shared a comment on a pull request in coronasafe/care_fe on January 3, 2023 at 6:46:30 AM
@nihal467 failing for patient creation. I've not made any changes relevant to it. It's failing for other prs too: https://github.com/coronasafe/care_fe/pull/4427/checks
https://github.com/coronasafe/care_fe/pull/4465#issuecomment-1369439002
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 5:49:42 AM
Feel free to further break down each sub-issue to multiple sub-issues if there's lots of translations to be done in one sub-issue itself. If so, link the issue in the sub-issues section by editing the first comment.
https://github.com/coronasafe/care_fe/issues/4467#issuecomment-1369414835
Shared a comment on an issue in coronasafe/care_fe on January 3, 2023 at 5:44:40 AM
Marking it as hold to finalize the approach
https://github.com/coronasafe/care_fe/issues/4467#issuecomment-1369413220
Shared a comment on an issue in coronasafe/care_fe on January 2, 2023 at 3:30:51 PM
Will be continued in a separate PR.
https://github.com/coronasafe/care_fe/issues/4024#issuecomment-1369038188
Shared a comment on an issue in coronasafe/care_fe on January 2, 2023 at 2:53:30 PM
As discussed in EOD, we should be validating the phone number and show phone number not valid if invalid and Trigger search only if phone number is valid.
https://github.com/coronasafe/care_fe/issues/4445#issuecomment-1369009069
Shared a comment on an issue in coronasafe/care_fe on January 2, 2023 at 2:52:34 PM
Followed up in coronasafe/care#1141
https://github.com/coronasafe/care_fe/issues/4448#issuecomment-1369008548
Shared a comment on an issue in coronasafe/care_fe on January 2, 2023 at 2:48:43 PM
As discussed, we'll be trying to have auto update regardless of what branch, and use automated versioning based on `github.run_number`
https://github.com/coronasafe/care_fe/issues/4452#issuecomment-1369006318
Shared a comment on an issue in coronasafe/care_fe on December 30, 2022 at 12:15:22 PM
Marking as team discussion required to conclude on which solution to be followed
https://github.com/coronasafe/care_fe/issues/4445#issuecomment-1367888791
Shared a comment on an issue in coronasafe/care_deploy_configs on December 29, 2022 at 1:40:44 PM
Completed via: 67a15572cec94915d5c3832fe5b35d438b0c442a
https://github.com/coronasafe/care_deploy_configs/issues/2#issuecomment-1367329708
Shared a comment on an issue in coronasafe/care_fe on December 28, 2022 at 8:46:20 AM
@khavinshankar @GokulramGHV we already have a custom modal for actions that require confirmation, we could re-use it. ![image](https://user-images.githubusercontent.com/25143503/209784741-f803b34f-5deb-4fa2-b889-1d56fac39237.png)
https://github.com/coronasafe/care_fe/issues/4434#issuecomment-1366473248
Shared a comment on an issue in coronasafe/care_deploy_configs on December 28, 2022 at 5:48:25 AM
Fixed in 5fd0522adbe7289510034c9e0c3ef66600f626b8
https://github.com/coronasafe/care_deploy_configs/issues/1#issuecomment-1366386450
Shared a comment on an issue in coronasafe/care_fe on December 28, 2022 at 4:18:16 AM
Configurations for staging added to [coronasafe/care_deploy_configs/configs/](https://github.com/coronasafe/care_deploy_configs/tree/main/configs) directory. cc: @mathew-alex
https://github.com/coronasafe/care_fe/issues/4192#issuecomment-1366355802
Shared a comment on a pull request in coronasafe/care_fe on December 24, 2022 at 11:54:23 AM
@Pranshu1902 this feels like there's too much text present and congested now near the title. How about the way @khavinshankar has suggested in the issue itself? That would look great!
https://github.com/coronasafe/care_fe/pull/4391#issuecomment-1364517285
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 11:29:44 AM
I thought there was something like (HTML way) since it's pretty common behaviour in other websites to not validate until focus. Additional JS, I also wouldn't proceed 😅
https://github.com/coronasafe/care_fe/issues/4394#issuecomment-1364513897
Shared a comment on an issue in coronasafe/care_fe on December 24, 2022 at 6:03:23 AM
@Ashesh3 can you remove the invalid:border-danger-500 from cui-input-base class? I added it to make required fields error out if it's invalid / empty. or is there a way to not validate the input until the element got focus or something?
https://github.com/coronasafe/care_fe/issues/4394#issuecomment-1364469017
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 12:11:16 PM
Nah, nevermind 😅 It was failing locally because in my local I had the git ignored `/build-meta.json` being served and forgot to remove it after completing the work with Update CARE prompt PR. The update available prompt wouldn't be triggered if it failed to fetch the `/build-meta.json` file.
https://github.com/coronasafe/care_fe/pull/4388#issuecomment-1362766700
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 11:57:44 AM
The cypress test is failing here for the external result (which is not at all related to the PR). locally too, coz the update care prompt is hiding the active button. It fails for my other PR branch too locally, but not sure how it's passing in CI in those PRs. cc: @khavinshankar
https://github.com/coronasafe/care_fe/pull/4388#issuecomment-1362754205
Shared a comment on a pull request in coronasafe/care_fe on December 22, 2022 at 6:50:25 AM
unholding coz just realized its a plug-and-play replacement anyways which can be done later too :)
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1362479481
Shared a comment on an issue in coronasafe/care_fe on December 22, 2022 at 4:14:09 AM
Yeay! Having it as PNG seems to be using very less memory ![image](https://user-images.githubusercontent.com/25143503/209054278-a02822b1-3858-4eda-9899-496712d5c934.png)
https://github.com/coronasafe/care_fe/issues/4374#issuecomment-1362390886
Shared a comment on an issue in coronasafe/care_fe on December 21, 2022 at 7:23:14 AM
Will be worked on after #4309 is merged, along with adding the `Form` component.
https://github.com/coronasafe/care_fe/issues/3872#issuecomment-1360946593
Shared a comment on an issue in coronasafe/care_fe on December 21, 2022 at 7:03:55 AM
A bug reported 10 years ago: https://bugzilla.mozilla.org/show_bug.cgi?id=786108 Not sure if this would help: https://codepen.io/tigt/post/improving-svg-rendering-performance#to-animate-svg-give-it-a-div-parent-and-animate-that-instead-16 ![image](https://user-images.githubusercontent.com/25143503/208841818-7a92e45d-e510-4365-9b8d-8730b5de7162.png) cc: @skks1212
https://github.com/coronasafe/care_fe/issues/4374#issuecomment-1360931115
Shared a comment on an issue in coronasafe/leaderboard on December 21, 2022 at 4:54:12 AM
A very big page is rendered nowadays since we have lots of data, so how about we introduce: - A tab (I vote for this) or filters to filter out event sources: [GitHub, Slack]. - And also pagination or month-based filter similar to a style of pagination? cc: @bodhish what do you think about this?
https://github.com/coronasafe/leaderboard/issues/97#issuecomment-1360857306
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 3:57:58 AM
Coming via #4309
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1360824381
Shared a comment on a pull request in coronasafe/care_fe on December 21, 2022 at 3:57:37 AM
@cp-Coder marking it as hold, since we will now have `FormField` compliant components coming, for example `SelectFormField` shall be used in place of `SelectMenuV2`. `FormField` components have similar design and API to that of `TextFormField` which you have used so far in many places.
https://github.com/coronasafe/care_fe/pull/4378#issuecomment-1360824101
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 2:39:14 PM
Merged latest develop too, cypress would pass now
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1357767690
Shared a comment on an issue in coronasafe/care_fe on December 19, 2022 at 1:05:41 PM
@khavinshankar I think it should work, but I wonder how it also affects the add patient details button too?
https://github.com/coronasafe/care_fe/issues/4353#issuecomment-1357636267
Shared a comment on an issue in coronasafe/care_fe on December 19, 2022 at 12:49:09 PM
@khavinshankar I understood the problem. I should make sure I stop inlining components 😅 Btw, do you mean to refactor out the ExportMenu, ExportButton, and _CSVLink outside of the hook? Or to create two components ExportMenu, and ExportButton that replicates the functionality of the useExport hook inside it?
https://github.com/coronasafe/care_fe/issues/4353#issuecomment-1357617273
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 9:51:41 AM
@nihal467 fixed. could you check now
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1357377312
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 9:49:03 AM
@nihal467 yes.
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1357374322
Shared a comment on a pull request in coronasafe/care_fe on December 19, 2022 at 9:11:40 AM
@Ashesh3 yea on it. just finished, pushing it
https://github.com/coronasafe/care_fe/pull/4358#issuecomment-1357327391
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:42:04 PM
@cp-Coder the icon text alignment issue inside button will be resolved in one shot by PR of #4347 as discussed in it's comments. @Ashesh3 do link this PR too when the issue is fixed.
https://github.com/coronasafe/care_fe/issues/4343#issuecomment-1356824228
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:31:49 PM
along with `gap-2` also maybe? it's still overridable since the `classNames` passed as a prop is appended to the end
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356822614
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:30:31 PM
@Ashesh3 what do you think about updating the `ButtonV2` component to have `inline-flex items-center` already present in it's classNames?
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356822437
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:08:30 PM
I had to manually do `mt-0.5` or `mt-1` at places where font-awesome was replaced with CareIcon
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356818812
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 3:07:43 PM
@Ashesh3 i think all the icons are misaligned when we use care icons even after setting `flex gap-2 items-center`.
https://github.com/coronasafe/care_fe/issues/4347#issuecomment-1356818637
Shared a comment on an issue in coronasafe/care_fe on December 18, 2022 at 2:22:25 PM
@nihal467 @cp-Coder solved in https://github.com/coronasafe/care_fe/pull/4226
https://github.com/coronasafe/care_fe/issues/4344#issuecomment-1356809872
Shared a comment on a pull request in coronasafe/care_fe on December 17, 2022 at 8:15:32 AM
I guess we could achieve that by manipulating the min and max prop of DateInput during onChange?
https://github.com/coronasafe/care_fe/pull/4329#issuecomment-1356114469
Shared a comment on a pull request in coronasafe/care_fe on December 17, 2022 at 8:14:11 AM
@Ashesh3 the swapping feels weird, one might feel that it didn't select what I clicked. Just a suggestion, how about disabling users from selecting a date that beyond constraint? For example: If I select start: Dec 1, in the end-picker, dates on or before Dec-1 shall be disabled.
https://github.com/coronasafe/care_fe/pull/4329#issuecomment-1356114192
Shared a comment on an issue in coronasafe/care_fe on December 17, 2022 at 7:05:31 AM
Issue is still present in the patient filters
https://github.com/coronasafe/care_fe/issues/3983#issuecomment-1356079325
Shared a comment on an issue in coronasafe/care_fe on December 17, 2022 at 6:13:16 AM
@Pranshu1902 just a heads up, since we are moving to tailwind based components, can u implement this fix for `DateInputV2` instead? and then replace the DatePicker used in asset form with `DateFormField`
https://github.com/coronasafe/care_fe/issues/4326#issuecomment-1356061668
Shared a comment on an issue in coronasafe/care_fe on December 17, 2022 at 12:54:24 AM
Closing this as we have custom-built `DateFormField` and `DateRangeFormField` using tailwind as of now.
https://github.com/coronasafe/care_fe/issues/2380#issuecomment-1355886062
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 1:07:35 PM
@khavinshankar yes
https://github.com/coronasafe/care_fe/pull/4310#issuecomment-1354740704
Shared a comment on a pull request in coronasafe/care_fe on December 16, 2022 at 11:57:42 AM
@nihal467 I've updated the cypress test for external results
https://github.com/coronasafe/care_fe/pull/4310#issuecomment-1354638339
Shared a comment on a pull request in coronasafe/care_fe on December 14, 2022 at 10:55:10 AM
Since the changes in this PR are no longer required to solve the problem, made a new PR #4309
https://github.com/coronasafe/care_fe/pull/4276#issuecomment-1350915828
Shared a comment on a pull request in coronasafe/care_fe on December 14, 2022 at 8:52:40 AM
@dependabot duplicate of #4307
https://github.com/coronasafe/care_fe/pull/4279#issuecomment-1350658538
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2022 at 11:53:21 AM
@gigincg regd. if `build-meta.json` is cached: Nope, its not. ![image](https://user-images.githubusercontent.com/25143503/207310860-95f92a4c-423b-415d-935d-11c8eabc2fba.png)
https://github.com/coronasafe/care_fe/pull/4298#issuecomment-1348359940
Shared a comment on a pull request in coronasafe/care_fe on December 13, 2022 at 11:31:13 AM
@nihal467 not intentional. however the color pallete of gray for the entire app was updated to respect color palette as per figma design. Will update the background shade to a lighter shade in this PR itself.
https://github.com/coronasafe/care_fe/pull/4276#issuecomment-1348296610
Shared a comment on an issue in coronasafe/care_fe on December 12, 2022 at 4:30:28 AM
Acknowledged
https://github.com/coronasafe/care_fe/issues/4275#issuecomment-1345860548
Shared a comment on an issue in coronasafe/care_fe on December 12, 2022 at 3:23:14 AM
@nihal467 I've made the changes by using the new tailwinding components there. However now the form looks half old half new design and the new text area feels disabled because the new text area is gray background. Will update the colors of the component itself to white and link a PR by 11 AM.
https://github.com/coronasafe/care_fe/issues/4271#issuecomment-1345814974
Shared a comment on a pull request in coronasafe/care_fe on December 10, 2022 at 5:40:29 PM
@nihal467 deploy ready for testing
https://github.com/coronasafe/care_fe/pull/4270#issuecomment-1345344578
Shared a comment on an issue in coronasafe/care_fe on December 9, 2022 at 4:57:24 PM
Closing as I'm no longer able to reproduce this issue. My PC seems to be doing some witchcraft these days.
https://github.com/coronasafe/care_fe/issues/4265#issuecomment-1344536945
Shared a comment on a pull request in coronasafe/care_fe on December 9, 2022 at 6:31:30 AM
Deploy Preview ready
https://github.com/coronasafe/care_fe/pull/4244#issuecomment-1343910140
Shared a comment on a pull request in coronasafe/care_fe on December 9, 2022 at 5:15:51 AM
Deploy Preview ready
https://github.com/coronasafe/care_fe/pull/4244#issuecomment-1343861283
Shared a comment on a pull request in coronasafe/care_fe on December 9, 2022 at 5:13:56 AM
@nihal467 i've fixed the merge conflict
https://github.com/coronasafe/care_fe/pull/4244#issuecomment-1343860133
Shared a comment on an issue in coronasafe/care_fe on December 7, 2022 at 9:16:13 AM
It was discussed to make this a secondary variant button instead of adding it to a dropdown. cc: @nihal467
https://github.com/coronasafe/care_fe/issues/4205#issuecomment-1340631104
Shared a comment on a pull request in coronasafe/care_fe on December 6, 2022 at 2:15:22 PM
@nihal467 fixed it
https://github.com/coronasafe/care_fe/pull/4238#issuecomment-1339453534
Shared a comment on an issue in coronasafe/care_fe on December 6, 2022 at 12:45:11 PM
Duplicate of #3953
https://github.com/coronasafe/care_fe/issues/4224#issuecomment-1339269924
Shared a comment on a pull request in coronasafe/care_fe on December 2, 2022 at 4:11:03 PM
@gigincg can this be merged? the new changes in this PR seem to be not taken unless merged, so I can't test either.
https://github.com/coronasafe/care_fe/pull/4194#issuecomment-1335485131
Shared a comment on a pull request in coronasafe/care_fe on December 2, 2022 at 4:08:15 PM
Deploy Preview failed
https://github.com/coronasafe/care_fe/pull/4194#issuecomment-1335477857
Shared a comment on an issue in coronasafe/care_fe on December 2, 2022 at 3:05:13 PM
@naman114 this behaviour is solved in https://github.com/coronasafe/care_fe/pull/3996
https://github.com/coronasafe/care_fe/issues/4191#issuecomment-1335383264
Shared a comment on a pull request in coronasafe/care_fe on December 2, 2022 at 2:19:05 PM
Deploy Preview failed. (commented for testing)
https://github.com/coronasafe/care_fe/pull/4176#issuecomment-1335301391
Shared a comment on a pull request in coronasafe/care_fe on December 2, 2022 at 1:53:31 PM
Deploy Preview failed (ignore this comment, just using to test if the label is triggered)
https://github.com/coronasafe/care_fe/pull/4189#issuecomment-1335261358
Shared a comment on a pull request in coronasafe/care_fe on December 2, 2022 at 5:42:29 AM
- @skks1212 https://github.com/coronasafe/care_fe/pull/4071 will be removing support for unicons. So we could either use CareIcon once it's merged which has all the unicons, or font-awesome.
https://github.com/coronasafe/care_fe/pull/4159#issuecomment-1334787815
Shared a comment on a pull request in coronasafe/qr-generator on November 28, 2022 at 10:28:10 AM
@patelaryan7751 although this PR is not related to the issue, I think adding a loader too would be nice. Hence re-opening.
https://github.com/coronasafe/qr-generator/pull/6#issuecomment-1328850520
Shared a comment on a pull request in coronasafe/qr-generator on November 28, 2022 at 10:26:21 AM
@patelaryan7751 @gigincg the issue is not solved in this PR. It's about the delay present **before** the download starts after the generation is **completed**.
https://github.com/coronasafe/qr-generator/pull/6#issuecomment-1328848319
Shared a comment on a pull request in coronasafe/care_fe on November 28, 2022 at 10:02:27 AM
Already merged via https://github.com/coronasafe/care_fe/pull/4041. cc: @cp-Coder @khavinshankar
https://github.com/coronasafe/care_fe/pull/3965#issuecomment-1328815361
Shared a comment on an issue in coronasafe/care_fe on November 28, 2022 at 9:59:00 AM
And solved in #4118.
https://github.com/coronasafe/care_fe/issues/4138#issuecomment-1328810891
Shared a comment on an issue in coronasafe/care_fe on November 28, 2022 at 9:57:26 AM
Duplicate of #3992
https://github.com/coronasafe/care_fe/issues/4138#issuecomment-1328809103
Shared a comment on a pull request in coronasafe/care_fe on November 25, 2022 at 8:34:18 AM
@khavinshankar could you check now?
https://github.com/coronasafe/care_fe/pull/3307#issuecomment-1327157235
Shared a comment on an issue in coronasafe/care_fe on November 25, 2022 at 8:28:34 AM
Duplicate of https://github.com/coronasafe/care_fe/issues/3992
https://github.com/coronasafe/care_fe/issues/4111#issuecomment-1327152546
Shared a comment on an issue in coronasafe/care_fe on November 19, 2022 at 1:53:50 PM
@skks1212 shall we close this as continued in a more detailed EPIC: https://github.com/coronasafe/care_fe/issues/3742?
https://github.com/coronasafe/care_fe/issues/2776#issuecomment-1320890653
Shared a comment on an issue in coronasafe/care_fe on November 18, 2022 at 10:40:01 AM
@Ritesh-Aggarwal duplicate of #3954 and resolved in #3959
https://github.com/coronasafe/care_fe/issues/4075#issuecomment-1319825849
Shared a comment on a pull request in coronasafe/care_fe on November 18, 2022 at 6:13:29 AM
![image](https://user-images.githubusercontent.com/25143503/202633639-031ff76e-0dd3-4fae-b9aa-465b38790fe7.png)
https://github.com/coronasafe/care_fe/pull/4041#issuecomment-1319594208
Shared a comment on a pull request in coronasafe/care_fe on November 12, 2022 at 4:24:29 AM
Closing as base PR #4004 is closed, base PR #3920 is merged and a follow-up PR was made to fix the side-effect caused by the new Search Input in #4037. The only issue left to solve is resetting to page 1 when filters are updated, and will be continued in a new branch / PR since this PR contains many hacks to solve multiple issues present before.
https://github.com/coronasafe/care_fe/pull/4017#issuecomment-1312358673
Shared a comment on a pull request in coronasafe/care_fe on November 11, 2022 at 5:57:33 PM
@nihal467 could you check now
https://github.com/coronasafe/care_fe/pull/4037#issuecomment-1312003470
Shared a comment on a pull request in coronasafe/care_fe on November 11, 2022 at 5:49:37 PM
@nihal467 hold. quick fixing it.
https://github.com/coronasafe/care_fe/pull/4037#issuecomment-1311991524
Shared a comment on a pull request in coronasafe/care_fe on November 11, 2022 at 5:42:43 PM
@nihal467 pagination issue is not covered in this PR. This PR just prevents the search input from invoking the debounced onChange
https://github.com/coronasafe/care_fe/pull/4037#issuecomment-1311985503
Shared a comment on an issue in coronasafe/care_fe on November 11, 2022 at 1:09:36 PM
duplicate of #3984
https://github.com/coronasafe/care_fe/issues/3590#issuecomment-1311679159
Shared a comment on an issue in coronasafe/care_fe on November 11, 2022 at 12:42:35 PM
@nihal467 ![image](https://user-images.githubusercontent.com/25143503/201342750-b4559665-659c-4fd1-85a8-45070e894fd9.png)
https://github.com/coronasafe/care_fe/issues/4023#issuecomment-1311654955
Shared a comment on a pull request in coronasafe/care_fe on November 10, 2022 at 11:37:41 AM
@khavinshankar it's fixed in #4017 for all pages
https://github.com/coronasafe/care_fe/pull/3965#issuecomment-1310154969
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 6:44:23 PM
This looks fine I feel. Can you also add `tracking-widest` or `tracking-wider` class to the phone number? Phone numbers would be easier to read. Also lets wrap that to a component `ContactLink` which has props: ```jsx const ContactLinkProps = | { mailto: string; tel: undefined } | { mailto: undefined; tel: string }; ``` This way we can re-use the component with the same consistent design everywhere in future.
https://github.com/coronasafe/care_fe/pull/3819#issuecomment-1309207510
Shared a comment on an issue in coronasafe/care_fe on November 9, 2022 at 1:41:30 PM
Already been solved by #3991 and it's been merged. Issue not present in staging. Could you try hard refreshing the page?
https://github.com/coronasafe/care_fe/issues/4014#issuecomment-1308780165
Shared a comment on an issue in coronasafe/care_fe on November 9, 2022 at 11:05:24 AM
@aparnacoronasafe duplicate of #3954
https://github.com/coronasafe/care_fe/issues/4012#issuecomment-1308583788
Shared a comment on a pull request in coronasafe/care_fe on November 9, 2022 at 10:44:19 AM
Closing as #3882 is merged and this issue is no longer present in staging. Re-open if this PR solves additional problems.
https://github.com/coronasafe/care_fe/pull/3999#issuecomment-1308557893
Shared a comment on an issue in coronasafe/care_fe on November 9, 2022 at 10:42:36 AM
Closing as #3882 is merged and this issue is no longer present in staging.
https://github.com/coronasafe/care_fe/issues/3998#issuecomment-1308555942
Shared a comment on an issue in coronasafe/care_fe on November 9, 2022 at 5:31:32 AM
https://deploy-preview-3819--care-net.netlify.app/
https://github.com/coronasafe/care_fe/issues/4007#issuecomment-1308233972
Shared a comment on an issue in coronasafe/care_fe on November 9, 2022 at 5:25:48 AM
This is Facility Dashboard, which will be redesigned
https://github.com/coronasafe/care_fe/issues/4007#issuecomment-1308230703
Shared a comment on a pull request in coronasafe/care_fe on November 8, 2022 at 12:28:36 PM
@nihal the last comment by me was just about the changes that I have pushed. Not a request for changes to be made
https://github.com/coronasafe/care_fe/pull/3819#issuecomment-1307133330
Shared a comment on a pull request in coronasafe/care_fe on November 8, 2022 at 11:08:35 AM
Closing as merged to #3996
https://github.com/coronasafe/care_fe/pull/3997#issuecomment-1307032766
Shared a comment on a pull request in coronasafe/care_fe on November 8, 2022 at 2:14:19 AM
@kunatastic solved in #3882 by using the newer SelectMenuV2 components.
https://github.com/coronasafe/care_fe/pull/3999#issuecomment-1306521009
Shared a comment on an issue in coronasafe/care_fe on November 8, 2022 at 2:03:35 AM
Duplicate of #3882 @kunatastic
https://github.com/coronasafe/care_fe/issues/3998#issuecomment-1306509777
Shared a comment on an issue in coronasafe/care_fe on November 7, 2022 at 9:37:43 AM
@skks1212 duplicate of #3966
https://github.com/coronasafe/care_fe/issues/3990#issuecomment-1305339364
Shared a comment on a pull request in coronasafe/care_fe on November 7, 2022 at 8:33:23 AM
## Changes - Improve how ButtonV2 and DropdownMenuItem authorization works - Unauthorized actions are hidden in dropdown menu: ![image](https://user-images.githubusercontent.com/25143503/200262737-0c9557a8-3ba3-44d9-add2-035f0576ea85.png) ![image](https://user-images.githubusercontent.com/25143503/200262817-88e7f166-7476-4e25-8b95-0e9a91ace6f6.png)
https://github.com/coronasafe/care_fe/pull/3819#issuecomment-1305257824
Shared a comment on a pull request in coronasafe/care_fe on November 6, 2022 at 10:45:23 AM
@khavinshankar got it, it wasn't reproducible in firefox consistently but it was reproducible in chrome consistently.
https://github.com/coronasafe/care_fe/pull/3979#issuecomment-1304771277
Shared a comment on a pull request in coronasafe/care_fe on November 6, 2022 at 9:58:28 AM
@khavinshankar the issue is still present. However, it's solved in #3977 ![image](https://user-images.githubusercontent.com/25143503/200164517-8b5cc074-b22c-4bff-bf4d-48d62a0fa414.png)
https://github.com/coronasafe/care_fe/pull/3979#issuecomment-1304762072
Shared a comment on an issue in coronasafe/care_fe on November 6, 2022 at 8:02:20 AM
@nihal467 @khavinshankar the issue is not present in #3882 as it was changed to the newer `SelectMenuV2` from `SelectMenu`
https://github.com/coronasafe/care_fe/issues/3973#issuecomment-1304742140
Shared a comment on an issue in coronasafe/care_fe on November 5, 2022 at 3:07:45 PM
As discussed in EOD, we could make use of http://www.postalpincode.in/Api-Details
https://github.com/coronasafe/care_fe/issues/3940#issuecomment-1304563956
Shared a comment on a pull request in coronasafe/care_fe on November 5, 2022 at 10:32:21 AM
@nihal467 could you check it now
https://github.com/coronasafe/care_fe/pull/3942#issuecomment-1304491889
Shared a comment on an issue in coronasafe/care_fe on November 5, 2022 at 3:07:36 AM
Duplicate of #3955
https://github.com/coronasafe/care_fe/issues/3956#issuecomment-1304387479
Shared a comment on a pull request in coronasafe/leaderboard on November 4, 2022 at 4:12:13 PM
Closing as planned to move to graphql based scrapping.
https://github.com/coronasafe/leaderboard/pull/66#issuecomment-1303820593
Shared a comment on a pull request in coronasafe/care_fe on November 4, 2022 at 1:42:15 PM
@nihal467 ready for testing
https://github.com/coronasafe/care_fe/pull/3951#issuecomment-1303555886
Shared a comment on a pull request in coronasafe/care_fe on November 4, 2022 at 1:06:35 PM
@nihal467 fixed :) https://user-images.githubusercontent.com/25143503/199979463-c1095719-5ba6-4e2c-8e3d-7b9c2bb14a68.mp4
https://github.com/coronasafe/care_fe/pull/3942#issuecomment-1303512973
Shared a comment on a pull request in coronasafe/care_fe on November 4, 2022 at 8:46:49 AM
@nihal467 as of now, no, lets discuss in EOD. the current logic is the same logic which was there before the redesign
https://github.com/coronasafe/care_fe/pull/3941#issuecomment-1303128464
Shared a comment on a pull request in coronasafe/care_fe on November 4, 2022 at 7:10:43 AM
@nihal467 i've fixed it :) ![image](https://user-images.githubusercontent.com/25143503/199913996-77738f13-2344-4c89-bba8-5567fa07f4c5.png)
https://github.com/coronasafe/care_fe/pull/3941#issuecomment-1303055159
Shared a comment on an issue in coronasafe/care_fe on November 4, 2022 at 2:09:35 AM
@nihal467 Mapping out the list of places which is expected to be affected by or are using `AsyncAutoComplete` directly / indirectly. - [ ] All `FacilitySelect`s. - [ ] `AssetFilter`: Facility - [ ] All `FacilitiesSelectDialogue`s. - [ ] External Result: `ResultList`'s Facility Select Dialog - [ ] Patients: `ManagePatient`'s Facility Select Dialog - [ ] `ConsultationForm` Referred To Facility - [ ] `PatientFilterV2` (Patient Advanced Filters, Facility Select) - [ ] `SampleFilters` Facility - [ ] Patient: `ShiftCreate` - [ ] Name of shifting approving facility - [ ] What facility would you like to assign the patient to - [ ] Resource: `ListFilter` - [ ] Origin Facility - [ ] Resource Approving Facility - [ ] Assigned Facility - [ ] `ResourceCreate`: Name of Approving Facility - [ ] `ResourceDetailsUpdate` - [ ] Name of resource approving facility - [ ] What facility would you like to assign the request to - [ ] Shifting: `ListFilter` - [ ] Origin facility - [ ] Shifting approving facility - [ ] Assigned facility - [ ] `ShiftDetailsUpdate` - [ ] Name of shifting approving facility - [ ] What facility would you like to assign the patient to - [ ] User's `LinkFacilityDialog` - [ ] User Add: Linked facilities - [ ] All `DistrictSelect`s. - [ ] `PatientFilterV2` Advanced Patient Filters: District - [ ] `UserFilter`: District - [ ] Patient Advanced Filters: LSG Body - [ ] Consultation Form: Prescription Medication's Medicine Field - [ ] Consultation Form: PRN Prescription's Medicine Field
https://github.com/coronasafe/care_fe/issues/3937#issuecomment-1302869467
Shared a comment on a pull request in coronasafe/care_fe on November 2, 2022 at 2:33:43 PM
@nihal467 i've fixed the issue with spacing above notifications. ready for testing
https://github.com/coronasafe/care_fe/pull/3843#issuecomment-1300541401
Shared a comment on an issue in coronasafe/care_fe on November 1, 2022 at 4:07:45 PM
Duplicate of #3912
https://github.com/coronasafe/care_fe/issues/3832#issuecomment-1298765535
Shared a comment on an issue in coronasafe/care_fe on November 1, 2022 at 10:33:26 AM
### Components to be built - [ ] `Dialog` ``` expected props: - title - description (optional) - children - onClose (optional) - show ``` - [ ] `ConfirmActionDialog` (useful for confirm archive/delete or other critical operations) ``` props additional to above: - action: string (eg. "Delete") - severity: warning / danger - onConfirm - onCancel - confirmationText ``` example: ![image](https://user-images.githubusercontent.com/25143503/199214031-c0d8cc26-de3f-4c35-8b73-6f221a52e35e.png) cc: @khavinshankar @gigincg
https://github.com/coronasafe/care_fe/issues/3908#issuecomment-1298329737
Shared a comment on a pull request in coronasafe/care_fe on November 1, 2022 at 10:32:32 AM
@nihal467 you can test.
https://github.com/coronasafe/care_fe/pull/3901#issuecomment-1298328804
Shared a comment on an issue in coronasafe/care_fe on October 29, 2022 at 4:49:52 PM
Completed via: https://github.com/coronasafe/care_fe/pull/3863
https://github.com/coronasafe/care_fe/issues/3795#issuecomment-1295899041
Shared a comment on an issue in coronasafe/care_fe on October 28, 2022 at 6:25:05 AM
Not to use. I'll be porting pf-icons implementation
https://github.com/coronasafe/care_fe/issues/3781#issuecomment-1294517868
Shared a comment on a pull request in coronasafe/care_fe on October 26, 2022 at 1:22:52 PM
@khavinshankar can be ignored, or merge the latest develop for the storybook. Storybook is currently not there in this branch, that's why deploy is failing.
https://github.com/coronasafe/care_fe/pull/3801#issuecomment-1292028750
Shared a comment on an issue in coronasafe/care_fe on October 24, 2022 at 2:27:34 PM
@joelsajichacko @gigincg @aparnacoronasafe How about having a similar background in the recently redesigned warranty card, be also used in the sidebar's background and the login page background? #### Warranty Card's Background for reference: ![image](https://user-images.githubusercontent.com/25143503/197549993-a6960311-cafd-4d3b-8aed-2f16a47a1891.png) #### to be used in: ![image](https://user-images.githubusercontent.com/25143503/197549843-20555f11-35db-48f3-ac3e-b107bcd7cce0.png) cc: @skks1212
https://github.com/coronasafe/care_fe/issues/3781#issuecomment-1289122811
Shared a comment on an issue in coronasafe/care_fe on October 22, 2022 at 1:04:34 PM
Use the new tailwind components and FilterButtons component coming via: https://github.com/coronasafe/care_fe/pull/3744
https://github.com/coronasafe/care_fe/issues/3795#issuecomment-1287785510
Shared a comment on a pull request in coronasafe/care_fe on October 21, 2022 at 12:20:25 PM
- [x] The Image Upload modal is made responsive ![image](https://user-images.githubusercontent.com/25143503/197187610-91e28641-0e79-43e8-8b49-ca4c4987896d.png) - [x] The backend PR for delete image permission is done. Waiting to be merged. - [x] Show notification on save ![image](https://user-images.githubusercontent.com/25143503/197191873-725b31d3-09c6-4eff-81f6-d943717c41eb.png)
https://github.com/coronasafe/care_fe/pull/3528#issuecomment-1286887843
Shared a comment on an issue in coronasafe/care on October 21, 2022 at 9:07:51 AM
@siddnikh use closing keywords when linking PRs with issues when the PR achieves the requirements in the issue.
https://github.com/coronasafe/care/issues/989#issuecomment-1286678862
Shared a comment on a pull request in coronasafe/care_fe on October 19, 2022 at 5:18:18 AM
Duplicate of #3785
https://github.com/coronasafe/care_fe/pull/3786#issuecomment-1283443709
Shared a comment on a pull request in coronasafe/care_fe on October 18, 2022 at 7:53:15 AM
@skks1212 can we have new tailwind components along with this PR? so we could reuse these components in other places eventually with consistent design. - [ ] `Note` - [ ] `PropertyDetail` (or some better name 😅 ) - [ ] `<ContactDisplay type="mail" | "phone">` (links to tel or mailto) - [ ] `FeatureTag` for Active and Working so we could reuse it later in the facility home page redesign. ![image](https://user-images.githubusercontent.com/25143503/196369819-7e68d1bc-8872-48c4-aff1-7eaf14dd19c4.png) ideal component usage for note and property detail could look like this: ```jsx <> <PropertyDetail property="Service Details" icon={<i ... />} className=""> {asset_data.service_date} {/* text styling inherited from PropertyDetail */} </PropertyDetail> <PropertyDetail property="Notes" icon={<i ... />}> <Note> {asset_data.notes} {/* text styling overridden by Note */} </Note> </PropertyDetail> </> ``` cc: @gigincg
https://github.com/coronasafe/care_fe/pull/3771#issuecomment-1281960411
Shared a comment on a pull request in coronasafe/care_fe on October 17, 2022 at 9:36:44 AM
@nihal467 can this be tested ASAP? required by https://github.com/coronasafe/care_fe/pull/3744
https://github.com/coronasafe/care_fe/pull/3762#issuecomment-1280572453
Shared a comment on a pull request in coronasafe/care_dashboard on October 16, 2022 at 12:44:00 PM
Yup. I just thought to have a consistent experience regardless of the browser.
https://github.com/coronasafe/care_dashboard/pull/39#issuecomment-1279962545
Shared a comment on an issue in coronasafe/care_fe on October 16, 2022 at 2:27:15 AM
@nihal467 can the patient category colors be tested
https://github.com/coronasafe/care_fe/issues/2210#issuecomment-1279875290
Shared a comment on a pull request in coronasafe/care_fe on October 15, 2022 at 10:11:01 AM
Continued in #3744
https://github.com/coronasafe/care_fe/pull/3719#issuecomment-1279712149
Shared a comment on a pull request in coronasafe/care_fe on October 15, 2022 at 10:10:07 AM
Merged to #3744
https://github.com/coronasafe/care_fe/pull/3726#issuecomment-1279712002
Shared a comment on a pull request in coronasafe/care on October 14, 2022 at 10:21:57 AM
Required by: https://github.com/coronasafe/care_fe/issues/3618
https://github.com/coronasafe/care/pull/1063#issuecomment-1278807907
Shared a comment on a pull request in coronasafe/care_fe on October 14, 2022 at 5:19:12 AM
### What's new? Adds `ImageWithFallback` component and utilised for facility cover image when an image cannot be retrieved. ![image](https://user-images.githubusercontent.com/25143503/195767882-6d0a13c5-0227-43fb-8ec6-f23421179e1e.png) ![image](https://user-images.githubusercontent.com/25143503/195767912-42e2e0b1-be66-4916-9d7a-8c7b92dabacf.png) ![image](https://user-images.githubusercontent.com/25143503/195767959-d21f2216-42bb-4e9d-aec9-71044b16ecad.png) ![image](https://user-images.githubusercontent.com/25143503/195767995-41c8dc82-943a-48ba-94f0-484344591e27.png)
https://github.com/coronasafe/care_fe/pull/3528#issuecomment-1278496912
Shared a comment on an issue in coronasafe/care_fe on October 14, 2022 at 3:40:19 AM
working on it :)
https://github.com/coronasafe/care_fe/issues/2880#issuecomment-1278438371
Shared a comment on an issue in coronasafe/care_fe on October 12, 2022 at 7:21:34 AM
@khavinshankar definitely!! Could you help tailwind the async autocomplete field in the https://github.com/coronasafe/care_fe/pull/3744 patient filters? Generally, apart from that, I was thinking of having all the input components have their own validators and also be compliant with form reducers across care since we mostly have only `set_form` and `set_error` only. so that, the component's API interface would just take in the additional props (validator, reducerProps) [see this](https://github.com/coronasafe/care_fe/pull/3744/files#diff-2c391d69e3a85e37959e9843913cba1d1db5aa23dac46c81625b168a38c78d9cR18-R29). however, the components API should still be usable when not used with reducers. So I was just taking time to document it clearly so that it's easily maintainable by everyone and changing the component API interface later would be a hassle. For example, the text input is composed like this: https://github.com/coronasafe/care_fe/pull/3744/files#diff-e0e39dd41cb8f0b76d60275fa706cd765c8648107e45183f24781aa0cd51145f and when used with reducers, the amount of code we write would be so less, but still, it'll render out the errors and field labels without having to write separate components each time.
https://github.com/coronasafe/care_fe/issues/3742#issuecomment-1275705355
Shared a comment on a pull request in coronasafe/care_fe on October 11, 2022 at 8:49:43 AM
@Ashesh3 two things: - [ ] Consultation updates for "Slightly Abnormal" and "Comfort Care" not working. - [ ] Daily rounds are broken. Page not even opening.
https://github.com/coronasafe/care_fe/pull/3741#issuecomment-1274334798
Shared a comment on an issue in coronasafe/care_fe on October 11, 2022 at 4:29:09 AM
@mathew-alex The API response is now as expected, yay!! :)
https://github.com/coronasafe/care_fe/issues/2131#issuecomment-1274071451
Shared a comment on a pull request in coronasafe/care_fe on October 10, 2022 at 3:34:44 PM
Renamed the branch, so this closed automatically. Follow up PR: #3744
https://github.com/coronasafe/care_fe/pull/3697#issuecomment-1273495265
Shared a comment on an issue in coronasafe/care_fe on October 9, 2022 at 5:04:19 PM
@mathew-alex can the environment variable be set as required by https://github.com/coronasafe/care/pull/1056
https://github.com/coronasafe/care_fe/issues/2131#issuecomment-1272585060
Shared a comment on an issue in coronasafe/care_fe on October 9, 2022 at 4:51:21 PM
@stale do not close. waiting for #3698 to be merged.
https://github.com/coronasafe/care_fe/issues/3594#issuecomment-1272582651
Shared a comment on an issue in coronasafe/care on October 9, 2022 at 4:37:59 PM
@cp-Coder any updates on this?
https://github.com/coronasafe/care/issues/1031#issuecomment-1272580179
Shared a comment on a pull request in coronasafe/care_fe on October 4, 2022 at 2:28:36 PM
@nihal467 I've fixed the landing page title issue.
https://github.com/coronasafe/care_fe/pull/3683#issuecomment-1267095438
Shared a comment on a pull request in coronasafe/care_fe on October 3, 2022 at 12:20:43 PM
😢 thats a major change im gonna face in my consultation form tailwind update. I'll keep my PRs for (#3698 #3594) on hold until this is merged.
https://github.com/coronasafe/care_fe/pull/3698#issuecomment-1265360144
Shared a comment on a pull request in coronasafe/care_fe on October 3, 2022 at 11:27:42 AM
Continued in #3697
https://github.com/coronasafe/care_fe/pull/3010#issuecomment-1265302006
Shared a comment on a pull request in coronasafe/care_fe on October 2, 2022 at 9:36:05 AM
@patelaryan7751 the button layout is fixed in #3681
https://github.com/coronasafe/care_fe/pull/3680#issuecomment-1264596115
Shared a comment on a pull request in coronasafe/care on October 1, 2022 at 11:49:24 AM
Related to / required by #3528
https://github.com/coronasafe/care/pull/1044#issuecomment-1264339581
Shared a comment on a pull request in coronasafe/care_fe on September 28, 2022 at 3:41:06 AM
@nihal467 I'll make it as another PR then, since this PR has lot's of changes, its getting merge conflicts pretty quickly.
https://github.com/coronasafe/care_fe/pull/3458#issuecomment-1260345313
Shared a comment on a pull request in coronasafe/care_fe on September 27, 2022 at 8:48:52 AM
@Pranshu1902 asset page is fully redesigned in https://github.com/coronasafe/care_fe/pull/3458
https://github.com/coronasafe/care_fe/pull/3656#issuecomment-1259188422
Shared a comment on a pull request in coronasafe/care_fe on September 23, 2022 at 4:00:52 AM
@nihal467 Pragati's PR for https://github.com/coronasafe/care_fe/issues/2737 is solving the above mentioned issues, I've asked her. My PR is more focused on reducing reduplication of the existing code by making it into utility method. cc: @Pragati1610
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1255775468
Shared a comment on an issue in coronasafe/care_fe on September 20, 2022 at 7:40:03 AM
I'll do the front end modification's for this along with #3594 ?
https://github.com/coronasafe/care_fe/issues/3618#issuecomment-1251963036
Shared a comment on a pull request in coronasafe/care_fe on September 19, 2022 at 12:26:54 PM
@khavinshankar merge conflicts resolved.
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1250952823
Shared a comment on an issue in coronasafe/care_fe on September 17, 2022 at 2:34:44 PM
The new mandatory field has been merged
https://github.com/coronasafe/care_fe/issues/3602#issuecomment-1250082272
Shared a comment on an issue in coronasafe/care_fe on September 17, 2022 at 2:34:22 PM
Hard refresh and try
https://github.com/coronasafe/care_fe/issues/3602#issuecomment-1250082212
Shared a comment on an issue in coronasafe/care_fe on September 17, 2022 at 2:29:22 PM
@gigincg could you link the figma
https://github.com/coronasafe/care_fe/issues/3594#issuecomment-1250081494
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 2:50:47 AM
@Ashesh3 can you merge the latest develop, as there's a new mandatory field `category` added in the consultation form, hence form submission without this field would be rejected by the API.
https://github.com/coronasafe/care_fe/pull/3584#issuecomment-1247515559
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 2:17:21 AM
@khavinshankar all tests passing locally. ![image](https://user-images.githubusercontent.com/25143503/190297656-56367179-2d73-4730-950b-5e2d35b5463d.png)
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1247489627
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 1:57:44 AM
@khavinshankar @nihal467 all tests are passing when I ran cypress locally (with Staging BE). Workflow cypress is failing in many due to 403s. ![image](https://user-images.githubusercontent.com/25143503/190295228-8fa374da-7bee-446a-8854-ab081788d948.png)
https://github.com/coronasafe/care_fe/pull/3565#issuecomment-1247479159
Shared a comment on a pull request in coronasafe/care_fe on September 15, 2022 at 1:47:22 AM
@khavinshankar 1/18 test failing and it's a 403 on Search by District Name. irrelevant to this PR ryt. ![image](https://user-images.githubusercontent.com/25143503/190293804-93560b89-0476-4050-8432-3224adcec0b5.png)
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1247473829
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 4:07:41 PM
A minor bug was fixed, ready for testing. @nihal467
https://github.com/coronasafe/care_fe/pull/3565#issuecomment-1246991081
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 9:36:17 AM
Probably the staging API is not able to handle it? Since 403 and 502's are being returned.
https://github.com/coronasafe/care_fe/pull/3521#issuecomment-1246499743
Shared a comment on a pull request in coronasafe/care_fe on September 14, 2022 at 9:32:21 AM
@nihal467 Tests are failing whats out of the scope of the changes I intended to achieve in this PR. All are timeouts, including the one's in the scope of this PR. <details> <summary>Screenshots</summary> <img src="https://user-images.githubusercontent.com/25143503/190116546-cbcdf20d-35c6-46ef-8098-ad77fcd24d1d.png"/> <img src="https://user-images.githubusercontent.com/25143503/190116649-6b0a1997-15f0-4389-8017-bfd9e6d1f237.png"/> <img src="https://user-images.githubusercontent.com/25143503/190116788-8287e04b-036d-4ac0-b4f8-7aa4f8c8f6b0.png"/> </details>
https://github.com/coronasafe/care_fe/pull/3521#issuecomment-1246495093
Shared a comment on an issue in coronasafe/care_fe on September 11, 2022 at 12:15:27 PM
@Ashesh3 shall I assign it to you then? I didn't make much changes yet.
https://github.com/coronasafe/care_fe/issues/3571#issuecomment-1242951975
Shared a comment on a pull request in coronasafe/care on September 9, 2022 at 5:37:52 PM
Required by https://github.com/coronasafe/care_fe/pull/3565
https://github.com/coronasafe/care/pull/1007#issuecomment-1242272676
Shared a comment on a pull request in coronasafe/care_fe on September 9, 2022 at 2:26:53 PM
Reworked in #3565
https://github.com/coronasafe/care_fe/pull/2950#issuecomment-1242043002
Shared a comment on a pull request in coronasafe/care_fe on September 9, 2022 at 2:01:41 PM
Requires backend PR https://github.com/coronasafe/care/pull/1007
https://github.com/coronasafe/care_fe/pull/3565#issuecomment-1242014306
Shared a comment on a pull request in coronasafe/care on September 8, 2022 at 6:14:09 AM
coronasafe/care_fe#3528
https://github.com/coronasafe/care/pull/1003#issuecomment-1240269596
Shared a comment on a pull request in coronasafe/care on September 8, 2022 at 5:57:23 AM
This PR got dirty while resolving merge conflicts. Made a new PR #1007
https://github.com/coronasafe/care/pull/885#issuecomment-1240255466
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 9:26:45 AM
@patelaryan7751 ![image](https://user-images.githubusercontent.com/25143503/188843299-1368371f-ad17-454c-ab4d-b3b7ac546d62.png)
https://github.com/coronasafe/care_fe/pull/3283#issuecomment-1239139942
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:54:09 AM
@nihal467 the local body field is not applicable for the following user types: ![image](https://user-images.githubusercontent.com/25143503/188821738-a24cb352-1633-4596-aef9-268a38757f9c.png)
https://github.com/coronasafe/care_fe/pull/3521#issuecomment-1239039273
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:00:55 AM
@nihal467 its ready for testing as it was just being moved to another file.
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1238988520
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 9:26:45 AM
@patelaryan7751 ![image](https://user-images.githubusercontent.com/25143503/188843299-1368371f-ad17-454c-ab4d-b3b7ac546d62.png)
https://github.com/coronasafe/care_fe/pull/3283#issuecomment-1239139942
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:54:09 AM
@nihal467 the local body field is not applicable for the following user types: ![image](https://user-images.githubusercontent.com/25143503/188821738-a24cb352-1633-4596-aef9-268a38757f9c.png)
https://github.com/coronasafe/care_fe/pull/3521#issuecomment-1239039273
Shared a comment on a pull request in coronasafe/care_fe on September 7, 2022 at 7:00:55 AM
@nihal467 its ready for testing as it was just being moved to another file.
https://github.com/coronasafe/care_fe/pull/3520#issuecomment-1238988520
Shared a comment on a pull request in coronasafe/care_fe on September 6, 2022 at 4:54:14 PM
The new SelectMenu and Dropdown with Search required for this PR is under construction in #3458
https://github.com/coronasafe/care_fe/pull/3010#issuecomment-1238412820
Shared a comment on an issue in coronasafe/leaderboard on September 1, 2022 at 1:02:27 PM
Yes, it seems to be fixed in that PR.
https://github.com/coronasafe/leaderboard/issues/78#issuecomment-1234249142
Shared a comment on a pull request in coronasafe/leaderboard on September 1, 2022 at 1:02:16 PM
Fixes #78
https://github.com/coronasafe/leaderboard/pull/77#issuecomment-1234248893
Shared a comment on a pull request in coronasafe/leaderboard on September 1, 2022 at 1:00:54 PM
Closes #78
https://github.com/coronasafe/leaderboard/pull/77#issuecomment-1234247251
Shared a comment on a pull request in coronasafe/care_fe on August 31, 2022 at 7:32:49 AM
@nihal467 the device selected is a touch device, mouse moves without touch down (mouse down) will not be captured in that mode. ![image](https://user-images.githubusercontent.com/25143503/187619662-12df1660-655c-4274-8b18-4fe83c332816.png) however, it still works when touch mode is disabled for the same device: ![image](https://user-images.githubusercontent.com/25143503/187619362-36b8b88a-d675-4042-86d1-394d38b6a64e.png) ![image](https://user-images.githubusercontent.com/25143503/187619450-57dc723b-e501-47a1-a21f-6be38b6cab25.png) @gigincg
https://github.com/coronasafe/care_fe/pull/3473#issuecomment-1232570174
Shared a comment on a pull request in coronasafe/care_fe on August 30, 2022 at 11:44:47 AM
Updated Select Menu component: ![image](https://user-images.githubusercontent.com/25143503/187428220-eda4ff62-0e5e-4376-ad45-6b0f8b300937.png) ![image](https://user-images.githubusercontent.com/25143503/187428151-693eea7c-9aa6-4679-b3d3-4e967797c2d9.png)
https://github.com/coronasafe/care_fe/pull/3458#issuecomment-1231552668
Shared a comment on an issue in coronasafe/care_fe on August 22, 2022 at 4:39:04 PM
@aparnacoronasafe may I get help in translations for the new goal... - Kannada - Malayalam - Marati - Tamil
https://github.com/coronasafe/care_fe/issues/3455#issuecomment-1222615368
Shared a comment on a pull request in coronasafe/care on August 13, 2022 at 1:29:39 PM
@vigneshhari
https://github.com/coronasafe/care/pull/885#issuecomment-1214160166
Shared a comment on a pull request in coronasafe/care_fe on July 26, 2022 at 9:07:25 AM
Closing as fixed in #2848
https://github.com/coronasafe/care_fe/pull/3230#issuecomment-1195215033
Shared a comment on a pull request in coronasafe/care_fe on July 4, 2022 at 9:11:08 AM
@gigincg None of the breaking changes seems to effect our usage. Tested deploy too and everything seems to work, no issues due to axios bump found yet. List of breaking changes from axios releases between the above versions > - Distinguish request and response data types (https://github.com/axios/axios/pull/4116) > - Change never type to unknown (https://github.com/axios/axios/pull/4142) > - Fixed TransitionalOptions typings (https://github.com/axios/axios/pull/4147) > - Revert: change type of AxiosResponse to any, please read lengthy discussion here: (https://github.com/axios/axios/issues/4141) pull request: (https://github.com/axios/axios/pull/4186) > - Fixing maxBodyLength enforcement (https://github.com/axios/axios/pull/3786) > - Don't rely on strict mode behaviour for arguments (https://github.com/axios/axios/pull/3470) > - Adding error handling when missing url (https://github.com/axios/axios/pull/3791) > - Update isAbsoluteURL.js removing escaping of non-special characters (https://github.com/axios/axios/pull/3809) > - Use native Array.isArray() in utils.js (https://github.com/axios/axios/pull/3836) > - Adding error handling inside stream end callback (https://github.com/axios/axios/pull/3967) > - New toFormData helper function that allows the implementor to pass an object and allow axios to convert it to FormData (https://github.com/axios/axios/pull/3757) > - Removed functionality that removed the the Content-Type request header when passing FormData (https://github.com/axios/axios/pull/3785) > - (*) Refactored error handling implementing AxiosError as a constructor, this is a large change to error handling on the whole (https://github.com/axios/axios/pull/3645) > - Separated responsibility for FormData instantiation between transformRequest and toFormData (https://github.com/axios/axios/pull/4470) > - (*) Improved and fixed multiple issues with FormData support (https://github.com/axios/axios/pull/4448)
https://github.com/coronasafe/care_fe/pull/2286#issuecomment-1173561791
Shared a comment on a pull request in coronasafe/care_fe on July 2, 2022 at 8:38:28 AM
@nihal467 ![image](https://user-images.githubusercontent.com/25143503/176993283-44a10ae0-2681-4b6d-9fcd-41d83a64dbd8.png)
https://github.com/coronasafe/care_fe/pull/2654#issuecomment-1172861922
Shared a comment on a pull request in coronasafe/care_fe on July 1, 2022 at 12:43:03 AM
@nihal467
https://github.com/coronasafe/care_fe/pull/2654#issuecomment-1171805142
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 1:45:30 PM
@bodhi nope, the scrapper seems to simply be using start and end date with no time specified. I'll try to fix it ASAP, but need to discuss abt how to remove duplicates in already generated data in today's EOD.
https://github.com/coronasafe/leaderboard/pull/58#issuecomment-1168747191
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 1:34:45 PM
@bodhish @kunatastic since its running every 12 hours, the workflow is appending data of past 24 hours every 12 hours, which causes the duplicates issue #63
https://github.com/coronasafe/leaderboard/pull/58#issuecomment-1168733668
Shared a comment on a pull request in coronasafe/care_fe on June 28, 2022 at 5:47:05 AM
@patelaryan7751 Issue is noticeable in window sizes between the following: ![image](https://user-images.githubusercontent.com/25143503/176102612-2e1f20d1-4256-42b5-a83d-bf0ebd93c2e8.png)
https://github.com/coronasafe/care_fe/pull/2930#issuecomment-1168253413
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 1:45:30 PM
@bodhi nope, the scrapper seems to simply be using start and end date with no time specified. I'll try to fix it ASAP, but need to discuss abt how to remove duplicates in already generated data in today's EOD.
https://github.com/coronasafe/leaderboard/pull/58#issuecomment-1168747191
Shared a comment on a pull request in coronasafe/leaderboard on June 28, 2022 at 1:34:45 PM
@bodhish @kunatastic since its running every 12 hours, the workflow is appending data of past 24 hours every 12 hours, which causes the duplicates issue #63
https://github.com/coronasafe/leaderboard/pull/58#issuecomment-1168733668
Shared a comment on a pull request in coronasafe/care_fe on June 28, 2022 at 5:47:05 AM
@patelaryan7751 Issue is noticeable in window sizes between the following: ![image](https://user-images.githubusercontent.com/25143503/176102612-2e1f20d1-4256-42b5-a83d-bf0ebd93c2e8.png)
https://github.com/coronasafe/care_fe/pull/2930#issuecomment-1168253413
Shared a comment on a pull request in coronasafe/care on June 24, 2022 at 4:41:11 AM
@Marmik2003 @vigneshhari the migrations are missing... this PR's migrations were being generated when I was fixing another issue... ![image](https://user-images.githubusercontent.com/25143503/175463550-cf2830bb-a816-49ed-9727-962826d6fc9c.png)
https://github.com/coronasafe/care/pull/867#issuecomment-1165188669
Shared a comment on a pull request in coronasafe/care on June 24, 2022 at 4:41:11 AM
@Marmik2003 @vigneshhari the migrations are missing... this PR's migrations were being generated when I was fixing another issue... ![image](https://user-images.githubusercontent.com/25143503/175463550-cf2830bb-a816-49ed-9727-962826d6fc9c.png)
https://github.com/coronasafe/care/pull/867#issuecomment-1165188669
Shared a comment on an issue in coronasafe/care_fe on June 23, 2022 at 4:48:27 PM
Duplicate of https://github.com/coronasafe/care_fe/issues/2649
https://github.com/coronasafe/care_fe/issues/2809#issuecomment-1164644173
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 4:44:41 PM
@cp-Coder already done in https://github.com/coronasafe/care_fe/pull/2654
https://github.com/coronasafe/care_fe/pull/2813#issuecomment-1164640686
Shared a comment on an issue in coronasafe/care on June 23, 2022 at 2:20:19 PM
- [ ] Replace existing `patient_category` to `deprecated covid category` in both consultation and daily rounds - [ ] Run migrations for above - [ ] Create new field `patient category` with new choices - [ ] Run migrations
https://github.com/coronasafe/care/issues/875#issuecomment-1164470720
Shared a comment on an issue in coronasafe/care on June 23, 2022 at 10:13:07 AM
Closing as it's fixed. ![image](https://user-images.githubusercontent.com/25143503/175275818-f2c010b1-a6dc-47f8-a351-afe55d427a55.png)
https://github.com/coronasafe/care/issues/759#issuecomment-1164227991
Shared a comment on an issue in coronasafe/care_fe on June 23, 2022 at 4:48:27 PM
Duplicate of https://github.com/coronasafe/care_fe/issues/2649
https://github.com/coronasafe/care_fe/issues/2809#issuecomment-1164644173
Shared a comment on a pull request in coronasafe/care_fe on June 23, 2022 at 4:44:41 PM
@cp-Coder already done in https://github.com/coronasafe/care_fe/pull/2654
https://github.com/coronasafe/care_fe/pull/2813#issuecomment-1164640686
Shared a comment on an issue in coronasafe/care on June 23, 2022 at 2:20:19 PM
- [ ] Replace existing `patient_category` to `deprecated covid category` in both consultation and daily rounds - [ ] Run migrations for above - [ ] Create new field `patient category` with new choices - [ ] Run migrations
https://github.com/coronasafe/care/issues/875#issuecomment-1164470720
Shared a comment on an issue in coronasafe/care on June 23, 2022 at 10:13:07 AM
Closing as it's fixed. ![image](https://user-images.githubusercontent.com/25143503/175275818-f2c010b1-a6dc-47f8-a351-afe55d427a55.png)
https://github.com/coronasafe/care/issues/759#issuecomment-1164227991
Shared a comment on an issue in coronasafe/care_fe on June 22, 2022 at 4:10:14 AM
@aparnacoronasafe Did you mean these to be mapped with the respective colors? ![image](https://user-images.githubusercontent.com/25143503/174941496-7fe99d78-6c77-474c-abc0-2e37f72608fd.png)
https://github.com/coronasafe/care_fe/issues/2210#issuecomment-1162615450
Shared a comment on a pull request in coronasafe/care_fe on June 20, 2022 at 9:03:48 AM
https://www.loom.com/share/b977af4cd5bb4f2baaec02146be56ecc
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1160175325
Shared a comment on a pull request in coronasafe/care_fe on June 20, 2022 at 9:03:48 AM
https://www.loom.com/share/b977af4cd5bb4f2baaec02146be56ecc
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1160175325
Shared a comment on a pull request in coronasafe/care_fe on June 19, 2022 at 12:19:57 PM
Select menu implemented as part of #2776
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1159709871
Shared a comment on a pull request in coronasafe/care_fe on June 19, 2022 at 5:56:11 AM
Closes #2769
https://github.com/coronasafe/care_fe/pull/2770#issuecomment-1159623426
Shared a comment on a pull request in coronasafe/care_fe on June 19, 2022 at 12:19:57 PM
Select menu implemented as part of #2776
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1159709871
Shared a comment on a pull request in coronasafe/care_fe on June 19, 2022 at 5:56:11 AM
Closes #2769
https://github.com/coronasafe/care_fe/pull/2770#issuecomment-1159623426
Shared a comment on an issue in coronasafe/care_fe on June 18, 2022 at 11:20:50 AM
@gigincg also was this intended to be like navbar in the first place? `lg:absolute` with `right-0 top0` seems to have been added for it's div, but that seems to have a different intention.
https://github.com/coronasafe/care_fe/issues/2756#issuecomment-1159447225
Shared a comment on a pull request in coronasafe/care_fe on June 18, 2022 at 7:15:00 AM
@cp-Coder @gigincg tried clearing cache in netlify. Still failing.
https://github.com/coronasafe/care_fe/pull/2748#issuecomment-1159381910
Shared a comment on an issue in coronasafe/care_fe on June 18, 2022 at 11:20:50 AM
@gigincg also was this intended to be like navbar in the first place? `lg:absolute` with `right-0 top0` seems to have been added for it's div, but that seems to have a different intention.
https://github.com/coronasafe/care_fe/issues/2756#issuecomment-1159447225
Shared a comment on a pull request in coronasafe/care_fe on June 18, 2022 at 7:15:00 AM
@cp-Coder @gigincg tried clearing cache in netlify. Still failing.
https://github.com/coronasafe/care_fe/pull/2748#issuecomment-1159381910
Shared a comment on an issue in coronasafe/care_fe on June 17, 2022 at 12:05:59 PM
*correction: coronasafe/care#657
https://github.com/coronasafe/care_fe/issues/2159#issuecomment-1158805325
Shared a comment on an issue in coronasafe/care_fe on June 17, 2022 at 11:53:36 AM
Waiting to merge. Done in #2690
https://github.com/coronasafe/care_fe/issues/2741#issuecomment-1158796555
Shared a comment on a pull request in coronasafe/care_fe on June 17, 2022 at 11:18:44 AM
netlify build failing even after clear cache.
https://github.com/coronasafe/care_fe/pull/2736#issuecomment-1158772095
Shared a comment on a pull request in coronasafe/care_fe on June 17, 2022 at 9:38:02 AM
![image](https://user-images.githubusercontent.com/25143503/174271402-f129d52a-a8fa-4a04-b786-9c0081fc205e.png)
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1158695440
Shared a comment on an issue in coronasafe/leaderboard on June 16, 2022 at 2:25:23 PM
Being worked on #52
https://github.com/coronasafe/leaderboard/issues/59#issuecomment-1157722789
Shared a comment on a pull request in coronasafe/care_fe on June 15, 2022 at 12:45:19 PM
@skks1212 can u merge the latest develop again? the one you've is one commit behind the required one and that has a typo in the build command. ![image](https://user-images.githubusercontent.com/25143503/173829995-d1a9fe8c-0db6-4bd8-85c5-250e4d40e46e.png)
https://github.com/coronasafe/care_fe/pull/2702#issuecomment-1156426522
Shared a comment on a pull request in coronasafe/care_fe on June 14, 2022 at 5:52:12 AM
@cp-Coder the issue has been fixed in latest develop 7c4c16a Could you merge that?
https://github.com/coronasafe/care_fe/pull/2427#issuecomment-1154745784
Shared a comment on a pull request in coronasafe/care_fe on June 11, 2022 at 2:41:50 PM
@gigincg @anuran-roy Vercel preview deploy works without clearing cache out of the box for this PR. However netlify preview build failed 3 times even after clearing cache. [Build logs](https://app.netlify.com/sites/care-net/deploys/62a4a77f19201b00093b79a1#L13) says: ``` 8:03:16 PM: Different build command detected, going to use the one specified in the Netlify configuration file: 'CI='' yarn run build' versus 'CI="" yarn run prebuild && CI="" yarn run build || { cat /tmp/* ; sleep 30 ; false; }' in the Netlify UI ```
https://github.com/coronasafe/care_fe/pull/2543#issuecomment-1152940699
Shared a comment on a pull request in coronasafe/care_fe on June 11, 2022 at 2:32:05 PM
@anuran-roy @nihal467 deploy fails even after clear cache and deploy.
https://github.com/coronasafe/care_fe/pull/2543#issuecomment-1152938569
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 1:12:10 PM
Closing as fixed in [c060b4b](https://github.com/coronasafe/care_fe/commit/c060b4b70a19b51838c826fc7dc62f622f5aa6ed)
https://github.com/coronasafe/care_fe/pull/2663#issuecomment-1151102225
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 11:49:09 AM
@Pranshu1902 deploy failing even after clear cache! ![image](https://user-images.githubusercontent.com/25143503/172839447-28a78814-61e6-458b-954c-36140a398552.png) ![image](https://user-images.githubusercontent.com/25143503/172839694-e17b0586-fb29-444b-985c-c88937455c7c.png)
https://github.com/coronasafe/care_fe/pull/2667#issuecomment-1151023046
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 7:24:21 AM
Closing as solved in #2662
https://github.com/coronasafe/care_fe/pull/2660#issuecomment-1150766839
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 7:23:14 AM
@gigincg worked without needing to clear cache and deploy, rebuilt yarn.lock. ![Uploading image.png…]()
https://github.com/coronasafe/care_fe/pull/2662#issuecomment-1150765869
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 7:01:34 AM
will try testing without the plugin in another draft PR to confirm that it's not a coincidence.
https://github.com/coronasafe/care_fe/pull/2660#issuecomment-1150747243
Shared a comment on a pull request in coronasafe/care_fe on June 9, 2022 at 6:50:12 AM
Tried rebuilding the yarn.lock from scratch and now it seems to deploy without needing to clear cache. ![image](https://user-images.githubusercontent.com/25143503/172782885-b4ce235c-1bd5-446d-baef-b4e41f2d658c.png)
https://github.com/coronasafe/care_fe/pull/2660#issuecomment-1150738642
Shared a comment on an issue in coronasafe/leaderboard on June 9, 2022 at 2:14:03 AM
@khavinshankar footer component has been refactored in https://github.com/coronasafe/leaderboard/pull/52/files#diff-3ebccc91178536d06703a58be49b5077d0535c8ff3ab2512af21ca060c5b4e77
https://github.com/coronasafe/leaderboard/issues/56#issuecomment-1150595330
Shared a comment on a pull request in coronasafe/care_fe on June 8, 2022 at 11:25:52 AM
@nihal467 @gigincg how about this one? If mobile, shows the asset type's hint below the selected option. If not mobile, shows a tooltip on hover. Couldn't get the above design to work on chrome. ![image](https://user-images.githubusercontent.com/25143503/172604729-dfd5d67c-8db7-4dab-91a6-6fb145ba5557.png)
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1149793039
Shared a comment on a pull request in coronasafe/care_fe on June 8, 2022 at 6:15:32 AM
@nihal467 will try working on it. that one was using non-native rendering and had issues with different browsers when you tested in #2552 so decided to use the original style itself.
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1149505938
Shared a comment on a pull request in coronasafe/care_fe on June 8, 2022 at 5:30:29 AM
@nihal467 I'm using the native rendering which was used originally 🥲 Just used a better description instead of External and Internal. Could you give me some suggestions to improve?
https://github.com/coronasafe/care_fe/pull/2653#issuecomment-1149480791
Shared a comment on a pull request in coronasafe/care_fe on June 8, 2022 at 5:29:01 AM
@nihal467 #2653 has Asset Class field implemented. This PR does not include that PR branch as base. An asset with asset class defined: https://deploy-preview-2654--care-net.netlify.app/assets/15e5b3e0-c991-418d-b21d-b51c5369e213 An asset without asset class defined: https://deploy-preview-2654--care-net.netlify.app/assets/86c5fc30-98c7-45ad-855f-2c59cc7d2fd2
https://github.com/coronasafe/care_fe/pull/2654#issuecomment-1149479979
Shared a comment on a pull request in coronasafe/care_fe on June 5, 2022 at 5:21:42 PM
@cp-Coder cleared cache and deployed!
https://github.com/coronasafe/care_fe/pull/2427#issuecomment-1146852022
Shared a comment on an issue in coronasafe/care on June 5, 2022 at 11:16:50 AM
@sainAk @iamsdas @vigneshhari Still receiving it as `meta.camera_address` :( ![image](https://user-images.githubusercontent.com/25143503/172047923-15a86fa7-e5d0-4f02-8f2a-5b7688dac1ef.png)
https://github.com/coronasafe/care/issues/759#issuecomment-1146785985
Shared a comment on a pull request in coronasafe/care_fe on June 5, 2022 at 10:46:00 AM
@nihal467 fixed it...
https://github.com/coronasafe/care_fe/pull/2552#issuecomment-1146782156
Shared a comment on a pull request in coronasafe/care_fe on June 5, 2022 at 10:45:12 AM
https://user-images.githubusercontent.com/25143503/172046804-90c6228a-8f37-4f16-b859-972c61e68407.mp4
https://github.com/coronasafe/care_fe/pull/2552#issuecomment-1146782072
Shared a comment on a pull request in coronasafe/care_fe on June 5, 2022 at 10:15:40 AM
@nihal467 unable to reproduce. this is what i see, even from preview deploy. will look into it. ![image](https://user-images.githubusercontent.com/25143503/172045750-1654c71d-96fe-4be1-93cc-2826956df84b.png)
https://github.com/coronasafe/care_fe/pull/2552#issuecomment-1146778449
Shared a comment on an issue in coronasafe/care on June 4, 2022 at 1:31:16 PM
@iamsdas working now! Great :) @sainAk will you be moving this to a new issue as the original issue is now solved.
https://github.com/coronasafe/care/issues/792#issuecomment-1146612293
Shared a comment on an issue in coronasafe/care on June 3, 2022 at 8:58:59 PM
Weren't the migrations run automatically? It's a char field in the last change.
https://github.com/coronasafe/care/issues/792#issuecomment-1146357301
Shared a comment on an issue in coronasafe/care on June 3, 2022 at 12:16:14 PM
@iamsdas I'm using the staging API via proxy mentioned in `care_fe/package.json` I'm yet to setup a local care BE on my machine. ![image](https://user-images.githubusercontent.com/25143503/171849660-749941b9-314e-494f-b7df-696037c63ac8.png) - What I'm performing is: ```sh curl 'https://careapi.coronasafe.in/api/v1/asset/' \ -X POST \ -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0' \ -H 'Accept: application/json, text/plain, */*' \ -H 'Accept-Language: en-US,en;q=0.5' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Content-Type: application/json' \ -H 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ0b2tlbl90eXBlIjoiYWNjZXNzIiwiZXhwIjoxNjU0MjU4MjY5LCJqdGkiOiIwZjgyMTQ5Mzc4MjY0ZWUyYTJmNzVlNDFmYzllMmRjMSIsInVzZXJfaWQiOjIwMn0.gp1grpzzKDH3ZCPoRSI_XTLX-IoZnWDATUcZQpolwuU' \ -H 'Origin: http://localhost:4000' \ -H 'Connection: keep-alive' \ -H 'Referer: http://localhost:4000/facility/4fa7d5bf-1862-4ebb-b2d1-8284d12185ac/assets/new' \ -H 'Sec-Fetch-Dest: empty' \ -H 'Sec-Fetch-Mode: cors' \ -H 'Sec-Fetch-Site: same-origin' \ --data-raw ' { "name": "Hello Asset :wave:", "asset_type": "INTERNAL", "asset_class": "ONVIF", "description": "", "is_working": "true", "not_working_reason": "", "serial_number": "", "warranty_details": "", "location": "afa28ab1-53f5-4554-8cb0-77c1e5d58c37", "vendor_name": "", "support_name": "", "support_email": "", "support_phone": "+917777777777", "qr_code_id": "", "cancelToken": { "promise": {} } }' ``` - And I'm getting the following for the above. ![image](https://user-images.githubusercontent.com/25143503/171851175-e385b0d2-8d30-419c-889e-e7e3b61b5e1f.png) - However, if I just remove `asset_class` attribute in the same above cURL command: ```sh curl 'https://careapi.coronasafe.in/api/v1/asset/' \ -X POST \ -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0' \ -H 'Accept: application/json, text/plain, */*' \ -H 'Accept-Language: en-US,en;q=0.5' \ -H 'Accept-Encoding: gzip, deflate, br' \ -H 'Content-Type: application/json' \ -H 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ0b2tlbl90eXBlIjoiYWNjZXNzIiwiZXhwIjoxNjU0MjU4MjY5LCJqdGkiOiIwZjgyMTQ5Mzc4MjY0ZWUyYTJmNzVlNDFmYzllMmRjMSIsInVzZXJfaWQiOjIwMn0.gp1grpzzKDH3ZCPoRSI_XTLX-IoZnWDATUcZQpolwuU' \ -H 'Origin: http://localhost:4000' \ -H 'Connection: keep-alive' \ -H 'Referer: http://localhost:4000/facility/4fa7d5bf-1862-4ebb-b2d1-8284d12185ac/assets/new' \ -H 'Sec-Fetch-Dest: empty' \ -H 'Sec-Fetch-Mode: cors' \ -H 'Sec-Fetch-Site: same-origin' \ --data-raw ' { "name": "Hello Asset :wave:", "asset_type": "INTERNAL", "description": "", "is_working": "true", "not_working_reason": "", "serial_number": "", "warranty_details": "", "location": "afa28ab1-53f5-4554-8cb0-77c1e5d58c37", "vendor_name": "", "support_name": "", "support_email": "", "support_phone": "+917777777777", "qr_code_id": "", "cancelToken": { "promise": {} } }' ``` - I'm getting a good response for that: ![image](https://user-images.githubusercontent.com/25143503/171851568-8201dd1e-38a0-4a1e-bd3a-367eb724f981.png)
https://github.com/coronasafe/care/issues/792#issuecomment-1145903172
Shared a comment on an issue in coronasafe/care on June 3, 2022 at 10:07:59 AM
@vigneshhari @iamsdas still getting 500 as response :/ Am I doing something wrong or...? ![image](https://user-images.githubusercontent.com/25143503/171834317-b5c65b96-dec5-469f-997f-4c221bb5f892.png)
https://github.com/coronasafe/care/issues/792#issuecomment-1145809297
Shared a comment on a pull request in coronasafe/leaderboard on June 2, 2022 at 3:49:38 PM
Closing as re-worked with new changes on #52. Ocean of merge conflicts in this.
https://github.com/coronasafe/leaderboard/pull/35#issuecomment-1145019246
Shared a comment on an issue in coronasafe/care_fe on June 1, 2022 at 3:50:33 PM
part of #2616
https://github.com/coronasafe/care_fe/issues/2560#issuecomment-1143784109
Shared a comment on a pull request in coronasafe/care_fe on June 1, 2022 at 2:29:50 PM
@anuran-roy I've cleared cache and triggered deploy. but still it's failing :/ I can also see that you do have the latest develop here... ![image](https://user-images.githubusercontent.com/25143503/171428721-c7f6d99f-43d8-44da-8189-1da93380ecdf.png)
https://github.com/coronasafe/care_fe/pull/2543#issuecomment-1143686313
Shared a comment on an issue in coronasafe/care_fe on June 1, 2022 at 1:29:43 PM
@developedBySJ it becomes visible in staging deploy once empty cache and hard reload is done.
https://github.com/coronasafe/care_fe/issues/2560#issuecomment-1143614991
Shared a comment on an issue in coronasafe/leaderboard on May 31, 2022 at 4:42:42 PM
Or can github workflow itself do it alone? 🤔
https://github.com/coronasafe/leaderboard/issues/32#issuecomment-1142373264
Shared a comment on an issue in coronasafe/leaderboard on May 31, 2022 at 4:40:56 PM
Can't nextjs itself handle it? How about this? We'll make an API endpoint in nextjs that'll dispatch an email with sendgrid or anything. And invoke that endpoint every week by a github workflow? 😎
https://github.com/coronasafe/leaderboard/issues/32#issuecomment-1142371668
Shared a comment on an issue in coronasafe/leaderboard on May 31, 2022 at 3:08:46 PM
How about sending a weekly report to mail about their activity last week to mail?
https://github.com/coronasafe/leaderboard/issues/32#issuecomment-1142260093
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:26:22 AM
@anuran-roy deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2543#issuecomment-1141830400
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:24:04 AM
@skks1212 deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2563#issuecomment-1141819700
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:21:12 AM
@Pranshu1902 deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2499#issuecomment-1141815785
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:17:31 AM
@Marmik2003 deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2581#issuecomment-1141811980
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:12:45 AM
@rabilrbl deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2567#issuecomment-1141807094
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:10:07 AM
@rabilrbl deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2570#issuecomment-1141804363
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 8:08:00 AM
@kunatastic deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2579#issuecomment-1141802171
Shared a comment on a pull request in coronasafe/care_fe on May 31, 2022 at 7:42:45 AM
@Pranshu1902 deploy preview is failing. merge the latest develop branch.
https://github.com/coronasafe/care_fe/pull/2586#issuecomment-1141779019
Shared a comment on an issue in coronasafe/care_fe on May 31, 2022 at 6:20:59 AM
@developedBySJ Tried to trace where the issue is coming from, but no clue... Was able to reproduce this issue when reviewing `cra-5` branch #2527
https://github.com/coronasafe/care_fe/issues/2560#issuecomment-1141711267
Shared a comment on an issue in coronasafe/care_fe on May 31, 2022 at 6:16:37 AM
**Steps to reproduce:** ```sh git checkout develop git fetch upstream git pull upstream develop yarn start ``` On firefox 100.0.2 ![image](https://user-images.githubusercontent.com/25143503/171105319-368a8c7d-67be-454e-b659-7eb96a1f5408.png)
https://github.com/coronasafe/care_fe/issues/2560#issuecomment-1141708526
Shared a comment on an issue in coronasafe/care_fe on May 31, 2022 at 5:48:47 AM
@developedBySJ The text fields seems to have additional unintended border when focused. Also it strikes through the labels.
https://github.com/coronasafe/care_fe/issues/2560#issuecomment-1141692446
Shared a comment on a pull request in coronasafe/care_fe on May 30, 2022 at 12:46:56 PM
https://user-images.githubusercontent.com/25143503/170995258-2de66c3f-caba-4119-9585-3b9a425a25a0.mp4
https://github.com/coronasafe/care_fe/pull/2552#issuecomment-1141117781
Shared a comment on a pull request in coronasafe/care_fe on May 30, 2022 at 12:22:30 PM
Closes #2431 #2432
https://github.com/coronasafe/care_fe/pull/2552#issuecomment-1141092299
Shared a comment on a pull request in coronasafe/care_fe on May 29, 2022 at 12:12:26 PM
@nihal467 @coronasafe/code-reviewers
https://github.com/coronasafe/care_fe/pull/2470#issuecomment-1140436663
Shared a comment on a pull request in coronasafe/leaderboard on May 29, 2022 at 6:22:21 AM
@gigincg updated padding ![image](https://user-images.githubusercontent.com/25143503/170855096-81b78e28-ff17-42aa-83ad-53c13c457740.png)
https://github.com/coronasafe/leaderboard/pull/19#issuecomment-1140386254
Shared a comment on a pull request in coronasafe/leaderboard on May 29, 2022 at 6:05:59 AM
![image](https://user-images.githubusercontent.com/25143503/170854596-b792ff64-421b-4eaa-83dd-45c622a3f435.png)
https://github.com/coronasafe/leaderboard/pull/17#issuecomment-1140384313
Shared a comment on a pull request in coronasafe/leaderboard on May 29, 2022 at 12:51:11 AM
The badges looks nice 🔥
https://github.com/coronasafe/leaderboard/pull/12#issuecomment-1140351322
Shared a comment on a pull request in coronasafe/care_fe on May 28, 2022 at 1:22:24 PM
Netlify preview does show up with current date time for me. ![image](https://user-images.githubusercontent.com/25143503/170827410-dc225c9e-b9c1-4893-8337-322ed5e314d5.png)
https://github.com/coronasafe/care_fe/pull/2473#issuecomment-1140264675
Shared a comment on an issue in coronasafe/care_fe on May 27, 2022 at 11:00:26 AM
@gigincg should this field be a required field?
https://github.com/coronasafe/care_fe/issues/2431#issuecomment-1139512633
Shared a comment on an issue in coronasafe/care_fe on May 24, 2022 at 11:38:34 AM
@gigincg I'm thinking of taking this up. Two approaches can be there. ### 1. Client Side Where each preset is traversed and selected at an interval controlled by the client side. However in this method the middleware will not be aware whether a client is using patrol mode or not, and hence other clients who might access the same camera will also not be aware of this. Set preset requests may conflict the order if more than one client accesses it. ### 2. Server side An endpoint for the camera can be exposed to enable patrol mode, and also status response can include whether the resource is in patrol mode or not. Hence every client will be aware whether it's in patrol mode or not. Presets are traversed and selected by the middleware/backend, hence order is maintained regardless of multiple clients accessing the resource. Preset traverse interval can be optionally adjusted by client.
https://github.com/coronasafe/care_fe/issues/2160#issuecomment-1135802926
Shared a comment on a pull request in coronasafe/care_fe on May 21, 2022 at 3:43:30 PM
@rabilrbl got it, my bad, didn't see that. @gigincg this PR is also resolving closing the drawer also when notification's visit is clicked. I have merged rabil's #2423 into this.
https://github.com/coronasafe/care_fe/pull/2466#issuecomment-1133656792
Shared a comment on a pull request in coronasafe/care_fe on May 18, 2022 at 12:41:23 PM
- Added shortcut keys for patient feed. - Added help menu that lists all shortcut keys (in both asset cam feed and patient feed) ![image](https://user-images.githubusercontent.com/25143503/169040603-acae41b9-3f3d-45ba-8c7b-2f4e3ae93104.png) ![image](https://user-images.githubusercontent.com/25143503/169040697-0e763ba1-59ca-4b71-a76e-e00325138141.png)
https://github.com/coronasafe/care_fe/pull/2381#issuecomment-1129957278
Shared a comment on an issue in coronasafe/care_fe on May 16, 2022 at 2:46:27 PM
- [ ] `Ctrl` + `Up`: Move Camera Up - [ ] `Ctrl` + `Left`: Move Camera Left - [ ] `Ctrl` + `Down`: Move Camera Down - [ ] `Ctrl` + `Right`: Move Camera Right - [ ] `Alt` + `S`: Save / Update Preset - [ ] `Alt` + `X`: Stop feed - [ ] `Alt` + `R`: Reset Feed - [ ] `Alt` + `+`: Zoom In - [ ] `Alt` + `-`: Zoom Out - [ ] `F`: Enter full-screen (Exit full-screen shortcut is handled by browser itself) Any suggestions? @gigincg
https://github.com/coronasafe/care_fe/issues/2374#issuecomment-1127768998
Shared a comment on an issue in coronasafe/care_fe on May 14, 2022 at 1:11:46 PM
@cp-Coder [here](http://localhost:4000/facility/05980e8f-8860-4460-b863-fefdff1d187b/patient/e45b93eb-4b1a-4f91-9b6f-3533b719e9a6/consultation/008e06f1-20fa-44a1-b665-bb1d9b21d04e/daily_rounds/72e37048-f117-4c23-aed2-6c77558b09f1/update) inside ABG Analaysis.
https://github.com/coronasafe/care_fe/issues/2257#issuecomment-1126713875
*Issues Raised* • <https://github.com/coronasafe/care_fe/issues/2483|#2483> *PRs* • <https://github.com/coronasafe/care_fe/pull/2485|#2485>
*Issues Raised* • <https://github.com/coronasafe/care_fe/issues/2469|#2469> (Sourcing .env causes command not found errors) *PRs* • <https://github.com/coronasafe/care_fe/pull/2464|#2464> (Improves UI in Facility Create Page for Oxygen Related Fields) • <https://github.com/coronasafe/care_fe/pull/2465|#2465> (Collapse notification side bar when visit link is clicked on any notification) • <https://github.com/coronasafe/care_fe/pull/2466|#2466> (Collapse drawer onclick) • <https://github.com/coronasafe/care_fe/pull/2470|#2470> (Fixes missing quotes in .env)
No progress today. Spent little time cleaning the code related to <https://github.com/coronasafe/care_fe/issues/2436|#2436>
• Working on <https://github.com/coronasafe/care_fe/issues/2436|#2436> • Created issue <https://github.com/coronasafe/care_fe/issues/2438|#2438>
Worked on <https://github.com/coronasafe/care_fe/pull/2381|#2381> • Added shortcut keys for camera controls in patient feed • Added help menu that lists all shortcut keys (in both asset cam feed and patient feed)
Mainly worked on <https://github.com/coronasafe/care_fe/pull/2381|#2381> and improvements in <https://github.com/coronasafe/care_fe/pull/2336|#2336>
Working on <https://github.com/coronasafe/care_fe/issues/2374|#2374>
Was not productive in `care` today. Was just working on adding keyboard shortcuts for live feed controls, and primarily worked on side project today.
Submitted 2 PRs and worked on side project.
Setup care_fe locally. Shoutout to <@U02TB8XHZD1> for helping me out with issues in setting up.
No updates for so far. Just reached home morning, spent time cleaning up room, setting up environment and relaxed a bit. Will be starting to explore/fix/create issues from now.
Worked on <https://github.com/coronasafe/care_fe/pull/2518|#2518> after yesterdays EOD update. Was not productive in care today. Had boring training sessions and worked on side project.
*Issues Raised:* • <https://github.com/coronasafe/care_fe/issues/2510|#2510> *PRs:* • <https://github.com/coronasafe/care_fe/pull/2511|#2511>
Working on <https://github.com/coronasafe/care_fe/pull/2552|care_fe/#2552> Raised an issue <https://github.com/coronasafe/care/issues/792|care/#792>
*Issues raised:* • <https://github.com/coronasafe/care_fe/issues/2564|#2564> (`createMui` deprecated, but had to close it, since it was already resolved as part of another PR) • <https://github.com/coronasafe/care_fe/issues/2560|#2560> Text field style issue where double border is present. *PRs worked on:* • <http://Resolves%20deprecated%20`createMuiTheme`%20https://github.com/coronasafe/care_fe/pull/2565|#2565> (closed before merge for the same reason of 2564). *Issues worked on:* • <https://github.com/coronasafe/care_fe/issues/2432|#2432> (hints for external and internal asset.. yet to make a PR)
Was not productive in care today... Spent time learning nextjs by using it for my side project. Updated PR: <https://github.com/coronasafe/care_fe/pull/2552|#2552> and marked as waiting for backend.
*Issues Raised:* • Activity card goes behind Contributor Info Card in some sizes <https://github.com/coronasafe/leaderboard/issues/18|leaderboard/18> • Activity time not formatted <https://github.com/coronasafe/leaderboard/issues/16|leaderboard/16> • Activity type "issue_closed" is not handled in renderText <https://github.com/coronasafe/leaderboard/issues/14|leaderboard/14> • Contributor profile page width not correct in mobile. <https://github.com/coronasafe/leaderboard/issues/10|leaderboard/10> • InfoCard content incorrectly aligned in different window size <https://github.com/coronasafe/leaderboard/issues/8|leaderboard/8> *Pull Requests:* • Fix activity card being hidden in `md` sizes <https://github.com/coronasafe/leaderboard/pull/19|leaderboard/19> • Format activity time <https://github.com/coronasafe/leaderboard/pull/17|leaderboard/17> • Handle `issue_closed` GitHub activity in renderText <https://github.com/coronasafe/leaderboard/pull/15|leaderboard/15> • Hides "currently working on" if data is empty <https://github.com/coronasafe/leaderboard/pull/11|leaderboard/11> • Responsive alignment for InfoCard Content <https://github.com/coronasafe/leaderboard/pull/9|leaderboard/9> *Blockers:* • Unable to debug the issue <https://github.com/coronasafe/care_fe/issues/2560|care_fe/2560>.
*Issues Raised:* • <https://github.com/coronasafe/leaderboard/issues/36> *PRs:* • <https://github.com/coronasafe/leaderboard/pull/35>
Tried to be productive, but spent lots of hours on why a python decorator was not working on my side project, and finally it worked magically by simply commenting and uncommenting it back. :confused: *Issues raised after yesterdays EOD update:* • <https://github.com/coronasafe/leaderboard/issues/40> • <https://github.com/coronasafe/leaderboard/issues/42>
*PRs* • Fixes unintended border in focused inputs <https://github.com/coronasafe/care_fe/pull/2622> Partially worked on resolving the plethora of merge conflicts • Monthly Leaderboard <https://github.com/coronasafe/leaderboard/pull/35>
Reopened an issue <https://github.com/coronasafe/care/issues/792|care/792> while testing <https://github.com/coronasafe/care_fe/pull/2552|care_fe/2552> (Related to adding Asset Class field) *PRs Raised:* • Hide "copy logs from previous logs" if first consultation update <https://github.com/coronasafe/care_fe/pull/2644|care_fe/2644> • Closed leaderboard/35 (Monthly leaderboard) and recreated it again (<https://github.com/coronasafe/leaderboard/pull/52|leaderboard/52>) as resolving conflicts gone out of my hands :sweat_smile:
Nothing much for today. • Just tested a long waiting PR after the backend issue was solved - <https://github.com/coronasafe/care_fe/pull/2552|#2552> • Attended a pre-placement talk by silicon labs. • Worked on side project rest of the time.
• Worked on fixing <https://github.com/coronasafe/care_fe/pull/2552> (Hints for Asset Type, where different browsers rendered it differently) • Worked on side project. • Started exploring on building portfolio using NextJS + Tailwind • Went out for a movie :popcorn:
*PRs* • <https://github.com/coronasafe/care_fe/pull/2654|care_fe/2654> Hides the configure asset button if `asset_class` is undefined / null • <https://github.com/coronasafe/care_fe/pull/2653|care_fe/2653> Re-work of 2552 as my system didn't like me working on that branch for some reason :confused:
Focused on side project today.
• Worked on <https://github.com/coronasafe/care_fe/pull/2653> (3rd time test failed :sweat_smile:) • Purchased a domain...
• Raised three PR's and closed all three of them, to debug the netlify cache issue. (2660, 2662, 2663) • Configured personal email with custom domain. • Worked on side project, mostly ideating things...
When i started to work on the coordinates issue PR, it lead to system crash (season 2) and.... Changed SSD+HDD to SSD+SSD config, and realized my bootloader was in the HDD. Somehow managed to rescue ubuntu after hours with help of <@U02TB8XHZD1> :tada: Windows.... (will recover him sometime later or never?)
• Probably figured out a way for the cache issues.:crossed_fingers: • Working on <https://github.com/coronasafe/care_fe/pull/2653|2653> to improve the dropdown by making a select menu using tailwind instead of mui.
Sadly not much updates for today... • A lead engineer from General Electric pinged me about one of my old project and wanted help in setting up MQTT with Azure Digital Twin. Almost half of the day went there... • Spent time in creating custom components in tailwind for my portfolio. • Will finish this issue by tonight: <https://github.com/coronasafe/care_fe/issues/2656>
PRs • adds rewrites for vercel <https://github.com/coronasafe/care_fe/pull/2691> • fix incorrect coorindates validation <https://github.com/coronasafe/care_fe/pull/2690>
Working on <https://github.com/coronasafe/leaderboard/pull/52> to make `getHighlights` more generic.
Working on: • <https://github.com/coronasafe/leaderboard/pull/52> • <https://github.com/coronasafe/care_fe/pull/2653>
Nothing much today. Went for a loooong drive and was tired. Worked on and almost completed adding custom select menu (<https://github.com/coronasafe/care_fe/pull/2653>). Will be pushing it by tonight mostly.
Issues Raised: • <https://github.com/coronasafe/care_fe/issues/2737> PRs: • <https://github.com/coronasafe/care_fe/pull/2653>
Issues: • <https://github.com/coronasafe/care_fe/issues/2756> PRs: • <https://github.com/coronasafe/care_fe/pull/2754>
No updates. Time flew trying to bring windows back alive as college is about to start, but failed / gave up. Exploring FastAPI too.
PRs: • <https://github.com/coronasafe/care_fe/pull/2781> • <https://github.com/coronasafe/care_fe/pull/2780>
Worked on side project and updated monthly leaderboard PR.
Working on <https://github.com/coronasafe/care_fe/issues/2210> and gonna setup backend to work on it's related issue <https://github.com/coronasafe/care/issues/875>
PRs: • <https://github.com/coronasafe/care/pull/887|https://github.com/coronasafe/care/pull/887> • <https://github.com/coronasafe/care/pull/885|https://github.com/coronasafe/care/pull/885> Issues: • <https://github.com/coronasafe/care/issues/886|https://github.com/coronasafe/care/issues/886>
No updates. Got busy with packing and travelling to college.
Was occupied with settling in hostel and now getting hit with looooots of sad news from VIT. Made a small PR... *PRs:* • <https://github.com/coronasafe/care_fe/issues/2873>
Issues: • <https://github.com/coronasafe/care_fe/issues/2918> PRs: • <https://github.com/coronasafe/care_fe/pull/2919> (in progress)
Won't be able to attend today's EOD. Made a draft PR <https://github.com/coronasafe/leaderboard/pull/66|https://github.com/coronasafe/leaderboard/pull/66> Updated PR <https://github.com/coronasafe/care_fe/pull/2919|https://github.com/coronasafe/care_fe/pull/2919>
No updates :upside_down_face: day was packed
Worked on <https://github.com/coronasafe/care_fe/issues/2880> Not much progress due to college and lots of assignments :smiling_face_with_tear: Exams coming next week too.
Working on the same PR <https://github.com/coronasafe/care_fe/issues/2880> Couldn't attend EOD as day was very packed.
Couldnt get anything done today... loots of classes being rescheduled and super tired.
updating after a week. exams got over two days ago. was packed with projects. no updates so far. :confused:
no updates, just running here and there shuttling between placement activities, project reviews and assignments.
Updates: Back home. College subjects and exams over, just capstone project and comprehensive exam left. PRs: • Fix leaderboard static date range <https://github.com/coronasafe/leaderboard/pull/72> • Made the Grays in the Vital Card more transparent <https://github.com/coronasafe/care_fe/pull/3368>
Worked on <https://github.com/coronasafe/care_fe/pull/3010> Patient filters, converting to Tailwind Select Menus... Will be updating it with MultiSelectMenus for `last admitted to` field and range selector for age min/max.
Worked on implementing multi select menu tailwind component
Raised an issue: <https://github.com/coronasafe/care_fe/issues/3424> and fixed it: <https://github.com/coronasafe/care_fe/pull/3425>
Worked on Asset Reg v2 backend <https://github.com/coronasafe/care/pull/984>
Worked on two PRs • Updated with new goal for EN locale. <https://github.com/coronasafe/care_fe/pull/3456> • Updated Create/Update Asset Form with new fields in frontend. Yet to add those fields in the asset detail page. <https://github.com/coronasafe/care_fe/pull/3458>
Working on asset create/update page redesign
Working on asset create/update page redesign and updated the patient card hover effect to be in sync with asset listing page's hover effects
Updated SelectMenu tailwind component design to not be so greenish and minor updates in asset form design
Worked on asset manage page (implementing the warranty card, not completed yet) and updated the landing page goal for all languages.
Updated asset manage page and warranty card
Working on implementing searchable select menu
Raised two issues and made two PRs: • `goBack` was defined 17+ times (issue <https://github.com/coronasafe/care_fe/issues/3518|#3518> fixed in <https://github.com/coronasafe/care_fe/pull/3520|#3520>) • Local body field in User Add page was not handling change (issue <https://github.com/coronasafe/care_fe/issues/3519|#3519> fixed in <https://github.com/coronasafe/care_fe/pull/3521|#3521>) Working on facility cover image feat. (issue <https://github.com/coronasafe/care_fe/issues/2171|#2171>)
Working on facility cover image feat. (issue <https://github.com/coronasafe/care_fe/issues/2171|#2171>)
• Working on making making care landing page responsive (<https://github.com/coronasafe/care_fe/pull/3456|3456>)
• <https://github.com/coronasafe/care_fe/pull/3456|#3456> Made landing page with new goal's PR responsive. Test got approved while typing this :marioluigidancing: • <https://github.com/coronasafe/care_fe/pull/3520|#3520> Updated `goBack` utility PR to be in `utils.ts` instead of `goBack.ts` • <https://github.com/coronasafe/care_fe/pull/3458|#3458> Working on implementing `SearchSelectMenuV2` tailwind component in the Asset reg v2 PR.
• <https://github.com/coronasafe/care/pull/1006|care/#1006> Marked `warranty_details` as deprecated in BE. • <https://github.com/coronasafe/care/pull/885|care/#885> Resolved conflicts for modify covid category to patient category BE PR. • <https://github.com/coronasafe/care_fe/pull/3458|care_fe/#3458> Cleaned asset reg v2 PR and made ready for testing. • Working on `SearchSelectV2` tailwind component.
• Reworked on Deprecating Covid Category BE PR: <https://github.com/coronasafe/care/pull/1007> as previous PR became too dirty. • Working on Select Menu with Search and FE for the above issue.
PR <https://github.com/coronasafe/care_fe/pull/3565>
Raised a PR <https://github.com/coronasafe/care_dashboard/pull/16|care_dashboard/16> for the issue <https://github.com/coronasafe/care_dashboard/issues/15|care_dashboard#15>
Won't be able to attend today's EOD as I have exam by Visa. Updates: Working on filters for care dashboard, Tailwind buttons and Switch.
Implemented Tailwind Component `SwitchV2` . Coming via <https://github.com/coronasafe/care_fe/pull/3458|care_fe/3458> Working on data fetching hooks for dashboard and combobox tailwind component
• Backend for covid category deprecation and new patient category got merged. <https://github.com/coronasafe/care_fe/pull/3565/commits/0f41d35874d9c0433ddfd7d3602db77bdd2e33f1|Fixed a minor bug> in it's corresponding front end PR. • Working on Cypress workflow needs local care. Issue: <https://github.com/coronasafe/care_fe/issues/3587|care_fe#3587>
Worked on <https://github.com/coronasafe/care_fe/pull/3588>. Completed configuring local BE for Cypress workflow. Most of the cypress tests failing with local due to missing data. Need to fix that too.
Breathing tailwind with <https://github.com/coronasafe/care_fe/issues/3594>.
tailwinding <https://github.com/coronasafe/care_fe/issues/3594> :)
Made single column layout for <https://github.com/coronasafe/care_fe/pull/3458|Asset Registration V2> Yet to make the current section highlight and sidebar persistent.
Fixed the issue with cypress local care's devdistrictadmin account creation. Working on issue with state options not being shown in user add page.
Made the sidebar persistent and current section highlight in asset reg v2. Implemented utility hook: `useVisibility` to achieve current section awareness.
Nothing for today. Was not feeling well morning. Prepared and attended technical interview of <https://galaxeye.space>. Got shortlisted for HR round tomorrow.
Populated dummy data and all cypress tests passing except for Sample Test's test. Working on populating sample tests too. Made a management command `load_dummy_data` that can be run only in local environment.
All cypress test cases passing with local care in workflow :slightly_smiling_face: *PRs:* • <https://github.com/coronasafe/care/pull/1037|care/1037>: Implements `load_dummy_data` management command to seed the DB so that cypress can work with local care in the workflow. • <https://github.com/coronasafe/care/pull/1039|care#1039>: Docs for the new management command `load_dummy_data` • <https://github.com/coronasafe/care_fe/pull/3588|care_fe/3588>: Cypress workflow with local care is ready. Waiting for it to be merged. *Issues Raised:* • <https://github.com/coronasafe/care_fe/issues/3653|care_fe/3653>
Tailwinding :hammer: the consultation form
• <https://github.com/coronasafe/care_fe/pull/3672|care_fe#3672> Updated care_fe's README. See <https://github.com/rithviknishad/care_fe/blob/update-readme/README.md|preview>. • <https://github.com/coronasafe/care_fe/pull/3681|care_fe#3681> Working on minor improvements asset manage / update form.
• Made a PR along with <@U02TB83Q5V0> <https://github.com/coronasafe/care_fe/pull/3681|#3681> that improves various minor issues in the asset manage and create page. • Use `Inter` font as per figma design <https://github.com/coronasafe/care_fe/pull/3683|#3683>
Working on: • Redesign Patient Filters <https://github.com/coronasafe/care_fe/pull/3697|#3697> • Facility cover image upload feat.
Nothing much today, focused on my power grid project.
• <https://github.com/coronasafe/care/pull/1053| adds facility s3 region code> in care BE. • Adds support for option specific icon in select menu (coming via Patient Filters redesign PR)
• Working on <https://github.com/coronasafe/care_fe/pull/3719|Tailwinds the Patient Registration> with <@U02T4HD63P0> • <https://github.com/coronasafe/care/pull/1055|Adds `archive_reason` to FileUpload and validate if is_archived>
• Implements colours for patient category <https://github.com/coronasafe/care_fe/pull/3728|#3728> • Got storybook working. <https://github.com/coronasafe/care_fe/pull/3726|#3726>
• <https://github.com/coronasafe/care_dashboard/pull/35|Implemented Data Fetching Hooks for Care Dashboard> • Raised an <https://github.com/coronasafe/care_fe/issues/3742|epic issue> to track tailwinding care.
• Worked on <https://github.com/coronasafe/care_fe/pull/3528|Facility Cover Image Feature>
• Shows facility cover photo in facility home (<https://deploy-preview-3528--care-net.netlify.app/facility/eeb23cb7-1524-479a-825e-660311386b47|preview>) and edit as per discussed permissions. • Made `MultiSelectMenuV2` tailwind component, coming via <https://github.com/coronasafe/care_fe/pull/3744|Patient Filters redesign PR.>
• Updated `MultiSelectMenuV2` to show selected options below the field. • Tried to get tailwind-element's datepicker working, but failed.
• Added a new component `ImageWithFallback` which wraps `img` component, to show loading animation, to show fallback component if error while fetching, and to retry fetching the image. <https://github.com/coronasafe/care_fe/pull/3528#issuecomment-1278496912|PR>. • Tested out deploying storybook to vercel. • Implemented `ButtonV2` component with various presets and styling options to have consistent styling across app. Component API inspired from <https://vercel.com/design/button|Vercel Style Guide's Button>
• Worked on storybook + added dark mode support for storybook :slightly_smiling_face: • Unfortunately language server is not working for .mdx based stories. Figuring it out.
Worked on `FieldValidator` for form field components
• Wrapped DatePicker as FormField and fixed auto close datepicker on focus lost, by making it a popover component in both dashboard and care_fe. • Fixed minor issues in async autocomplete field.
• <https://github.com/coronasafe/care_fe/pull/3528|Cover Image PR> removed the image with fallback component, and set img alt as `facility.name` • :book:<https://github.com/coronasafe/care_fe/pull/3744| Storybook + >:hammer_and_wrench:<https://github.com/coronasafe/care_fe/pull/3744| Tailwind Patient Filters> add stories of new tailwind components, ready for testing and review. Won't be able to attend EODs today and tomorrow, off to Bangalore for Cisco Startup Summit event.
Made a PR <https://github.com/coronasafe/care/pull/1072> And fixed minor issues existing PRs.
• Made a PR <https://github.com/coronasafe/care_fe/pull/3803> • Working on sidebar redesign
• Working on Sidebar Redesign
Won't be able to join EOD today. • Completed: <https://github.com/coronasafe/care_fe/pull/3920>
PRs: • <https://github.com/coronasafe/care_fe/pull/3951|fix antenatal and vaccinated doses filter issues in patient fitlers> • <https://github.com/coronasafe/care_fe/pull/3942|AutoCompleteAsync: make button and input as peers instead of parent children> • <https://github.com/coronasafe/care_fe/pull/3941|Sidebar: fix current tab detection logic>
won't be able to attend eod today. made a pr: <https://github.com/coronasafe/care_fe/pull/3936|https://github.com/coronasafe/care_fe/pull/3936>
• Corrected few issues with AsyncAutocomplete component • PR: <https://github.com/coronasafe/care_fe/pull/3959|Fixes facility card layout spacing issue below the action buttons bar> • Working on implementing modals with tailwind (will be replacing Notify Facility's as of now)
*Worked on:* • Introduced `authorisedFor` callback prop (defaulting to `AuthorisedFor.Anyone`) for ButtonV2, to bring in functionality equivalent to RoleButton (coming along with Gokuls PR for facility home page redesign). • User filters: fix phone number parse issue when cleared <https://github.com/coronasafe/care_fe/pull/3970|#3970> *Issues raised:* • When shifting between pages in log update, the screen scrolls to the top <https://github.com/coronasafe/care_fe/issues/3986|#3986> • Too much whitespace when a log updates list page has too little cards on the current page <https://github.com/coronasafe/care_fe/issues/3985|#3985> • Improve the way we display the linked facilities of a user such that it does not affect other users cards. <https://github.com/coronasafe/care_fe/issues/3984|#3984> • DateRangePickerV2 should not allow selecting end date that's before start date. <https://github.com/coronasafe/care_fe/issues/3983|#3983> • Clear the input fields in patient filters when Clear Filter is pressed <https://github.com/coronasafe/care_fe/issues/3982|#3982> • Disallow incorrect entry from patient's age filter <https://github.com/coronasafe/care_fe/issues/3981|#3981>
Implemented useFilters hook and completed migrating facilities page. <https://github.com/coronasafe/care_fe/pull/4041|https://github.com/coronasafe/care_fe/pull/4041> Won't be able to attend eod today
Working on failed tests for useFilters PR. Won't be able to attend today's EOD. Outside.
• Followed up: <https://github.com/coronasafe/care_fe/pull/3959|Fixes issues in Facility Card's layout and minor UI tweaks> • Resolved conflicts: <https://github.com/coronasafe/care_fe/pull/3996|Adds Slideover tailwind component + UI tweaks in Notification List + Adds asset class filter> • Made a PR: <https://github.com/coronasafe/care_fe/pull/4142|Remove pages and components used under `/teleicu/...`>
Made a PR: <https://github.com/coronasafe/care_fe/pull/4238|Migrate leaked unicons to CareIcons>
*PRs:* • <https://github.com/coronasafe/care_fe/pull/4384|care_fe/4384> (the high memory usage for firefox is fixed) • <https://github.com/coronasafe/care_fe/pull/4388|care_fe/4388>
May not be able to attend today's EOD. My today's updates: • Followed up on responsiveness issues of Virtual Nursing Assistant with <@U022THM4U2U> • Reviewed <https://github.com/coronasafe/care_fe/pull/3799|medical history and health details EPIC PR> • Made a PR: <https://github.com/coronasafe/care_fe/pull/5059|Highlight English as default language if no language preference present.>
EOD 12/05/2023 - 13/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day(s) go? • fixed a couple more migration issues for the prescriptions module and tested them with <@U022THM4U2U> (testing migrations is a pain although simple :smiling_face_with_tear:) • removed medicines from critical care and consultation updates table from medicines tab • tested: refactor discharge summary PR • reviewed 5 react-for-all submissions • huddles with <@U051NJK18KU> to clear some doubts What's next? • review course submissions (if any) • follow up on prescriptions/discharge summary (if any) • work on vitals monitor • integrate medibase APIs for `MedicineFormField`
EOD 15/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Had weekly <!subteam^S035L5S02RF|@care_engineering> sync call. • Mostly worked on displaying non-waveform contents on the vitals monitor and making it responsive. • <https://github.com/coronasafe/care/pull/1295|care#1295>: Added a facility filter for AssetBeds viewset to reduce the number of API calls dispatched by CNS. What's next? • Vitals Monitor: Complete the integration to care (priority) • Discharge Summary & Prescriptions: Merge discharge summary to prescriptions, setup S3 locally and make related changes (priority) • Vitals Monitor: Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries (currently there's only 1 out of 2016 entries, so BP data coming is rare) • Vitals Monitor: clear buffer on overflow and setup auto-reconnect if disconnected
EOD 16/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Vitals Monitor: Completed integrating it into CNS and Asset Configure. (Works now, however some API optimizations could be made) • Discharge Summary & Prescriptions: Merged discharge summary to prescriptions and completed making related changes, works fine. • Reviewed 2 react for all submissions. What's next? • Vitals Monitor (P2): Make necessary back-end changes to have an endpoint dedicated to retrieve patient and asset beds together. • Vitals Monitor (P2): clear buffer on overflow and setup auto-reconnect if disconnected • Vitals Monitor (P3): Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries
EOD 17/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Discharge Summary & Prescriptions: Fixed some issues in discharge summary during testing and *finally it's tested* :smiley: • Huddles with <@U022THM4U2U> on the same. • Vitals Monitor: Worked on making necessary back-end changes to have an endpoint dedicated to retrieve patient and asset beds together. • Huddled with <@U051NJK18KU> to clear minor doubts. What's next? • Vitals Monitor (P1): Complete creating API and mark Vitals Monitor for testing. • Vitals Monitor (P2): clear buffer on overflow and setup auto-reconnect if disconnected • Vitals Monitor (P3): Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries • Look into issues suitable for Code4GovTech
EOD 18/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Vitals Monitor: Completed creating dedicated API to list patient asset beds for CNS & Monitoring Hub and integrated it in FE too. (FE: <https://github.com/coronasafe/care_fe/pull/5466|#5466>, BE: <https://github.com/coronasafe/care/pull/1302|#1302>) • Had a huddle with <@U022THM4U2U> and <@U01JB8L8P7Y> to discuss about react-csv issue and discusses about issues for C4GT • Downgraded react-csv for compatibility reasons. • Filed some issues for C4GT What's next? • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries • Integrate Medibase • Look into zoom download script
EOD 19/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Merged discharge and prescriptions back-end, but murphy's law happened and got to know better about migrations the hard way. • Made a draft pr to fix the migrations. <https://github.com/coronasafe/care/pull/1305> • Learn about pg_dump and dumped staging db to my local with the help of <@UPW6XDGDD> • Tried pg_restore in my local but taking more than 1.5 hrs (still running). • Huddled with <@U022THM4U2U> and <@U01JB8L8P7Y> to create issues for C4GT What's next? • Follow up on testing the migrations fix on staging db on a clone or local if pg_restore completes locally by morning. • Review react-for-all submissions • Review centralise linting PR • Integrate Medibase • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries • Look into zoom download script
EOD 20/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Tested and updated migrations with staging clone db with help of <@UPW6XDGDD>. Finally works. • Reviewed all pending (6) react for all submissions. • Went through the centralise linting PR's diffs. What's next? • Complete reviewing centralise linting PR • Integrate Medibase • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries • Look into zoom download script
EOD 22/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Reviewed 8 react for all submissions and 2 FE PRs • Reviewed and Requested changes for centralise linting for BE PR What's next? • POC for Ventilator Integration (Priority) • Integrate Medibase • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries
EOD 23/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Ventilator Integration PoC ready (<https://github.com/coronasafe/care_fe/pull/5503|care_fe#5503>) • Added support for Ventilator Asset in BE (<https://github.com/coronasafe/care/pull/1307|care/1307>) • Created mock-ventilator (fork of mock-cns) to test ventilator visualisations (<https://github.com/coronasafe/mock-ventilator|coronasafe/mock-ventilator>) • Reviewed 3 react-for-all submissions What's next? • Apply feedbacks for the Ventilator visualisation and setting of hide monitors without patients as default. • Integrate Medibase • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries.
EOD 24/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Looked into 10bedICU repo to figure out issue with maps for puducherry • Huddles with <@U022THM4U2U> and <@UPW6XDGDD> to help figure out issue reported from prod: "When we search Bed 7, Bed 7 is missing, Bed 17 shows". • Learnt how to use Metabase to translate that bug into whats actually happening and brushed up SQL query skills with help of <@UPW6XDGDD> • <https://github.com/coronasafe/care/pull/1314|care#1314> fixes it as the above happens due to a weird workflow where if you select a bed first and selects a non-admission decision where patient is discharged when saving consultation itself. But bed data is still sent (although it shouldn't be), and back-end accepts it (although it shouldn't be). • <https://github.com/coronasafe/care/pull/1312|care#1312> prevents occupied beds from being deleted. • Re-ordered prescriptions migration fixes and merged it. • Reviewed 2 react for all submissions What's next? • Apply feedbacks for the Ventilator visualisation and setting of hide monitors without patients as default. • Integrate Medibase • Programmatically modify mock vitals `data.json` to have more `blood-pressure` entries.
EOD 26/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Reviewed 6 react for all submission. • Reviewed couple of open source PRs and assisted them. • Fixed a minor P1 bug in backend where discharge notes shouldn't be mandatory. <https://github.com/coronasafe/care/pull/1315|care#1315> • Disable browser autocomplete for custom autocomplete components. <https://github.com/coronasafe/care_fe/pull/5541|care_fe#5541> • Fix issue with non-admission consultation redirects <https://github.com/coronasafe/care_fe/pull/5535|care_fe#5535> • Huddles with <@U022THM4U2U> for all of the above What's next? • Fix edge cases with PatientAssetBed view for CNS
EOD 27/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Reviewed 4 react for all submissions • Reviewed couple of open source PRs
EOD 29/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Had weekly <!subteam^S035L5S02RF|@care_engineering> sync call. • Huddles with <@U022THM4U2U> to dig deep into issues related to AssetBeds affecting CNS. • Disallows modifying `Asset.asset_class` • Manually cascade delete `AssetBed` if `Asset` or `Bed` is deleted and migrations for the same. • Disallow linking HL7 Monitor or Ventilator with a bed that is already occupied with an asset of the same asset_class. • Fix `bed_is_occupied` filter of `PatientAssetBed` view. | <https://github.com/coronasafe/care/pull/1325|care#1325> • Had a meet with SmartICU team along with <@UPW6XDGDD> to debug issues with waveforms. • Reviewed couple of open source PRs. What's next? • Review react for all submissions • Integrate Medibase
EOD 30/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Minor fix that caused all phone number fields to be focused by default. <https://github.com/coronasafe/care_fe/pull/5569|care_fe/5569> • Reviewed 3 react for all submissions • Minor clean up: removed unused legacy component ConfirmDialog <https://github.com/coronasafe/care_fe/pull/5571|care_fe#5571> • Reviewed couple of PRs • Helped <@U022THM4U2U> to test centralize linting PR by setting up local django with staging replica DB. What's next? • Review react for all submissions • Integrate Medibase
EOD 31/05/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Reviewed 2 react for all submissions • Reviewed some PRs • Worked on building custom phone number input instead of using package. Almost done. • Minor fix: added fallback for heart-rate and pulse-rate in HL7 monitor. What's next? • Add flag support and finish custom phone number input. • Make backend changes to support medibase medicines.
EOD 05/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Tried resolving cypress fails in phone number form field. • Finished the Front-end for Medibase. • Created a script that would map out old medicines to medibase medicines and have insights on its coverage. What's next? • Draft the migrations for medibase • Follow up on cypress fails on Phone Number PR • Work on zoom recordings to drive automation script
EOD 06/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Not a productive day. Just followed up on the mappings for medibase. What's next? • Medibase: Move to postgres instead of in-memory db • Medibase: Create a google sheet to get 1to1 mapping and update medibase to show IDs • Work on zoom recordings to drive automation script
EOD 09/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Added `UserAutocompleteFormField` tailwind based component to replace MUI based `UserSelect` component. <https://github.com/coronasafe/care_fe/pull/5626|care_fe#/5626> • Changed to `ReactDOM.createRoot` from `ReactDOM.render`<https://github.com/coronasafe/care_fe/pull/5627| care_fe#5627> • MUI hunting yielded <https://github.com/coronasafe/care_fe/pull/5628|5628>, <https://github.com/coronasafe/care_fe/pull/5629|5629>, <https://github.com/coronasafe/care_fe/pull/5630|5630>, <https://github.com/coronasafe/care_fe/pull/5631|5631> • Fixed couple of issues in the medibase in-memory search loaded from psql table.
EOD 08/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • <https://github.com/coronasafe/care_fe/pull/5622|care_fe#5622>: Changed to build preview to improve cypress CI performance. (Reduced workflow times from ~60m to ~23m) • <https://github.com/coronasafe/care/pull/1361|care#1361>: Custom migration to cleanup casing for migrated prescription's frequencies. • Updated migrations mapping sheet to include suggested medibase and almost completed the medibase backend. What's next? • Create mapping migrations once mappings are ready • Add stats for nerds to vitals monitor • Work on zoom script
EOD 08/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Fixed cypress issues with `PhoneNumberFormField` • Created sheet for 1to1 mapping and updated medibase to show & copy medicine ID • Worked on moving medibase to postgres instead of in-memory db • Went for MUI hunting and replaced 7 files with CareUI (<https://github.com/coronasafe/care_fe/pull/5613|5613>, <https://github.com/coronasafe/care_fe/pull/5614|5614>, <https://github.com/coronasafe/care_fe/pull/5615|5615>, <https://github.com/coronasafe/care_fe/pull/5616|5616>, <https://github.com/coronasafe/care_fe/pull/5617|5617>, <https://github.com/coronasafe/care_fe/pull/5618|5618>, <https://github.com/coronasafe/care_fe/pull/5619|5619>) What's next? • Complete medibase to psql • Add stats for nerds to vitals monitor • Work on zoom script
EOD 12/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Followed up medibase and marked for testing. • Fix phone number form field not disabling. What's next? • Follow up on changes required in previous PRs
EOD 13/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Followed up on previous PRs that required changes and cypress fixes • Minor follow ups on fixes for medibase (caught when testing with staging replica) • <https://github.com/coronasafe/care_fe/pull/5649|5649>: Deprecated `RoleButton` and replaced it with `ButtonV2` • <https://github.com/coronasafe/care_fe/pull/5654|5654>: Adds new AutocompleteFormField components for State, District & Local Body selects. • 13 replacements of MUI to CareUI: <https://github.com/coronasafe/care_fe/pull/5650|5650>, <https://github.com/coronasafe/care_fe/pull/5653|5653>, <https://github.com/coronasafe/care_fe/pull/5654|5654>, <https://github.com/coronasafe/care_fe/pull/5655|5655>, <https://github.com/coronasafe/care_fe/pull/5656|5656>, <https://github.com/coronasafe/care_fe/pull/5657|5657>, <https://github.com/coronasafe/care_fe/pull/5658|5658>, <https://github.com/coronasafe/care_fe/pull/5660|5660>, <https://github.com/coronasafe/care_fe/pull/5661|5661>, <https://github.com/coronasafe/care_fe/pull/5662|5662>, <https://github.com/coronasafe/care_fe/pull/5663|5663>, <https://github.com/coronasafe/care_fe/pull/5664|5664>, <https://github.com/coronasafe/care_fe/pull/5665|5665> What's next? • Add screenshots and fix cypress if any for the above made tailwind PRs • Work on zoom script • More tailwinds to come...
EOD 14/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Added Ventilator and Vitals waveform in patient consultation dashboard • Huddles with <@U022THM4U2U> on testing medibase and added custom sort logic to sort by exact match first. • <https://github.com/coronasafe/care_fe/pull/5672|5672>: Minor fix in the initial and merged states of user filters for phone number fields • <https://github.com/coronasafe/care_fe/pull/5670|5670>: Show delete user button only for superuser/stateadmin users • Couple of replacements of MUI to CareUI What's next? • Add backend tests and update cypress tests for medibase/prescriptions • Show device online or not in waveform component • Add screenshots and fix cypress if any for the above made tailwind PRs • Tailwind care... • Work on zoom script
EOD 19/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Followed up some existing PRs to fix responsiveness and cypress issues. • Worked on tailwinding DailyRounds.tsx Form • Got my macbook m2 air :grin: What's next? • Finish tailwinding DailyRounds • Add summary view in 10bedICU • Work on zoom script • Uninstall material ui from care • Setup dev env in m2 air • Upgrade leaderboard to nextjs13's app router
EOD 20/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Couple of minor improvements on Vitals Monitor. • Setting up of git, vscode, volta, node, etc.... • Rest of the day pretty unproductive, mostly time spent on figuring out how to use mac. Realised my external mouse and keyboard doesn't work well with mac. My mouse is detected as keyboard for some reason. Natural scrolling is opposite in my mouse. Flipping it makes it behave opposite in trackpad although fixes for mouse. What's next? (same as yesterday)
EOD 21/06/2023 <!subteam^S035L5S02RF|@care_engineering> How did the day go? • Added summary to state page in 10bedICU • Spent some time analyzing the vitals monitor data of smarticu. • Fixed a P1 bug where current_bed was not being cleared when discharged in BE and made a custom migration. • Fixed improper z-index present in vitals monitor causing weird overlapping issues. What's next? • Configurable gain for vitals monitor